xl: common_domname issue

xl: common_domname issue

[Oleksandr Grytsov]

Hi All,

There is global variable common_domname in xl.c.
It is used for domain migration. But there is an issue with it in
following use case:
if for example I call find_domain in xl_parse.c to find backend id for
a device parameter and then
issue reboot command for this domain, reboot fails as common_domname set to
the backend name.
Fail occurs due to following lines in xl_vmcontrol.c:

                if (common_domname
                    && strcmp(d_config.c_info.name, common_domname)) {
                    d_config.c_info.name = strdup(common_domname);
                }

It means that find_domain can be used only in specific places and only
for domain that
is currently handled. Is it expected behavior?

Thanks.
-- 
Best Regards,
Oleksandr Grytsov.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: xl: common_domname issue

[Wei Liu]

On Wed, Apr 05, 2017 at 04:13:42PM +0300, Oleksandr Grytsov wrote:
> Hi All,
> 
> There is global variable common_domname in xl.c.
> It is used for domain migration. But there is an issue with it in
> following use case:
> if for example I call find_domain in xl_parse.c to find backend id for
> a device parameter and then
> issue reboot command for this domain, reboot fails as common_domname set to
> the backend name.
> Fail occurs due to following lines in xl_vmcontrol.c:
> 
>                 if (common_domname
>                     && strcmp(d_config.c_info.name, common_domname)) {
>                     d_config.c_info.name = strdup(common_domname);
>                 }
> 
> It means that find_domain can be used only in specific places and only
> for domain that
> is currently handled. Is it expected behavior?

Feel free to refactor the code if find it unfit for your purpose.

Wei.

> 
> Thanks.
> -- 
> Best Regards,
> Oleksandr Grytsov.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel