Re: [HMM 14/16] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE

From: Jerome Glisse <jglisse@redhat.com>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Cc: John Hubbard <jhubbard@nvidia.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	David Nellans <dnellans@nvidia.com>,
	Evgeny Baskakov <ebaskakov@nvidia.com>,
	Mark Hairgrove <mhairgrove@nvidia.com>,
	Sherry Cheung <SCheung@nvidia.com>,
	Subhash Gutti <sgutti@nvidia.com>
Subject: Re: [HMM 14/16] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE
Date: Thu, 6 Apr 2017 17:22:47 -0400	[thread overview]
Message-ID: <20170406212247.GA4723@redhat.com> (raw)
In-Reply-To: <20170405204026.3940-15-jglisse@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 112 bytes --]


So during rebase on lastest mmotm one if branch logic got inversed.
Attached is a fixup patch.

Cheers,
Jérôme

[-- Attachment #2: 0001-fixup-mm-hmm-devmem-device-memory-hotplug-using-ZONE.patch --]
[-- Type: text/plain, Size: 734 bytes --]

>From 374bca39b19a88da1d1c6d38c0a4c49c1af31c18 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= <jglisse@redhat.com>
Date: Thu, 6 Apr 2017 17:16:56 -0400
Subject: [PATCH] fixup! mm/hmm/devmem: device memory hotplug using ZONE_DEVICE

---
 mm/hmm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hmm.c b/mm/hmm.c
index ff8ec59..f567a8b 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -898,7 +898,7 @@ static int hmm_devmem_pages_create(struct hmm_devmem *devmem)
 	ret = arch_add_memory(nid, align_start, align_size,
 			      devmem->pagemap.type);
 	mem_hotplug_done();
-	if (!ret)
+	if (ret)
 		goto error_add_memory;
 
 	for (pfn = devmem->pfn_first; pfn < devmem->pfn_last; pfn++) {
-- 
2.9.3

