From: Andrea Arcangeli <aarcange@redhat.com> To: Martin Kepplinger <martink@posteo.de>, Thorsten Leemhuis <regressions@leemhuis.info>, daniel.vetter@intel.com, Dave Airlie <airlied@gmail.com>, Chris Wilson <chris@chris-wilson.co.uk> Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 0/5] Re: [Intel-gfx] [BUG][REGRESSION] i915 gpu hangs under load Date: Fri, 7 Apr 2017 01:23:42 +0200 [thread overview] Message-ID: <20170406232347.988-1-aarcange@redhat.com> (raw) In-Reply-To: <87pogtplxr.fsf@intel.com> I'm also getting kernel hangs every couple of days. For me it's still not fixed here in 4.11-rc5. It's hard to reproduce, the best reproducer is to build lineageos 14.1 on host while running LTP in a guest to stress the guest VM. Initially I thought it was related to the fact I upgraded the xf86 intel driver just a few weeks ago (I deferred any upgrade of the userland intel driver since last July because of a regression that never got fixed and broke xterm for me). After I found a workaround for the userland regression (appended at the end for reference) I started getting kernel hangs but they are separate issues as far as I can tell. It's not well tested so beware... (it survived a couple of builds and some VM reclaim but that's it). The first patch 1/5 is the potential fix for the i915 kernel hang. The rest are incremental improvements. And I've no great solution for when the shrinker was invoked with the struct_mutex held and and recurse on the lock. I don't think we can possibly wait in such case (other than flush work that the second patch does) but then practically it shouldn't be a big deal, the big RAM eater is unlikely to be i915 when the system is low on memory. Andrea Arcangeli (5): i915: avoid kernel hang caused by synchronize rcu struct_mutex deadlock i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker i915: initialize the free_list of the fencing atomic_helper i915: schedule while freeing the lists of gem objects i915: fence workqueue optimization drivers/gpu/drm/i915/i915_gem.c | 15 +++++++++++++++ drivers/gpu/drm/i915/i915_gem_shrinker.c | 15 +++++++++++---- drivers/gpu/drm/i915/intel_display.c | 7 ++++--- 3 files changed, 30 insertions(+), 7 deletions(-) === Userland workaround for unusable xterm after commit 3d3d18f086cdda72ee18a454db70ca72c6e3246c (unrelated to this kernel issue, just for reference of what I'm running in userland). diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c index 11beb90..d349203 100644 --- a/src/sna/sna_accel.c +++ b/src/sna/sna_accel.c @@ -17430,11 +17430,15 @@ sna_flush_callback(CallbackListPtr *list, pointer user_data, pointer call_data) { struct sna *sna = user_data; +#if 0 if (!sna->needs_dri_flush) return; +#endif sna_accel_flush(sna); +#if 0 sna->needs_dri_flush = false; +#endif } static void
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com> To: Martin Kepplinger <martink@posteo.de>, Thorsten Leemhuis <regressions@leemhuis.info>, daniel.vetter@intel.com, Dave Airlie <airlied@gmail.com>, Chris Wilson <chris@chris-wilson.co.uk> Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 0/5] Re: [BUG][REGRESSION] i915 gpu hangs under load Date: Fri, 7 Apr 2017 01:23:42 +0200 [thread overview] Message-ID: <20170406232347.988-1-aarcange@redhat.com> (raw) In-Reply-To: <87pogtplxr.fsf@intel.com> I'm also getting kernel hangs every couple of days. For me it's still not fixed here in 4.11-rc5. It's hard to reproduce, the best reproducer is to build lineageos 14.1 on host while running LTP in a guest to stress the guest VM. Initially I thought it was related to the fact I upgraded the xf86 intel driver just a few weeks ago (I deferred any upgrade of the userland intel driver since last July because of a regression that never got fixed and broke xterm for me). After I found a workaround for the userland regression (appended at the end for reference) I started getting kernel hangs but they are separate issues as far as I can tell. It's not well tested so beware... (it survived a couple of builds and some VM reclaim but that's it). The first patch 1/5 is the potential fix for the i915 kernel hang. The rest are incremental improvements. And I've no great solution for when the shrinker was invoked with the struct_mutex held and and recurse on the lock. I don't think we can possibly wait in such case (other than flush work that the second patch does) but then practically it shouldn't be a big deal, the big RAM eater is unlikely to be i915 when the system is low on memory. Andrea Arcangeli (5): i915: avoid kernel hang caused by synchronize rcu struct_mutex deadlock i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker i915: initialize the free_list of the fencing atomic_helper i915: schedule while freeing the lists of gem objects i915: fence workqueue optimization drivers/gpu/drm/i915/i915_gem.c | 15 +++++++++++++++ drivers/gpu/drm/i915/i915_gem_shrinker.c | 15 +++++++++++---- drivers/gpu/drm/i915/intel_display.c | 7 ++++--- 3 files changed, 30 insertions(+), 7 deletions(-) === Userland workaround for unusable xterm after commit 3d3d18f086cdda72ee18a454db70ca72c6e3246c (unrelated to this kernel issue, just for reference of what I'm running in userland). diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c index 11beb90..d349203 100644 --- a/src/sna/sna_accel.c +++ b/src/sna/sna_accel.c @@ -17430,11 +17430,15 @@ sna_flush_callback(CallbackListPtr *list, pointer user_data, pointer call_data) { struct sna *sna = user_data; +#if 0 if (!sna->needs_dri_flush) return; +#endif sna_accel_flush(sna); +#if 0 sna->needs_dri_flush = false; +#endif } static void _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-04-06 23:24 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-22 8:38 [BUG][REGRESSION] i915 gpu hangs under load Martin Kepplinger 2017-03-22 10:36 ` [Intel-gfx] " Jani Nikula 2017-03-22 10:36 ` Jani Nikula 2017-04-02 11:50 ` [Intel-gfx] " Thorsten Leemhuis 2017-04-02 11:50 ` Thorsten Leemhuis 2017-04-02 12:13 ` [Intel-gfx] " Martin Kepplinger 2017-04-02 12:13 ` Martin Kepplinger 2017-04-03 15:09 ` [Intel-gfx] " Jani Nikula 2017-04-03 15:09 ` Jani Nikula 2017-04-06 23:23 ` Andrea Arcangeli [this message] 2017-04-06 23:23 ` [PATCH 0/5] " Andrea Arcangeli 2017-04-06 23:23 ` [PATCH 1/5] i915: avoid kernel hang caused by synchronize rcu struct_mutex deadlock Andrea Arcangeli 2017-04-06 23:23 ` Andrea Arcangeli 2017-04-07 9:05 ` [Intel-gfx] " Joonas Lahtinen 2017-04-07 9:05 ` Joonas Lahtinen 2017-04-06 23:23 ` [PATCH 2/5] i915: flush gem obj freeing workqueues to add accuracy to the i915 shrinker Andrea Arcangeli 2017-04-06 23:23 ` Andrea Arcangeli 2017-04-07 10:02 ` Chris Wilson 2017-04-07 10:02 ` Chris Wilson 2017-04-07 13:06 ` Andrea Arcangeli 2017-04-07 13:06 ` Andrea Arcangeli 2017-04-07 15:30 ` Chris Wilson 2017-04-07 15:30 ` Chris Wilson 2017-04-07 16:48 ` Andrea Arcangeli 2017-04-07 16:48 ` Andrea Arcangeli 2017-04-10 9:39 ` Chris Wilson 2017-04-10 9:39 ` Chris Wilson 2017-04-06 23:23 ` [PATCH 3/5] i915: initialize the free_list of the fencing atomic_helper Andrea Arcangeli 2017-04-06 23:23 ` Andrea Arcangeli 2017-04-07 10:35 ` Chris Wilson 2017-04-07 10:35 ` Chris Wilson 2017-04-06 23:23 ` [PATCH 4/5] i915: schedule while freeing the lists of gem objects Andrea Arcangeli 2017-04-06 23:23 ` Andrea Arcangeli 2017-04-06 23:23 ` [PATCH 5/5] i915: fence workqueue optimization Andrea Arcangeli 2017-04-06 23:23 ` Andrea Arcangeli 2017-04-07 9:58 ` Chris Wilson 2017-04-07 9:58 ` Chris Wilson 2017-04-07 13:13 ` Andrea Arcangeli 2017-04-07 13:13 ` Andrea Arcangeli 2017-04-10 10:15 ` [PATCH 0/5] Re: [Intel-gfx] [BUG][REGRESSION] i915 gpu hangs under load Martin Kepplinger 2017-04-10 10:15 ` [PATCH 0/5] " Martin Kepplinger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170406232347.988-1-aarcange@redhat.com \ --to=aarcange@redhat.com \ --cc=airlied@gmail.com \ --cc=chris@chris-wilson.co.uk \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=martink@posteo.de \ --cc=regressions@leemhuis.info \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.