Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs

[Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

On Fri, Apr 07, 2017 at 11:12:53AM +0200, Linus Walleij wrote:
> On Fri, Apr 7, 2017 at 10:48 AM, Charles Keepax
> > On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote:

> >> > Get included in all subdrivers I suppose?

> >> > So you are broadcasting 8800+ lines into every subdriver across the
> >> > entire kernel.

> >> > Just the time spent in the preprocessor parsing this will affect compilation
> >> > time.

> >> Or maybe this is a necessary sacrifice to get the regmap cache
> >> centralized in MFD. I don't know. I feel stupid.

> >> I guess I should focus on "my" subsystems...

> > This only gets included in files that are part of this driver, it
> > shouldn't affect compilation time for anyone not building the
> > madera driver and even then it should only affect compilation
> > times for the 10 or so C files that make up the driver. Also I
> > don't really see any other way to specify the registers for the
> > device.

> No when using regmap cache this seems necessary.
> I was just wrong.

Right.  The other thing to bear in mind with things like this is that
often if it's the chip vendor they've got mechanisms to generate the
register definitions directly from the chip design so if we take the
complete thing with minimal edits it's a great way of ensuring we've got
information about the chip in the upstream kernel to support future
development.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]