All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
	Vijay Kilari <vijay.kilari@gmail.com>,
	Shanker Donthineni <shankerd@codeaurora.org>
Subject: [PATCH v6 13/36] ARM: GICv3: enable ITS and LPIs on the host
Date: Fri,  7 Apr 2017 18:32:44 +0100	[thread overview]
Message-ID: <20170407173307.9788-14-andre.przywara@arm.com> (raw)
In-Reply-To: <20170407173307.9788-1-andre.przywara@arm.com>

Now that the host part of the ITS code is in place, we can enable the
ITS and also LPIs on each redistributor to get the show rolling.
At this point there would be no LPIs mapped, as guests don't know about
the ITS yet.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 xen/arch/arm/gic-v3-its.c |  4 ++++
 xen/arch/arm/gic-v3.c     | 18 ++++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
index 1951ec8..1dad428 100644
--- a/xen/arch/arm/gic-v3-its.c
+++ b/xen/arch/arm/gic-v3-its.c
@@ -505,6 +505,10 @@ static int gicv3_its_init_single_its(struct host_its *hw_its)
         return -ENOMEM;
     writeq_relaxed(0, hw_its->its_base + GITS_CWRITER);
 
+    /* Now enable interrupt translation and command processing on that ITS. */
+    reg = readl_relaxed(hw_its->its_base + GITS_CTLR);
+    writel_relaxed(reg | GITS_CTLR_ENABLE, hw_its->its_base + GITS_CTLR);
+
     return 0;
 }
 
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 63dbc21..54fbb19 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -620,6 +620,21 @@ static int gicv3_enable_redist(void)
     return 0;
 }
 
+/* Enable LPIs on this redistributor (only useful when the host has an ITS). */
+static bool gicv3_enable_lpis(void)
+{
+    uint32_t val;
+
+    val = readl_relaxed(GICD_RDIST_BASE + GICR_TYPER);
+    if ( !(val & GICR_TYPER_PLPIS) )
+        return false;
+
+    val = readl_relaxed(GICD_RDIST_BASE + GICR_CTLR);
+    writel_relaxed(val | GICR_CTLR_ENABLE_LPIS, GICD_RDIST_BASE + GICR_CTLR);
+
+    return true;
+}
+
 static int __init gicv3_populate_rdist(void)
 {
     int i;
@@ -731,11 +746,14 @@ static int gicv3_cpu_init(void)
     if ( gicv3_enable_redist() )
         return -ENODEV;
 
+    /* If the host has any ITSes, enable LPIs now. */
     if ( gicv3_its_host_has_its() )
     {
         ret = gicv3_its_setup_collection(smp_processor_id());
         if ( ret )
             return ret;
+        if ( !gicv3_enable_lpis() )
+            return -EBUSY;
     }
 
     /* Set priority on PPI and SGI interrupts */
-- 
2.9.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-04-07 17:31 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 17:32 [PATCH v6 00/36] arm64: Dom0 ITS emulation Andre Przywara
2017-04-07 17:32 ` [PATCH v6 01/36] ARM: GICv3 ITS: parse and store ITS subnodes from hardware DT Andre Przywara
2017-04-07 17:51   ` Stefano Stabellini
2017-04-07 18:02   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 02/36] ARM: GICv3 ITS: initialize host ITS Andre Przywara
2017-04-07 17:32 ` [PATCH v6 03/36] ARM: GICv3: allocate LPI pending and property table Andre Przywara
2017-04-07 18:04   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 04/36] ARM: GICv3 ITS: allocate device and collection table Andre Przywara
2017-04-07 17:32 ` [PATCH v6 05/36] ARM: GICv3 ITS: map ITS command buffer Andre Przywara
2017-04-07 17:32 ` [PATCH v6 06/36] ARM: GICv3 ITS: introduce ITS command handling Andre Przywara
2017-04-07 17:32 ` [PATCH v6 07/36] ARM: GICv3 ITS: introduce host LPI array Andre Przywara
2017-04-07 17:55   ` Stefano Stabellini
2017-04-07 18:08   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 08/36] ARM: vGICv3: introduce ITS emulation stub Andre Przywara
2017-04-07 17:57   ` Stefano Stabellini
2017-04-07 18:09   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 09/36] ARM: GICv3 ITS: introduce device mapping Andre Przywara
2017-04-07 18:21   ` Stefano Stabellini
2017-04-07 19:21     ` Andre Przywara
2017-04-07 18:21   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 10/36] ARM: GIC: Add checks for NULL pointer pending_irq's Andre Przywara
2017-04-07 18:32   ` Julien Grall
2017-04-07 19:07   ` Stefano Stabellini
2017-04-07 20:46     ` André Przywara
2017-04-07 20:58       ` Julien Grall
2017-04-07 21:45         ` Stefano Stabellini
2017-04-07 22:09           ` Stefano Stabellini
2017-04-07 22:12             ` André Przywara
2017-04-07 17:32 ` [PATCH v6 11/36] ARM: GICv3: introduce separate pending_irq structs for LPIs Andre Przywara
2017-04-07 18:49   ` Stefano Stabellini
2017-04-07 21:02     ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 12/36] ARM: GICv3: forward pending LPIs to guests Andre Przywara
2017-04-07 18:59   ` Stefano Stabellini
2017-04-07 21:09   ` Julien Grall
2017-04-07 17:32 ` Andre Przywara [this message]
2017-04-07 19:10   ` [PATCH v6 13/36] ARM: GICv3: enable ITS and LPIs on the host Stefano Stabellini
2017-04-07 17:32 ` [PATCH v6 14/36] ARM: vGICv3: handle virtual LPI pending and property tables Andre Przywara
2017-04-07 21:29   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 15/36] ARM: introduce vgic_access_guest_memory() Andre Przywara
2017-04-07 21:35   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 16/36] ARM: vGICv3: re-use vgic_reg64_check_access Andre Przywara
2017-04-09 19:39   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 17/36] ARM: GIC: clear LPI pending bit on cleaning up LR Andre Przywara
2017-04-07 17:32 ` [PATCH v6 18/36] ARM: GIC: export vgic_init_pending_irq() Andre Przywara
2017-04-09 19:40   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 19/36] ARM: VGIC: add vcpu_id to struct pending_irq Andre Przywara
2017-04-07 22:11   ` Julien Grall
2017-04-07 22:14     ` Stefano Stabellini
2017-04-07 22:19       ` Julien Grall
2017-04-07 22:31         ` Stefano Stabellini
2017-04-07 22:52           ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 20/36] ARM: vGICv3: add virtual ITS list head and comment about iteration Andre Przywara
2017-04-07 17:32 ` [PATCH v6 21/36] ARM: GICv3: prepare for virtual ITS subnodes Andre Przywara
2017-04-07 22:59   ` Julien Grall
2017-04-07 23:06     ` André Przywara
2017-04-07 23:12       ` Julien Grall
2017-04-07 23:23         ` André Przywara
2017-04-07 17:32 ` [PATCH v6 22/36] ARM: vGIC: advertise LPI support Andre Przywara
2017-04-09 19:37   ` Julien Grall
2017-04-07 17:32 ` [PATCH v6 23/36] ARM: vGICv3: handle disabled LPIs Andre Przywara
2017-04-07 17:32 ` [PATCH v6 24/36] ARM: vITS: add command handling stub and MMIO emulation Andre Przywara
2017-04-09 20:16   ` Julien Grall
2017-04-11 15:49     ` Andre Przywara
2017-04-07 17:32 ` [PATCH v6 25/36] ARM: vITS: introduce translation table walks Andre Przywara
2017-04-07 17:32 ` [PATCH v6 26/36] ARM: vITS: handle CLEAR command Andre Przywara
2017-04-07 17:32 ` [PATCH v6 27/36] ARM: vITS: handle INT command Andre Przywara
2017-04-07 17:32 ` [PATCH v6 28/36] ARM: vITS: handle MAPC command Andre Przywara
2017-04-07 17:33 ` [PATCH v6 29/36] ARM: vITS: handle MAPD command Andre Przywara
2017-04-07 17:33 ` [PATCH v6 30/36] ARM: vITS: handle MAPTI command Andre Przywara
2017-04-07 17:33 ` [PATCH v6 31/36] ARM: vITS: handle MOVI command Andre Przywara
2017-04-07 17:33 ` [PATCH v6 32/36] ARM: vITS: handle DISCARD command Andre Przywara
2017-04-07 17:33 ` [PATCH v6 33/36] ARM: vITS: handle INV command Andre Przywara
2017-04-07 17:33 ` [PATCH v6 34/36] ARM: vITS: handle INVALL command Andre Przywara
2017-04-07 17:33 ` [PATCH v6 35/36] ARM: vITS: create and initialize virtual ITSes for Dom0 Andre Przywara
2017-04-07 17:33 ` [PATCH v6 36/36] ARM: vITS: create ITS subnodes for Dom0 DT Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407173307.9788-14-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=julien.grall@arm.com \
    --cc=shankerd@codeaurora.org \
    --cc=sstabellini@kernel.org \
    --cc=vijay.kilari@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.