[Buildroot] [PATCH 1/1] xenomai: Add config for enabling SMP for 3.x

[Buildroot] [PATCH 1/1] xenomai: Add config for enabling SMP for 3.x

[Pawel Sikora]

Add a config option for enabling SMP in Xenomai
userspace, only for versions >= 3.x

In 2.x versions this option was enabled by
default, so for now behaviour for it will
not change, while as buildroot supports
now Xenomai 3.0.3 it's good to let users
have this option.

Add a comment about this config's behaviour
above this option in the menuconfig.

Signed-off-by: Pawel Sikora <sikor6@gmail.com>
---
 package/xenomai/Config.in  | 12 ++++++++++++
 package/xenomai/xenomai.mk |  4 ++++
 2 files changed, 16 insertions(+)

diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
index b548ee810..cd323545c 100644
--- a/package/xenomai/Config.in
+++ b/package/xenomai/Config.in
@@ -51,6 +51,18 @@ config BR2_PACKAGE_XENOMAI_VERSION
 	  BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
 	  Kernel -> Linux Kernel Extensions menu.
 
+comment "-------------------------------------------------------"
+comment "Please note:                                           "
+comment "Option for enabling SMP in Xenomai userspace is meant  "
+comment "only for Xenomai 3.x                                   "
+comment "If you use Xenomai 2.x you have SMP enabled by default."
+comment "-------------------------------------------------------"
+
+config BR2_PACKAGE_XENOMAI_ENABLE_SMP
+	bool "Enable SMP"
+	help
+	  This option allows to enable SMP in Xenomai userspace.
+
 config BR2_PACKAGE_XENOMAI_TESTSUITE
 	bool "Install testsuite"
 	help
diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
index c9e810e05..7af4e0cf5 100644
--- a/package/xenomai/xenomai.mk
+++ b/package/xenomai/xenomai.mk
@@ -23,6 +23,10 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-user
 
 XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/ --disable-doc-install
 
+ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
+XENOMAI_CONF_OPTS += --enable-smp
+endif
+
 define XENOMAI_REMOVE_DEVFILES
 	for i in xeno-config xeno-info wrap-link.sh ; do \
 		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
-- 
2.12.1

[Buildroot] [PATCH 1/1] xenomai: Add config for enabling SMP for 3.x

[Arnout Vandecappelle]

On 07-04-17 01:46, Pawel Sikora wrote:
> Add a config option for enabling SMP in Xenomai
> userspace, only for versions >= 3.x
> 
> In 2.x versions this option was enabled by
> default, so for now behaviour for it will
> not change, while as buildroot supports
> now Xenomai 3.0.3 it's good to let users
> have this option.
> 
> Add a comment about this config's behaviour
> above this option in the menuconfig.
> 
> Signed-off-by: Pawel Sikora <sikor6@gmail.com>
> ---
>  package/xenomai/Config.in  | 12 ++++++++++++
>  package/xenomai/xenomai.mk |  4 ++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index b548ee810..cd323545c 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -51,6 +51,18 @@ config BR2_PACKAGE_XENOMAI_VERSION
>  	  BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
>  	  Kernel -> Linux Kernel Extensions menu.
>  
> +comment "-------------------------------------------------------"
> +comment "Please note:                                           "
> +comment "Option for enabling SMP in Xenomai userspace is meant  "
> +comment "only for Xenomai 3.x                                   "
> +comment "If you use Xenomai 2.x you have SMP enabled by default."

 Do we really still support Xenomai 2.x? Do our patches apply to it?

 Anyway, instead of putting this in a comment, just put it in the help text.

> +comment "-------------------------------------------------------"
> +
> +config BR2_PACKAGE_XENOMAI_ENABLE_SMP
> +	bool "Enable SMP"

 Since it was enabled before, I would add
	default y

> +	help
> +	  This option allows to enable SMP in Xenomai userspace.
> +
>  config BR2_PACKAGE_XENOMAI_TESTSUITE
>  	bool "Install testsuite"
>  	help
> diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
> index c9e810e05..7af4e0cf5 100644
> --- a/package/xenomai/xenomai.mk
> +++ b/package/xenomai/xenomai.mk
> @@ -23,6 +23,10 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-user
>  
>  XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/ --disable-doc-install
>  
> +ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
> +XENOMAI_CONF_OPTS += --enable-smp

 Can you add an explicit --disable-smp in the else branch? Or does that not work?

 Regards,
 Arnout

> +endif
> +
>  define XENOMAI_REMOVE_DEVFILES
>  	for i in xeno-config xeno-info wrap-link.sh ; do \
>  		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] xenomai: Add config for enabling SMP for 3.x

[Pawel Sikora]

Hi,

2017-04-07 13:22 GMT+02:00 Arnout Vandecappelle <arnout@mind.be>:

>
>
> On 07-04-17 01:46, Pawel Sikora wrote:
> > Add a config option for enabling SMP in Xenomai
> > userspace, only for versions >= 3.x
> >
> > In 2.x versions this option was enabled by
> > default, so for now behaviour for it will
> > not change, while as buildroot supports
> > now Xenomai 3.0.3 it's good to let users
> > have this option.
> >
> > Add a comment about this config's behaviour
> > above this option in the menuconfig.
> >
> > Signed-off-by: Pawel Sikora <sikor6@gmail.com>
> > ---
> >  package/xenomai/Config.in  | 12 ++++++++++++
> >  package/xenomai/xenomai.mk |  4 ++++
> >  2 files changed, 16 insertions(+)
> >
> > diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> > index b548ee810..cd323545c 100644
> > --- a/package/xenomai/Config.in
> > +++ b/package/xenomai/Config.in
> > @@ -51,6 +51,18 @@ config BR2_PACKAGE_XENOMAI_VERSION
> >         BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
> >         Kernel -> Linux Kernel Extensions menu.
> >
> > +comment "-------------------------------------------------------"
> > +comment "Please note:                                           "
> > +comment "Option for enabling SMP in Xenomai userspace is meant  "
> > +comment "only for Xenomai 3.x                                   "
> > +comment "If you use Xenomai 2.x you have SMP enabled by default."
>
>  Do we really still support Xenomai 2.x? Do our patches apply to it?
>
>  Anyway, instead of putting this in a comment, just put it in the help
> text.
>

I don't know, actually patches should be different for Xenomai 2.x, so from
my
POV and from testing they are not applying. Maybe split into to packages
for Xenomai 2.x and 3.x would be a good idea... already asked you/Thomas
about it in the thread with Xenomai Core.

I moved this comment for help and rewrote it a little bit.


> > +comment "-------------------------------------------------------"
> > +
> > +config BR2_PACKAGE_XENOMAI_ENABLE_SMP
> > +     bool "Enable SMP"
>
>  Since it was enabled before, I would add
>         default y
>

Ok, I agree. I also added comment about this in help, why it is default y.


>
> > +     help
> > +       This option allows to enable SMP in Xenomai userspace.
> > +
> >  config BR2_PACKAGE_XENOMAI_TESTSUITE
> >       bool "Install testsuite"
> >       help
> > diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
> > index c9e810e05..7af4e0cf5 100644
> > --- a/package/xenomai/xenomai.mk
> > +++ b/package/xenomai/xenomai.mk
> > @@ -23,6 +23,10 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR)
> install-user
> >
> >  XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/
> --disable-doc-install
> >
> > +ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
> > +XENOMAI_CONF_OPTS += --enable-smp
>
>  Can you add an explicit --disable-smp in the else branch? Or does that
> not work?
>

On Xenomai 3 default it is disabled, so it will not make any difference,
but for 2.x will.
So ok, as it is a valid option I added it also.


>  Regards,
>  Arnout
>
> > +endif
> > +
> >  define XENOMAI_REMOVE_DEVFILES
> >       for i in xeno-config xeno-info wrap-link.sh ; do \
> >               rm -f $(TARGET_DIR)/usr/bin/$$i ; \
> >
>
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
>

Changes in patch v2.

Thanks!

Regards,
Pawel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170410/db8588c0/attachment.html>

[Buildroot] [PATCH v2] xenomai: Add config for enabling/disabling SMP

[Pawel Sikora]

Add a config option for enabling/disabling SMP
in Xenomai userspace in version 3.x

Enabled by default.

Signed-off-by: Pawel Sikora <sikor6@gmail.com>
---
Changes v1 -> v2:
 - default y, moving comment to help, changed help, adding explicitly
   --disable-smp opt in the else statement (suggested by Arnout V.)
 
 package/xenomai/Config.in  | 24 ++++++++++++++++++++++++
 package/xenomai/xenomai.mk |  6 ++++++
 2 files changed, 30 insertions(+)

diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
index b548ee810..b2697e5af 100644
--- a/package/xenomai/Config.in
+++ b/package/xenomai/Config.in
@@ -51,6 +51,30 @@ config BR2_PACKAGE_XENOMAI_VERSION
 	  BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
 	  Kernel -> Linux Kernel Extensions menu.
 
+config BR2_PACKAGE_XENOMAI_ENABLE_SMP
+	bool "Enable SMP"
+	default y
+	help
+	  This option allows to enable SMP in Xenomai userspace.
+
+	  Please note:
+	  If you use Xenomai 2.x you have SMP enabled by default.
+
+	  Xenomai 3.x is being built by default with SMP disabled,
+	  but to have a behaviour similar to previous versions,
+	  option is enabled by default and you need to uncheck it
+	  if you don't need it.
+
+	  Second reason of setting it by default is that Xenomai
+	  userspace with SMP enabled and with Linux Kernel without
+	  SMP config are working fine together.
+	  But NOT the other way around.
+
+	  Please refer to this troubleshooting guide for more
+	  information in section "feature mismatch: missing=?smp/nosmp?:
+
+	  https://xenomai.org/troubleshooting-a-dual-kernel-configuration/
+
 config BR2_PACKAGE_XENOMAI_TESTSUITE
 	bool "Install testsuite"
 	help
diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
index c9e810e05..04880e69a 100644
--- a/package/xenomai/xenomai.mk
+++ b/package/xenomai/xenomai.mk
@@ -23,6 +23,12 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-user
 
 XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/ --disable-doc-install
 
+ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
+XENOMAI_CONF_OPTS += --enable-smp
+else
+XENOMAI_CONF_OPTS += --disable-smp
+endif
+
 define XENOMAI_REMOVE_DEVFILES
 	for i in xeno-config xeno-info wrap-link.sh ; do \
 		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
-- 
2.12.1

[Buildroot] [PATCH 1/1] xenomai: Add config for enabling SMP for 3.x

[Arnout Vandecappelle]

On 10-04-17 01:07, Pawel Sikora wrote:
> Hi,
> 
> 2017-04-07 13:22 GMT+02:00 Arnout Vandecappelle <arnout@mind.be
> <mailto:arnout@mind.be>>:
> 
> 
> 
>     On 07-04-17 01:46, Pawel Sikora wrote:
[snip]
>     > +ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
>     > +XENOMAI_CONF_OPTS += --enable-smp
> 
>      Can you add an explicit --disable-smp in the else branch? Or does that not
>     work?
> 
> 
> On Xenomai 3 default it is disabled, so it will not make any difference, but for
> 2.x will.

 We want explicit options even if they are the default, because:

- it is possible that the default changes after a version bump, and that's hard
to notice;

- someone looking at the .mk file doesn't know what the default is, so it's good
to make it explicit.

 Regards,
 Arnout


> So ok, as it is a valid option I added it also.
[snip]
-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH v2] xenomai: Add config for enabling/disabling SMP

[Arnout Vandecappelle]

On 10-04-17 02:17, Pawel Sikora wrote:
> Add a config option for enabling/disabling SMP
> in Xenomai userspace in version 3.x
> 
> Enabled by default.
> 
> Signed-off-by: Pawel Sikora <sikor6@gmail.com>
> ---
> Changes v1 -> v2:
>  - default y, moving comment to help, changed help, adding explicitly
>    --disable-smp opt in the else statement (suggested by Arnout V.)
>  
>  package/xenomai/Config.in  | 24 ++++++++++++++++++++++++
>  package/xenomai/xenomai.mk |  6 ++++++
>  2 files changed, 30 insertions(+)
> 
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index b548ee810..b2697e5af 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -51,6 +51,30 @@ config BR2_PACKAGE_XENOMAI_VERSION
>  	  BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
>  	  Kernel -> Linux Kernel Extensions menu.
>  
> +config BR2_PACKAGE_XENOMAI_ENABLE_SMP
> +	bool "Enable SMP"
> +	default y
> +	help
> +	  This option allows to enable SMP in Xenomai userspace.
> +
> +	  Please note:
> +	  If you use Xenomai 2.x you have SMP enabled by default.
> +
> +	  Xenomai 3.x is being built by default with SMP disabled,
> +	  but to have a behaviour similar to previous versions,
> +	  option is enabled by default and you need to uncheck it
> +	  if you don't need it.
> +
> +	  Second reason of setting it by default is that Xenomai
> +	  userspace with SMP enabled and with Linux Kernel without
> +	  SMP config are working fine together.
> +	  But NOT the other way around.
> +
> +	  Please refer to this troubleshooting guide for more
> +	  information in section "feature mismatch: missing=?smp/nosmp?:
> +
> +	  https://xenomai.org/troubleshooting-a-dual-kernel-configuration/

 The https address doesn't work for me, the http equivalent does...

 As said in my previous mail, I think we don't need to spend too much effort on
supporting Xenomai 2.x (which anyway doesn't work ATM). Also in general this
explanation is a bit too extensive. Here's a shorter alternative.

	  This option enables SMP support in Xenomai userspace.

	  If this option is turned on while no SMP support is enabled
	  in the kernel, things will still work. However, if SMP is
	  enabled in the kernel but this option is not turned on,
	  Xenomai applications will complain with 'feature mismatch:
	  missing="smp/nosmp'.

	  Please refer to this troubleshooting guide for more
	  information:
	
http://xenomai.org/troubleshooting-a-dual-kernel-configuration/#feature_mismatch_missing8221smpnosmp8221



 Regards,
 Arnout


> +
>  config BR2_PACKAGE_XENOMAI_TESTSUITE
>  	bool "Install testsuite"
>  	help
> diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
> index c9e810e05..04880e69a 100644
> --- a/package/xenomai/xenomai.mk
> +++ b/package/xenomai/xenomai.mk
> @@ -23,6 +23,12 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-user
>  
>  XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/ --disable-doc-install
>  
> +ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
> +XENOMAI_CONF_OPTS += --enable-smp
> +else
> +XENOMAI_CONF_OPTS += --disable-smp
> +endif
> +
>  define XENOMAI_REMOVE_DEVFILES
>  	for i in xeno-config xeno-info wrap-link.sh ; do \
>  		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH v3] xenomai: Add config for enabling/disabling SMP

[Pawel Sikora]

Add a config option for enabling/disabling SMP
in Xenomai userspace in version 3.x

Enabled by default.

Signed-off-by: Pawel Sikora <sikor6@gmail.com>
---
Changes v2 -> v3:
 - Corrections in help (Arnout V.)

 package/xenomai/Config.in  | 17 +++++++++++++++++
 package/xenomai/xenomai.mk |  6 ++++++
 2 files changed, 23 insertions(+)

diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
index b548ee810..8bf9c4ae1 100644
--- a/package/xenomai/Config.in
+++ b/package/xenomai/Config.in
@@ -51,6 +51,23 @@ config BR2_PACKAGE_XENOMAI_VERSION
 	  BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
 	  Kernel -> Linux Kernel Extensions menu.
 
+config BR2_PACKAGE_XENOMAI_ENABLE_SMP
+	bool "Enable SMP"
+	default y
+	help
+	  This option enables SMP support in Xenomai userspace.
+
+	  If this option is turned on while no SMP support is enabled
+	  in the kernel, things will still work. However, if SMP is
+	  enabled in the kernel but this option is not turned on,
+	  Xenomai applications will complain with 'feature mismatch:
+	  missing="smp/nosmp'.
+
+	  Please refer to this troubleshooting guide for more
+	  information:
+
+	  http://xenomai.org/troubleshooting-a-dual-kernel-configuration/#feature_mismatch_missing8221smpnosmp8221
+
 config BR2_PACKAGE_XENOMAI_TESTSUITE
 	bool "Install testsuite"
 	help
diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
index c9e810e05..04880e69a 100644
--- a/package/xenomai/xenomai.mk
+++ b/package/xenomai/xenomai.mk
@@ -23,6 +23,12 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-user
 
 XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/ --disable-doc-install
 
+ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
+XENOMAI_CONF_OPTS += --enable-smp
+else
+XENOMAI_CONF_OPTS += --disable-smp
+endif
+
 define XENOMAI_REMOVE_DEVFILES
 	for i in xeno-config xeno-info wrap-link.sh ; do \
 		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
-- 
2.12.1

[Buildroot] [PATCH v2] xenomai: Add config for enabling/disabling SMP

[Pawel Sikora]

Hi

2017-04-10 13:56 GMT+02:00 Arnout Vandecappelle <arnout@mind.be>:

>
>
> On 10-04-17 02:17, Pawel Sikora wrote:
> > Add a config option for enabling/disabling SMP
> > in Xenomai userspace in version 3.x
> >
> > Enabled by default.
> >
> > Signed-off-by: Pawel Sikora <sikor6@gmail.com>
> > ---
> > Changes v1 -> v2:
> >  - default y, moving comment to help, changed help, adding explicitly
> >    --disable-smp opt in the else statement (suggested by Arnout V.)
> >
> >  package/xenomai/Config.in  | 24 ++++++++++++++++++++++++
> >  package/xenomai/xenomai.mk |  6 ++++++
> >  2 files changed, 30 insertions(+)
> >
> > diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> > index b548ee810..b2697e5af 100644
> > --- a/package/xenomai/Config.in
> > +++ b/package/xenomai/Config.in
> > @@ -51,6 +51,30 @@ config BR2_PACKAGE_XENOMAI_VERSION
> >         BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
> >         Kernel -> Linux Kernel Extensions menu.
> >
> > +config BR2_PACKAGE_XENOMAI_ENABLE_SMP
> > +     bool "Enable SMP"
> > +     default y
> > +     help
> > +       This option allows to enable SMP in Xenomai userspace.
> > +
> > +       Please note:
> > +       If you use Xenomai 2.x you have SMP enabled by default.
> > +
> > +       Xenomai 3.x is being built by default with SMP disabled,
> > +       but to have a behaviour similar to previous versions,
> > +       option is enabled by default and you need to uncheck it
> > +       if you don't need it.
> > +
> > +       Second reason of setting it by default is that Xenomai
> > +       userspace with SMP enabled and with Linux Kernel without
> > +       SMP config are working fine together.
> > +       But NOT the other way around.
> > +
> > +       Please refer to this troubleshooting guide for more
> > +       information in section "feature mismatch: missing=?smp/nosmp?:
> > +
> > +       https://xenomai.org/troubleshooting-a-dual-kernel-configuration/
>
>  The https address doesn't work for me, the http equivalent does...
>
>  As said in my previous mail, I think we don't need to spend too much
> effort on
> supporting Xenomai 2.x (which anyway doesn't work ATM). Also in general
> this
> explanation is a bit too extensive. Here's a shorter alternative.
>
>           This option enables SMP support in Xenomai userspace.
>
>           If this option is turned on while no SMP support is enabled
>           in the kernel, things will still work. However, if SMP is
>           enabled in the kernel but this option is not turned on,
>           Xenomai applications will complain with 'feature mismatch:
>           missing="smp/nosmp'.
>
>           Please refer to this troubleshooting guide for more
>           information:
>
> http://xenomai.org/troubleshooting-a-dual-kernel-configuration/#feature_
> mismatch_missing8221smpnosmp8221
>
>
>
>  Regards,
>  Arnout
>
>
> > +
> >  config BR2_PACKAGE_XENOMAI_TESTSUITE
> >       bool "Install testsuite"
> >       help
> > diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
> > index c9e810e05..04880e69a 100644
> > --- a/package/xenomai/xenomai.mk
> > +++ b/package/xenomai/xenomai.mk
> > @@ -23,6 +23,12 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR)
> install-user
> >
> >  XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/
> --disable-doc-install
> >
> > +ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
> > +XENOMAI_CONF_OPTS += --enable-smp
> > +else
> > +XENOMAI_CONF_OPTS += --disable-smp
> > +endif
> > +
> >  define XENOMAI_REMOVE_DEVFILES
> >       for i in xeno-config xeno-info wrap-link.sh ; do \
> >               rm -f $(TARGET_DIR)/usr/bin/$$i ; \
> >
>
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
>

Ok - Changed in patch v3.

Regards,
Pawel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170410/2c17843b/attachment.html>

[Buildroot] [PATCH v3] xenomai: Add config for enabling/disabling SMP

[Arnout Vandecappelle]

On 10-04-17 14:44, Pawel Sikora wrote:
> Add a config option for enabling/disabling SMP
> in Xenomai userspace in version 3.x
> 
> Enabled by default.
> 
> Signed-off-by: Pawel Sikora <sikor6@gmail.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 One small detail: your two patches are conflicting with each other, which makes
life difficult for the maintainers. You should keep them together in a patch
series where they are kept in the correct order.


 Regards,
 Arnout

> ---
> Changes v2 -> v3:
>  - Corrections in help (Arnout V.)
> 
>  package/xenomai/Config.in  | 17 +++++++++++++++++
>  package/xenomai/xenomai.mk |  6 ++++++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index b548ee810..8bf9c4ae1 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -51,6 +51,23 @@ config BR2_PACKAGE_XENOMAI_VERSION
>  	  BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
>  	  Kernel -> Linux Kernel Extensions menu.
>  
> +config BR2_PACKAGE_XENOMAI_ENABLE_SMP
> +	bool "Enable SMP"
> +	default y
> +	help
> +	  This option enables SMP support in Xenomai userspace.
> +
> +	  If this option is turned on while no SMP support is enabled
> +	  in the kernel, things will still work. However, if SMP is
> +	  enabled in the kernel but this option is not turned on,
> +	  Xenomai applications will complain with 'feature mismatch:
> +	  missing="smp/nosmp'.
> +
> +	  Please refer to this troubleshooting guide for more
> +	  information:
> +
> +	  http://xenomai.org/troubleshooting-a-dual-kernel-configuration/#feature_mismatch_missing8221smpnosmp8221
> +
>  config BR2_PACKAGE_XENOMAI_TESTSUITE
>  	bool "Install testsuite"
>  	help
> diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
> index c9e810e05..04880e69a 100644
> --- a/package/xenomai/xenomai.mk
> +++ b/package/xenomai/xenomai.mk
> @@ -23,6 +23,12 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-user
>  
>  XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/ --disable-doc-install
>  
> +ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
> +XENOMAI_CONF_OPTS += --enable-smp
> +else
> +XENOMAI_CONF_OPTS += --disable-smp
> +endif
> +
>  define XENOMAI_REMOVE_DEVFILES
>  	for i in xeno-config xeno-info wrap-link.sh ; do \
>  		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF