* [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()
@ 2017-04-10 13:11 Wei Yongjun
2017-04-11 6:39 ` Jiri Pirko
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Wei Yongjun @ 2017-04-10 13:11 UTC (permalink / raw)
To: Jiri Pirko, Arkadi Sharshevsky, David S. Miller; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix the retrn value check which testing the wrong variable
in devlink_dpipe_header_put().
Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/core/devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 24b7660..0afac58 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2031,7 +2031,7 @@ static int devlink_dpipe_header_put(struct sk_buff *skb,
int err;
header_attr = nla_nest_start(skb, DEVLINK_ATTR_DPIPE_HEADER);
- if (!header)
+ if (!header_attr)
return -EMSGSIZE;
if (nla_put_string(skb, DEVLINK_ATTR_DPIPE_HEADER_NAME, header->name) ||
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()
2017-04-10 13:11 [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put() Wei Yongjun
@ 2017-04-11 6:39 ` Jiri Pirko
2017-04-11 16:02 ` [PATCH net-next v2] " Wei Yongjun
2017-04-12 3:03 ` [PATCH net-next] " David Miller
2 siblings, 0 replies; 7+ messages in thread
From: Jiri Pirko @ 2017-04-11 6:39 UTC (permalink / raw)
To: Wei Yongjun
Cc: Jiri Pirko, Arkadi Sharshevsky, David S. Miller, Wei Yongjun, netdev
Mon, Apr 10, 2017 at 03:11:06PM CEST, weiyj.lk@gmail.com wrote:
>From: Wei Yongjun <weiyongjun1@huawei.com>
>
>Fix the retrn value check which testing the wrong variable
^^^^^ typo
Otherwise,
Acked-by: Jiri Pirko <jiri@mellanox.com>
>in devlink_dpipe_header_put().
>
>Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>---
> net/core/devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/core/devlink.c b/net/core/devlink.c
>index 24b7660..0afac58 100644
>--- a/net/core/devlink.c
>+++ b/net/core/devlink.c
>@@ -2031,7 +2031,7 @@ static int devlink_dpipe_header_put(struct sk_buff *skb,
> int err;
>
> header_attr = nla_nest_start(skb, DEVLINK_ATTR_DPIPE_HEADER);
>- if (!header)
>+ if (!header_attr)
> return -EMSGSIZE;
>
> if (nla_put_string(skb, DEVLINK_ATTR_DPIPE_HEADER_NAME, header->name) ||
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH net-next v2] devlink: fix return value check in devlink_dpipe_header_put()
2017-04-10 13:11 [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put() Wei Yongjun
2017-04-11 6:39 ` Jiri Pirko
@ 2017-04-11 16:02 ` Wei Yongjun
2017-04-11 18:53 ` David Miller
2017-04-12 3:03 ` [PATCH net-next] " David Miller
2 siblings, 1 reply; 7+ messages in thread
From: Wei Yongjun @ 2017-04-11 16:02 UTC (permalink / raw)
To: Jiri Pirko, Arkadi Sharshevsky, David S. Miller; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix the return value check which testing the wrong variable
in devlink_dpipe_header_put().
Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
---
v1 -> v2: fix a typo in patch comment
---
net/core/devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 24b7660..0afac58 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2031,7 +2031,7 @@ static int devlink_dpipe_header_put(struct sk_buff *skb,
int err;
header_attr = nla_nest_start(skb, DEVLINK_ATTR_DPIPE_HEADER);
- if (!header)
+ if (!header_attr)
return -EMSGSIZE;
if (nla_put_string(skb, DEVLINK_ATTR_DPIPE_HEADER_NAME, header->name) ||
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH net-next v2] devlink: fix return value check in devlink_dpipe_header_put()
2017-04-11 16:02 ` [PATCH net-next v2] " Wei Yongjun
@ 2017-04-11 18:53 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2017-04-11 18:53 UTC (permalink / raw)
To: weiyj.lk; +Cc: jiri, arkadis, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Tue, 11 Apr 2017 16:02:02 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the return value check which testing the wrong variable
> in devlink_dpipe_header_put().
>
> Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> ---
> v1 -> v2: fix a typo in patch comment
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()
2017-04-10 13:11 [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put() Wei Yongjun
2017-04-11 6:39 ` Jiri Pirko
2017-04-11 16:02 ` [PATCH net-next v2] " Wei Yongjun
@ 2017-04-12 3:03 ` David Miller
2017-04-12 3:30 ` weiyongjun (A)
2 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2017-04-12 3:03 UTC (permalink / raw)
To: weiyj.lk; +Cc: jiri, arkadis, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Mon, 10 Apr 2017 13:11:06 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the retrn value check which testing the wrong variable
> in devlink_dpipe_header_put().
>
> Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
This doesn't apply cleanly to net-next, please respin and also fix
the typo in your commit message as pointed out by Jiri.
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()
2017-04-12 3:03 ` [PATCH net-next] " David Miller
@ 2017-04-12 3:30 ` weiyongjun (A)
2017-04-12 14:19 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: weiyongjun (A) @ 2017-04-12 3:30 UTC (permalink / raw)
To: David Miller; +Cc: jiri, arkadis, netdev
Hi David,
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, April 12, 2017 11:03 AM
> To: weiyj.lk@gmail.com
> Cc: jiri@mellanox.com; arkadis@mellanox.com; weiyongjun (A)
> <weiyongjun1@huawei.com>; netdev@vger.kernel.org
> Subject: Re: [PATCH net-next] devlink: fix return value check in
> devlink_dpipe_header_put()
>
> From: Wei Yongjun <weiyj.lk@gmail.com>
> Date: Mon, 10 Apr 2017 13:11:06 +0000
>
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> >
> > Fix the retrn value check which testing the wrong variable
> > in devlink_dpipe_header_put().
> >
> > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> This doesn't apply cleanly to net-next, please respin and also fix
> the typo in your commit message as pointed out by Jiri.
You have applied the v2 version of this patch some hours ago.
Regards,
Yongjun Wei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()
2017-04-12 3:30 ` weiyongjun (A)
@ 2017-04-12 14:19 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2017-04-12 14:19 UTC (permalink / raw)
To: weiyongjun1; +Cc: jiri, arkadis, netdev
From: "weiyongjun (A)" <weiyongjun1@huawei.com>
Date: Wed, 12 Apr 2017 03:30:25 +0000
> Hi David,
>
>> -----Original Message-----
>> From: David Miller [mailto:davem@davemloft.net]
>> Sent: Wednesday, April 12, 2017 11:03 AM
>> To: weiyj.lk@gmail.com
>> Cc: jiri@mellanox.com; arkadis@mellanox.com; weiyongjun (A)
>> <weiyongjun1@huawei.com>; netdev@vger.kernel.org
>> Subject: Re: [PATCH net-next] devlink: fix return value check in
>> devlink_dpipe_header_put()
>>
>> From: Wei Yongjun <weiyj.lk@gmail.com>
>> Date: Mon, 10 Apr 2017 13:11:06 +0000
>>
>> > From: Wei Yongjun <weiyongjun1@huawei.com>
>> >
>> > Fix the retrn value check which testing the wrong variable
>> > in devlink_dpipe_header_put().
>> >
>> > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
>> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> This doesn't apply cleanly to net-next, please respin and also fix
>> the typo in your commit message as pointed out by Jiri.
>
> You have applied the v2 version of this patch some hours ago.
Aha, my bad. Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-12 14:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10 13:11 [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put() Wei Yongjun
2017-04-11 6:39 ` Jiri Pirko
2017-04-11 16:02 ` [PATCH net-next v2] " Wei Yongjun
2017-04-11 18:53 ` David Miller
2017-04-12 3:03 ` [PATCH net-next] " David Miller
2017-04-12 3:30 ` weiyongjun (A)
2017-04-12 14:19 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.