From: Lee Jones <lee.jones@linaro.org> To: Javier Martinez Canillas <javier@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Tony Lindgren <tony@atomide.com> Subject: Re: [PATCH v4 7/8] mfd: tps6105x: Add OF device ID table Date: Tue, 11 Apr 2017 14:57:01 +0100 [thread overview] Message-ID: <20170411135701.2x7umkdt6azprpia@dell> (raw) In-Reply-To: <20170404153036.6651-8-javier@osg.samsung.com> On Tue, 04 Apr 2017, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:<device>. > > But this could change in the future so the correct approach is to have a > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > Changes in v4: None > Changes in v3: > - Add a vendor prefix to the compatible string (Rob Herring). > > Changes in v2: > - Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled. > > drivers/mfd/tps6105x.c | 8 ++++++++ > 1 file changed, 8 insertions(+) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > diff --git a/drivers/mfd/tps6105x.c b/drivers/mfd/tps6105x.c > index baa12ea666fb..187848c93779 100644 > --- a/drivers/mfd/tps6105x.c > +++ b/drivers/mfd/tps6105x.c > @@ -173,9 +173,17 @@ static const struct i2c_device_id tps6105x_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, tps6105x_id); > > +static const struct of_device_id tps6105x_of_match[] = { > + { .compatible = "ti,tps61050" }, > + { .compatible = "ti,tps61052" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, tps6105x_of_match); > + > static struct i2c_driver tps6105x_driver = { > .driver = { > .name = "tps6105x", > + .of_match_table = tps6105x_of_match, > }, > .probe = tps6105x_probe, > .remove = tps6105x_remove, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Subject: Re: [PATCH v4 7/8] mfd: tps6105x: Add OF device ID table Date: Tue, 11 Apr 2017 14:57:01 +0100 [thread overview] Message-ID: <20170411135701.2x7umkdt6azprpia@dell> (raw) In-Reply-To: <20170404153036.6651-8-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> On Tue, 04 Apr 2017, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:<device>. > > But this could change in the future so the correct approach is to have a > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> > > --- > > Changes in v4: None > Changes in v3: > - Add a vendor prefix to the compatible string (Rob Herring). > > Changes in v2: > - Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled. > > drivers/mfd/tps6105x.c | 8 ++++++++ > 1 file changed, 8 insertions(+) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > diff --git a/drivers/mfd/tps6105x.c b/drivers/mfd/tps6105x.c > index baa12ea666fb..187848c93779 100644 > --- a/drivers/mfd/tps6105x.c > +++ b/drivers/mfd/tps6105x.c > @@ -173,9 +173,17 @@ static const struct i2c_device_id tps6105x_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, tps6105x_id); > > +static const struct of_device_id tps6105x_of_match[] = { > + { .compatible = "ti,tps61050" }, > + { .compatible = "ti,tps61052" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, tps6105x_of_match); > + > static struct i2c_driver tps6105x_driver = { > .driver = { > .name = "tps6105x", > + .of_match_table = tps6105x_of_match, > }, > .probe = tps6105x_probe, > .remove = tps6105x_remove, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-11 13:57 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-04 15:30 [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Javier Martinez Canillas 2017-04-04 16:54 ` Rob Herring 2017-04-04 17:01 ` Javier Martinez Canillas 2017-04-04 17:01 ` Javier Martinez Canillas 2017-04-11 13:57 ` Lee Jones 2017-04-04 15:30 ` [PATCH v4 2/8] mfd: retu: Drop -mfd suffix from I2C device ID name Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-11 13:56 ` Lee Jones 2017-04-11 13:56 ` Lee Jones 2017-04-04 15:30 ` [PATCH v4 3/8] mfd: retu: Add OF device ID table Javier Martinez Canillas 2017-04-11 13:56 ` Lee Jones 2017-04-11 13:56 ` Lee Jones 2017-04-04 15:30 ` [PATCH v4 4/8] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` [PATCH v4 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas 2017-04-04 15:30 ` [PATCH v4 6/8] dt-bindings: mfd: Add TI tps6105x chip bindings Javier Martinez Canillas 2017-04-04 15:30 ` [PATCH v4 7/8] mfd: tps6105x: Add OF device ID table Javier Martinez Canillas 2017-04-11 13:57 ` Lee Jones [this message] 2017-04-11 13:57 ` Lee Jones 2017-04-04 15:30 ` [PATCH v4 8/8] ARM: ux500: Add vendor prefix to tps61052 node Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 15:30 ` Javier Martinez Canillas 2017-04-04 16:54 ` [PATCH v4 0/8] mfd: Add OF device table to I2C drivers that are missing it Rob Herring 2017-04-04 16:54 ` Rob Herring 2017-04-04 17:38 ` Aaro Koskinen 2017-04-04 17:38 ` Aaro Koskinen 2017-04-04 17:43 ` Tony Lindgren 2017-04-04 17:43 ` Tony Lindgren 2017-04-04 17:43 ` Tony Lindgren 2017-04-04 17:46 ` Javier Martinez Canillas 2017-04-04 17:46 ` Javier Martinez Canillas 2017-04-04 17:46 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170411135701.2x7umkdt6azprpia@dell \ --to=lee.jones@linaro.org \ --cc=aaro.koskinen@iki.fi \ --cc=devicetree@vger.kernel.org \ --cc=javier@osg.samsung.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.