* [PATCH] power: supply: lp8788: prevent out of bounds array access
@ 2017-03-25 16:00 Giedrius Statkevičius
2017-03-27 23:23 ` Kim, Milo
2017-04-11 14:18 ` Sebastian Reichel
0 siblings, 2 replies; 5+ messages in thread
From: Giedrius Statkevičius @ 2017-03-25 16:00 UTC (permalink / raw)
To: milo.kim, sre; +Cc: linux-pm, linux-kernel, Giedrius Statkevičius
val might become 7 in which case stime[7] (array of length 7) would be
accessed during the scnprintf call later and that will cause issues.
Obviously, string concatenation is not intended here so just a comma needs
to be added to fix the issue.
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
---
drivers/power/supply/lp8788-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c
index 509e2b341bd6..677f7c40b25a 100644
--- a/drivers/power/supply/lp8788-charger.c
+++ b/drivers/power/supply/lp8788-charger.c
@@ -651,7 +651,7 @@ static ssize_t lp8788_show_eoc_time(struct device *dev,
{
struct lp8788_charger *pchg = dev_get_drvdata(dev);
char *stime[] = { "400ms", "5min", "10min", "15min",
- "20min", "25min", "30min" "No timeout" };
+ "20min", "25min", "30min", "No timeout" };
u8 val;
lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
--
2.12.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: lp8788: prevent out of bounds array access
2017-03-25 16:00 [PATCH] power: supply: lp8788: prevent out of bounds array access Giedrius Statkevičius
@ 2017-03-27 23:23 ` Kim, Milo
2017-04-11 14:18 ` Sebastian Reichel
1 sibling, 0 replies; 5+ messages in thread
From: Kim, Milo @ 2017-03-27 23:23 UTC (permalink / raw)
To: Giedrius Statkevičius; +Cc: sre, linux-pm, linux-kernel
On 3/26/2017 1:00 AM, Giedrius Statkevičius wrote:
> val might become 7 in which case stime[7] (array of length 7) would be
> accessed during the scnprintf call later and that will cause issues.
> Obviously, string concatenation is not intended here so just a comma needs
> to be added to fix the issue.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Acked-by: Milo Kim <milo.kim@ti.com>
> ---
> drivers/power/supply/lp8788-charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c
> index 509e2b341bd6..677f7c40b25a 100644
> --- a/drivers/power/supply/lp8788-charger.c
> +++ b/drivers/power/supply/lp8788-charger.c
> @@ -651,7 +651,7 @@ static ssize_t lp8788_show_eoc_time(struct device *dev,
> {
> struct lp8788_charger *pchg = dev_get_drvdata(dev);
> char *stime[] = { "400ms", "5min", "10min", "15min",
> - "20min", "25min", "30min" "No timeout" };
> + "20min", "25min", "30min", "No timeout" };
> u8 val;
>
> lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: lp8788: prevent out of bounds array access
@ 2017-03-27 23:23 ` Kim, Milo
0 siblings, 0 replies; 5+ messages in thread
From: Kim, Milo @ 2017-03-27 23:23 UTC (permalink / raw)
To: Giedrius Statkevičius; +Cc: sre, linux-pm, linux-kernel
On 3/26/2017 1:00 AM, Giedrius Statkevičius wrote:
> val might become 7 in which case stime[7] (array of length 7) would be
> accessed during the scnprintf call later and that will cause issues.
> Obviously, string concatenation is not intended here so just a comma needs
> to be added to fix the issue.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Acked-by: Milo Kim <milo.kim@ti.com>
> ---
> drivers/power/supply/lp8788-charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c
> index 509e2b341bd6..677f7c40b25a 100644
> --- a/drivers/power/supply/lp8788-charger.c
> +++ b/drivers/power/supply/lp8788-charger.c
> @@ -651,7 +651,7 @@ static ssize_t lp8788_show_eoc_time(struct device *dev,
> {
> struct lp8788_charger *pchg = dev_get_drvdata(dev);
> char *stime[] = { "400ms", "5min", "10min", "15min",
> - "20min", "25min", "30min" "No timeout" };
> + "20min", "25min", "30min", "No timeout" };
> u8 val;
>
> lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] power: supply: lp8788: prevent out of bounds array access
2017-03-27 23:23 ` Kim, Milo
(?)
@ 2017-04-08 10:55 ` Giedrius Statkevičius
-1 siblings, 0 replies; 5+ messages in thread
From: Giedrius Statkevičius @ 2017-04-08 10:55 UTC (permalink / raw)
To: Kim, Milo; +Cc: sre, linux-pm, linux-kernel
Ping.
On Tue, Mar 28, 2017 at 2:23 AM, Kim, Milo <milo.kim@ti.com> wrote:
> On 3/26/2017 1:00 AM, Giedrius Statkevičius wrote:
>>
>> val might become 7 in which case stime[7] (array of length 7) would be
>> accessed during the scnprintf call later and that will cause issues.
>> Obviously, string concatenation is not intended here so just a comma needs
>> to be added to fix the issue.
>>
>> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
>
>
> Acked-by: Milo Kim <milo.kim@ti.com>
>
>
>> ---
>> drivers/power/supply/lp8788-charger.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/supply/lp8788-charger.c
>> b/drivers/power/supply/lp8788-charger.c
>> index 509e2b341bd6..677f7c40b25a 100644
>> --- a/drivers/power/supply/lp8788-charger.c
>> +++ b/drivers/power/supply/lp8788-charger.c
>> @@ -651,7 +651,7 @@ static ssize_t lp8788_show_eoc_time(struct device
>> *dev,
>> {
>> struct lp8788_charger *pchg = dev_get_drvdata(dev);
>> char *stime[] = { "400ms", "5min", "10min", "15min",
>> - "20min", "25min", "30min" "No timeout" };
>> + "20min", "25min", "30min", "No timeout" };
>> u8 val;
>>
>> lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] power: supply: lp8788: prevent out of bounds array access
2017-03-25 16:00 [PATCH] power: supply: lp8788: prevent out of bounds array access Giedrius Statkevičius
2017-03-27 23:23 ` Kim, Milo
@ 2017-04-11 14:18 ` Sebastian Reichel
1 sibling, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2017-04-11 14:18 UTC (permalink / raw)
To: Giedrius Statkevičius; +Cc: milo.kim, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]
Hi,
On Sat, Mar 25, 2017 at 06:00:49PM +0200, Giedrius Statkevičius wrote:
> val might become 7 in which case stime[7] (array of length 7) would be
> accessed during the scnprintf call later and that will cause issues.
> Obviously, string concatenation is not intended here so just a comma needs
> to be added to fix the issue.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> ---
> drivers/power/supply/lp8788-charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c
> index 509e2b341bd6..677f7c40b25a 100644
> --- a/drivers/power/supply/lp8788-charger.c
> +++ b/drivers/power/supply/lp8788-charger.c
> @@ -651,7 +651,7 @@ static ssize_t lp8788_show_eoc_time(struct device *dev,
> {
> struct lp8788_charger *pchg = dev_get_drvdata(dev);
> char *stime[] = { "400ms", "5min", "10min", "15min",
> - "20min", "25min", "30min" "No timeout" };
> + "20min", "25min", "30min", "No timeout" };
> u8 val;
>
> lp8788_read_byte(pchg->lp, LP8788_CHG_EOC, &val);
Thanks, queued with Fixes Tag.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-11 14:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-25 16:00 [PATCH] power: supply: lp8788: prevent out of bounds array access Giedrius Statkevičius
2017-03-27 23:23 ` Kim, Milo
2017-03-27 23:23 ` Kim, Milo
2017-04-08 10:55 ` Giedrius Statkevičius
2017-04-11 14:18 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.