* [PATCH] net: xdp: don't export dev_change_xdp_fd()
@ 2017-04-12 7:32 Johannes Berg
2017-04-12 9:21 ` Daniel Borkmann
2017-04-12 14:43 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Johannes Berg @ 2017-04-12 7:32 UTC (permalink / raw)
To: netdev; +Cc: Brenden Blanco, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
Since dev_change_xdp_fd() is only used in rtnetlink, which must
be built-in, there's no reason to export dev_change_xdp_fd().
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/core/dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index ef9fe60ee294..5d33e2baab2b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6754,7 +6754,6 @@ int dev_change_xdp_fd(struct net_device *dev, int fd, u32 flags)
return err;
}
-EXPORT_SYMBOL(dev_change_xdp_fd);
/**
* dev_new_index - allocate an ifindex
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: xdp: don't export dev_change_xdp_fd()
2017-04-12 7:32 [PATCH] net: xdp: don't export dev_change_xdp_fd() Johannes Berg
@ 2017-04-12 9:21 ` Daniel Borkmann
2017-04-12 14:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2017-04-12 9:21 UTC (permalink / raw)
To: Johannes Berg, netdev; +Cc: Brenden Blanco, Johannes Berg
On 04/12/2017 09:32 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Since dev_change_xdp_fd() is only used in rtnetlink, which must
> be built-in, there's no reason to export dev_change_xdp_fd().
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: xdp: don't export dev_change_xdp_fd()
2017-04-12 7:32 [PATCH] net: xdp: don't export dev_change_xdp_fd() Johannes Berg
2017-04-12 9:21 ` Daniel Borkmann
@ 2017-04-12 14:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-04-12 14:43 UTC (permalink / raw)
To: johannes; +Cc: netdev, bblanco, johannes.berg
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 12 Apr 2017 09:32:07 +0200
> From: Johannes Berg <johannes.berg@intel.com>
>
> Since dev_change_xdp_fd() is only used in rtnetlink, which must
> be built-in, there's no reason to export dev_change_xdp_fd().
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Applied, thanks Johannes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-12 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12 7:32 [PATCH] net: xdp: don't export dev_change_xdp_fd() Johannes Berg
2017-04-12 9:21 ` Daniel Borkmann
2017-04-12 14:43 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.