[PATCH] net: xdp: don't export dev_change_xdp_fd()

[PATCH] net: xdp: don't export dev_change_xdp_fd()

[Johannes Berg]

From: Johannes Berg <johannes.berg@intel.com>

Since dev_change_xdp_fd() is only used in rtnetlink, which must
be built-in, there's no reason to export dev_change_xdp_fd().

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 net/core/dev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index ef9fe60ee294..5d33e2baab2b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6754,7 +6754,6 @@ int dev_change_xdp_fd(struct net_device *dev, int fd, u32 flags)
 
 	return err;
 }
-EXPORT_SYMBOL(dev_change_xdp_fd);
 
 /**
  *	dev_new_index	-	allocate an ifindex
-- 
2.11.0

Re: [PATCH] net: xdp: don't export dev_change_xdp_fd()

[Daniel Borkmann]

On 04/12/2017 09:32 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Since dev_change_xdp_fd() is only used in rtnetlink, which must
> be built-in, there's no reason to export dev_change_xdp_fd().
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Re: [PATCH] net: xdp: don't export dev_change_xdp_fd()

[David Miller]

From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 12 Apr 2017 09:32:07 +0200

> From: Johannes Berg <johannes.berg@intel.com>
> 
> Since dev_change_xdp_fd() is only used in rtnetlink, which must
> be built-in, there's no reason to export dev_change_xdp_fd().
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Applied, thanks Johannes.