From: Mark Brown <broonie@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Dong Aisheng <dongas86@gmail.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, yibin.gong@nxp.com, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie
Date: Wed, 12 Apr 2017 17:16:32 +0100 [thread overview]
Message-ID: <20170412161631.d45jtyqgcky2cqxm@sirena.org.uk> (raw)
In-Reply-To: <1492013514.15082.35.camel@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On Wed, Apr 12, 2017 at 06:11:54PM +0200, Lucas Stach wrote:
> Am Donnerstag, den 13.04.2017, 15:41 +0800 schrieb Dong Aisheng:
> > The default voltage 1.100v this patch sets is defined in reference
> > manual.
> Huh? Shouldn't regulator_enable bring the voltage in a range defined by
> the constraints in the DT?
As part of that process it checks what the current voltage is but with
this regulator you can't read the voltage if the regulator is powered
off and we don't just ignore that error.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie
Date: Wed, 12 Apr 2017 17:16:32 +0100 [thread overview]
Message-ID: <20170412161631.d45jtyqgcky2cqxm@sirena.org.uk> (raw)
In-Reply-To: <1492013514.15082.35.camel@pengutronix.de>
On Wed, Apr 12, 2017 at 06:11:54PM +0200, Lucas Stach wrote:
> Am Donnerstag, den 13.04.2017, 15:41 +0800 schrieb Dong Aisheng:
> > The default voltage 1.100v this patch sets is defined in reference
> > manual.
> Huh? Shouldn't regulator_enable bring the voltage in a range defined by
> the constraints in the DT?
As part of that process it checks what the current voltage is but with
this regulator you can't read the voltage if the regulator is powered
off and we don't just ignore that error.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170412/ec7a844c/attachment.sig>
next prev parent reply other threads:[~2017-04-12 16:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 1:58 [PATCH 1/6] regulator: anatop: check return value of of_get_regulator_init_data Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: check return value of of_get_regulator_init_data" to the regulator tree Mark Brown
2017-04-11 20:42 ` Mark Brown
2017-04-12 1:58 ` [PATCH 2/6] regulator: anatop: only set supply regulator when it actually exists Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:31 ` Mark Brown
2017-04-11 20:31 ` Mark Brown
2017-04-13 7:11 ` Dong Aisheng
2017-04-13 7:11 ` Dong Aisheng
2017-04-12 15:53 ` Mark Brown
2017-04-12 15:53 ` Mark Brown
2017-04-12 16:00 ` Dong Aisheng
2017-04-12 16:00 ` Dong Aisheng
2017-04-12 16:06 ` Mark Brown
2017-04-12 16:06 ` Mark Brown
2017-04-12 1:58 ` [PATCH 3/6] regulator: anatop: use of_property_read_string to read the name Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: use of_property_read_string to read the name" to the regulator tree Mark Brown
2017-04-11 20:42 ` Mark Brown
2017-04-12 1:58 ` [PATCH 4/6] regulator: anatop: remove unneeded name field of struct anatop_regulator Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: remove unneeded name field of struct anatop_regulator" to the regulator tree Mark Brown
2017-04-11 20:42 ` Mark Brown
2017-04-12 1:58 ` [PATCH 5/6] regulator: anatop-regulator: make regulator-name using optionally Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:38 ` Mark Brown
2017-04-11 20:38 ` Mark Brown
2017-04-13 7:31 ` Dong Aisheng
2017-04-13 7:31 ` Dong Aisheng
2017-04-12 1:58 ` [PATCH 6/6] regulator: anatop: set default voltage selector for pcie Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:40 ` Mark Brown
2017-04-11 20:40 ` Mark Brown
2017-04-13 7:41 ` Dong Aisheng
2017-04-13 7:41 ` Dong Aisheng
2017-04-12 15:49 ` Mark Brown
2017-04-12 15:49 ` Mark Brown
2017-04-12 16:11 ` Dong Aisheng
2017-04-12 16:11 ` Dong Aisheng
2017-04-12 16:11 ` Lucas Stach
2017-04-12 16:11 ` Lucas Stach
2017-04-12 16:16 ` Mark Brown [this message]
2017-04-12 16:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412161631.d45jtyqgcky2cqxm@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=dongas86@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.