From: Dong Aisheng <dongas86@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
yibin.gong@nxp.com, Richard Zhu <hongxing.zhu@nxp.com>
Subject: Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie
Date: Thu, 13 Apr 2017 00:11:35 +0800 [thread overview]
Message-ID: <CAA+hA=TiXE+dTYbHrU8rH_xAqEBa=S9--tEwnHdBBj4Ssos_Sw@mail.gmail.com> (raw)
In-Reply-To: <20170412154909.hhv3kexadbqsekkr@sirena.org.uk>
On Wed, Apr 12, 2017 at 11:49 PM, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Apr 13, 2017 at 03:41:03PM +0800, Dong Aisheng wrote:
>> On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote:
>
>> > Why is this the only anatop regulator which can have this problem and
>> > how do we know this is a good value?
>
>> Anatop regulator has no separate gate bit.
>> e.g.
>> 00000 Power gated off
>> 00001 Target core voltage = 0.725V
>> ...
>> So it may have no valid default voltage in case it's disabled in
>> bootloader.
>> e.g. regulator_enable() may not work.
>
> That doesn't answer my question. What I'm asking is why another anatop
> regulator might not end up disabled like this one.
>
Well, that's true and i once thought of it.
Currently it is probably a quick fix and we did not see any others up till now
for all MX6&7 platforms based on NXP internal tree.
If we do see it in the future, then probably a better solution is constructing
a staticly defined default voltage table in anatop driver and do dynamically
check.
>> The default voltage 1.100v this patch sets is defined in reference
>> manual.
>
> For the SoC you're currently looking at... might another have a
> different value?
No, only MX6SX has it currently.
Regards
Dong Aisheng
WARNING: multiple messages have this Message-ID (diff)
From: dongas86@gmail.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie
Date: Thu, 13 Apr 2017 00:11:35 +0800 [thread overview]
Message-ID: <CAA+hA=TiXE+dTYbHrU8rH_xAqEBa=S9--tEwnHdBBj4Ssos_Sw@mail.gmail.com> (raw)
In-Reply-To: <20170412154909.hhv3kexadbqsekkr@sirena.org.uk>
On Wed, Apr 12, 2017 at 11:49 PM, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Apr 13, 2017 at 03:41:03PM +0800, Dong Aisheng wrote:
>> On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote:
>
>> > Why is this the only anatop regulator which can have this problem and
>> > how do we know this is a good value?
>
>> Anatop regulator has no separate gate bit.
>> e.g.
>> 00000 Power gated off
>> 00001 Target core voltage = 0.725V
>> ...
>> So it may have no valid default voltage in case it's disabled in
>> bootloader.
>> e.g. regulator_enable() may not work.
>
> That doesn't answer my question. What I'm asking is why another anatop
> regulator might not end up disabled like this one.
>
Well, that's true and i once thought of it.
Currently it is probably a quick fix and we did not see any others up till now
for all MX6&7 platforms based on NXP internal tree.
If we do see it in the future, then probably a better solution is constructing
a staticly defined default voltage table in anatop driver and do dynamically
check.
>> The default voltage 1.100v this patch sets is defined in reference
>> manual.
>
> For the SoC you're currently looking at... might another have a
> different value?
No, only MX6SX has it currently.
Regards
Dong Aisheng
next prev parent reply other threads:[~2017-04-12 16:11 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 1:58 [PATCH 1/6] regulator: anatop: check return value of of_get_regulator_init_data Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: check return value of of_get_regulator_init_data" to the regulator tree Mark Brown
2017-04-11 20:42 ` Mark Brown
2017-04-12 1:58 ` [PATCH 2/6] regulator: anatop: only set supply regulator when it actually exists Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:31 ` Mark Brown
2017-04-11 20:31 ` Mark Brown
2017-04-13 7:11 ` Dong Aisheng
2017-04-13 7:11 ` Dong Aisheng
2017-04-12 15:53 ` Mark Brown
2017-04-12 15:53 ` Mark Brown
2017-04-12 16:00 ` Dong Aisheng
2017-04-12 16:00 ` Dong Aisheng
2017-04-12 16:06 ` Mark Brown
2017-04-12 16:06 ` Mark Brown
2017-04-12 1:58 ` [PATCH 3/6] regulator: anatop: use of_property_read_string to read the name Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: use of_property_read_string to read the name" to the regulator tree Mark Brown
2017-04-11 20:42 ` Mark Brown
2017-04-12 1:58 ` [PATCH 4/6] regulator: anatop: remove unneeded name field of struct anatop_regulator Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: remove unneeded name field of struct anatop_regulator" to the regulator tree Mark Brown
2017-04-11 20:42 ` Mark Brown
2017-04-12 1:58 ` [PATCH 5/6] regulator: anatop-regulator: make regulator-name using optionally Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:38 ` Mark Brown
2017-04-11 20:38 ` Mark Brown
2017-04-13 7:31 ` Dong Aisheng
2017-04-13 7:31 ` Dong Aisheng
2017-04-12 1:58 ` [PATCH 6/6] regulator: anatop: set default voltage selector for pcie Dong Aisheng
2017-04-12 1:58 ` Dong Aisheng
2017-04-11 20:40 ` Mark Brown
2017-04-11 20:40 ` Mark Brown
2017-04-13 7:41 ` Dong Aisheng
2017-04-13 7:41 ` Dong Aisheng
2017-04-12 15:49 ` Mark Brown
2017-04-12 15:49 ` Mark Brown
2017-04-12 16:11 ` Dong Aisheng [this message]
2017-04-12 16:11 ` Dong Aisheng
2017-04-12 16:11 ` Lucas Stach
2017-04-12 16:11 ` Lucas Stach
2017-04-12 16:16 ` Mark Brown
2017-04-12 16:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA+hA=TiXE+dTYbHrU8rH_xAqEBa=S9--tEwnHdBBj4Ssos_Sw@mail.gmail.com' \
--to=dongas86@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=broonie@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.