From: Thierry Reding <thierry.reding@gmail.com> To: Ralph Sennhauser <ralph.sennhauser@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@free-electrons.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Russell King <linux@armlinux.org.uk>, linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 0/4] gpio: mvebu: Add PWM fan support Date: Wed, 12 Apr 2017 19:16:56 +0200 [thread overview] Message-ID: <20170412171656.GC11964@ulmo.ba.sec> (raw) In-Reply-To: <20170409180931.4884-1-ralph.sennhauser@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2217 bytes --] On Sun, Apr 09, 2017 at 08:09:26PM +0200, Ralph Sennhauser wrote: > Hi Therry, > > Resending this as v5 with some minor changes since v4. What is missing is > an ACK from you so Linus can merge the driver and Gregory the dts > changes. For this driver to make it into 4.12 it would be nice to have > it in next soon. I hope you can make some room in your schedule to have > another look at this series. > > Thanks > Ralph > > --- > > Notes: > > About npwm = 1: > The only way I can think of to achieve that requires reading the > GPIO line from the device tree. This would prevent a user to > dynamically choose a line. Which is fine for the fan found on Mamba > but let's take some development board with freely accessible GPIOs > and suddenly we limit the use of this driver. Given the above, npwm > = ngpio with only one usable at a time is a more accurate I think "accurate" is perhaps not the word I'd choose. "npwm" is defined as "number of PWMs controlled by this chip", and that's effectively just the one. It's implied that all PWMs exposed by a chip can be used concurrently. Anyway, I can see how npwm = ngpio might be more convenient, and if that is what you want to do, I don't feel strongly enough to object. > description of the situation. The only downside is some "wasted" > space. > > About the new compatible string: > Orion was chosen for the SoC variant for the same reason as in > commit 5f79c651e81e ("arm: mvebu: use global interrupts for GPIOs on > Armada XP"). > The "pwm" property remains optional for the new compatible string so > the compatiple string "marvell,armada-370-xp-gpio" can be used by > all and not just the first two GPIO chips. A property to select "Set > A" / "Set B" registers could be invented though. > > --- > > Pending: > * Needs ACK from Thierry Reding to be merged via linux-gpio tree by Linus > Walleij. (fine with the general approach, requested changes which > should have been taken care of now) As I said elsewhere, I haven't seen an Acked-by on the binding changes, so that would be another pending item here. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 0/4] gpio: mvebu: Add PWM fan support Date: Wed, 12 Apr 2017 19:16:56 +0200 [thread overview] Message-ID: <20170412171656.GC11964@ulmo.ba.sec> (raw) In-Reply-To: <20170409180931.4884-1-ralph.sennhauser@gmail.com> On Sun, Apr 09, 2017 at 08:09:26PM +0200, Ralph Sennhauser wrote: > Hi Therry, > > Resending this as v5 with some minor changes since v4. What is missing is > an ACK from you so Linus can merge the driver and Gregory the dts > changes. For this driver to make it into 4.12 it would be nice to have > it in next soon. I hope you can make some room in your schedule to have > another look at this series. > > Thanks > Ralph > > --- > > Notes: > > About npwm = 1: > The only way I can think of to achieve that requires reading the > GPIO line from the device tree. This would prevent a user to > dynamically choose a line. Which is fine for the fan found on Mamba > but let's take some development board with freely accessible GPIOs > and suddenly we limit the use of this driver. Given the above, npwm > = ngpio with only one usable at a time is a more accurate I think "accurate" is perhaps not the word I'd choose. "npwm" is defined as "number of PWMs controlled by this chip", and that's effectively just the one. It's implied that all PWMs exposed by a chip can be used concurrently. Anyway, I can see how npwm = ngpio might be more convenient, and if that is what you want to do, I don't feel strongly enough to object. > description of the situation. The only downside is some "wasted" > space. > > About the new compatible string: > Orion was chosen for the SoC variant for the same reason as in > commit 5f79c651e81e ("arm: mvebu: use global interrupts for GPIOs on > Armada XP"). > The "pwm" property remains optional for the new compatible string so > the compatiple string "marvell,armada-370-xp-gpio" can be used by > all and not just the first two GPIO chips. A property to select "Set > A" / "Set B" registers could be invented though. > > --- > > Pending: > * Needs ACK from Thierry Reding to be merged via linux-gpio tree by Linus > Walleij. (fine with the general approach, requested changes which > should have been taken care of now) As I said elsewhere, I haven't seen an Acked-by on the binding changes, so that would be another pending item here. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170412/e719481c/attachment.sig>
next prev parent reply other threads:[~2017-04-12 17:16 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-09 18:09 [PATCH v5 0/4] gpio: mvebu: Add PWM fan support Ralph Sennhauser 2017-04-09 18:09 ` Ralph Sennhauser [not found] ` <20170409180931.4884-1-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-09 18:09 ` [PATCH v5 1/4] gpio: mvebu: Add limited PWM support Ralph Sennhauser 2017-04-09 18:09 ` Ralph Sennhauser 2017-04-09 18:09 ` Ralph Sennhauser 2017-04-12 14:31 ` Thomas Petazzoni 2017-04-12 14:31 ` Thomas Petazzoni 2017-04-12 15:19 ` Andrew Lunn 2017-04-12 15:19 ` Andrew Lunn 2017-04-21 9:19 ` Thomas Petazzoni 2017-04-21 9:19 ` Thomas Petazzoni 2017-04-21 9:19 ` Thomas Petazzoni 2017-04-24 9:15 ` Linus Walleij 2017-04-24 9:15 ` Linus Walleij 2017-04-24 9:15 ` Linus Walleij 2017-04-12 17:11 ` Thierry Reding 2017-04-12 17:11 ` Thierry Reding 2017-04-13 7:45 ` Ralph Sennhauser 2017-04-13 7:45 ` Ralph Sennhauser 2017-04-12 17:21 ` Thierry Reding 2017-04-12 17:21 ` Thierry Reding [not found] ` <20170409180931.4884-2-ralph.sennhauser-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-04-13 20:14 ` Rob Herring 2017-04-13 20:14 ` Rob Herring 2017-04-13 20:14 ` Rob Herring 2017-04-09 18:09 ` [PATCH v5 2/4] ARM: dts: mvebu: Add PWM properties to .dtsi files Ralph Sennhauser 2017-04-09 18:09 ` Ralph Sennhauser 2017-04-09 18:09 ` Ralph Sennhauser 2017-04-09 18:09 ` [PATCH v5 3/4] ARM: mvebu: Enable SENSORS_PWM_FAN in defconfig Ralph Sennhauser 2017-04-09 18:09 ` Ralph Sennhauser 2017-04-09 18:09 ` [PATCH v5 4/4] ARM: dts: armada-xp: Use pwm-fan rather than gpio-fan Ralph Sennhauser 2017-04-09 18:09 ` Ralph Sennhauser 2017-04-12 9:11 ` [PATCH v5 0/4] gpio: mvebu: Add PWM fan support Gregory CLEMENT 2017-04-12 9:11 ` Gregory CLEMENT 2017-04-12 17:16 ` Thierry Reding [this message] 2017-04-12 17:16 ` Thierry Reding [not found] ` <20170412171656.GC11964-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org> 2017-04-13 7:49 ` Ralph Sennhauser 2017-04-13 7:49 ` Ralph Sennhauser 2017-04-13 7:49 ` Ralph Sennhauser 2017-04-14 15:40 Ralph Sennhauser 2017-04-14 15:40 ` Ralph Sennhauser
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170412171656.GC11964@ulmo.ba.sec \ --to=thierry.reding@gmail.com \ --cc=andrew@lunn.ch \ --cc=devicetree@vger.kernel.org \ --cc=gnurou@gmail.com \ --cc=gregory.clement@free-electrons.com \ --cc=jason@lakedaemon.net \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=ralph.sennhauser@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.