From: Dong Aisheng <dongas86@gmail.com> To: Leonard Crestez <leonard.crestez@nxp.com> Cc: Dong Aisheng <aisheng.dong@nxp.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, broonie@kernel.org, yibin.gong@nxp.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, mturquette@baylibre.com, sboyd@codeaurora.org, shawnguo@kernel.org, fabio.estevam@nxp.com, anson.huang@nxp.com, ping.bai@nxp.com, octavian.purdila@nxp.com, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH 1/3] clk: add clk_bulk_get accessories Date: Thu, 13 Apr 2017 22:02:25 +0800 [thread overview] Message-ID: <20170413140225.GB24254@b29396-OptiPlex-7040> (raw) In-Reply-To: <1491931159.31718.16.camel@nxp.com> On Tue, Apr 11, 2017 at 08:19:19PM +0300, Leonard Crestez wrote: > On Wed, 2017-04-12 at 12:03 +0800, Dong Aisheng wrote: > > +/** > > + * clk_bulk_enable - ungate a bulk of clocks > > + * @num_clks: the number of clk_bulk_data > > + * @clks: the clk_bulk_data table being ungated > > + * > > + * clk_bulk_enable must not sleep > > + * Returns 0 on success, -EERROR otherwise. > > + */ > > +int clk_bulk_enable(int num_clks, struct clk_bulk_data *clks) > > +{ > > + int ret; > > + int i; > > + > > + for (i = 0; i < num_clks; i++) { > > + ret = clk_enable(clks[i].clk); > > + if (ret) { > > + pr_err("Failed to enable clk '%s': %d\n", > > + clks[i].id, ret); > > + goto err; > > + } > > + } > > + > > + return 0; > > + > > +err: > > + while (--i >= 0) > > + clk_put(clks[i].clk); > > Shouldn't this be clk_disable? > Good catch! Will change in the formal version if Maintainer accepts this idea. > And you can probably use clk_bulk_disable(i, clks) instead Probably i'd prefer keep clk_disable to match with clk_enable to make things more clear. Thanks Regards Dong Aisheng
WARNING: multiple messages have this Message-ID (diff)
From: dongas86@gmail.com (Dong Aisheng) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 1/3] clk: add clk_bulk_get accessories Date: Thu, 13 Apr 2017 22:02:25 +0800 [thread overview] Message-ID: <20170413140225.GB24254@b29396-OptiPlex-7040> (raw) In-Reply-To: <1491931159.31718.16.camel@nxp.com> On Tue, Apr 11, 2017 at 08:19:19PM +0300, Leonard Crestez wrote: > On Wed, 2017-04-12 at 12:03 +0800, Dong Aisheng wrote: > > +/** > > + * clk_bulk_enable - ungate a bulk of clocks > > + * @num_clks: the number of clk_bulk_data > > + * @clks: the clk_bulk_data table being ungated > > + * > > + * clk_bulk_enable must not sleep > > + * Returns 0 on success, -EERROR otherwise. > > + */ > > +int clk_bulk_enable(int num_clks, struct clk_bulk_data *clks) > > +{ > > +???????int ret; > > +???????int i; > > + > > +???????for (i = 0; i < num_clks; i++) { > > +???????????????ret = clk_enable(clks[i].clk); > > +???????????????if (ret) { > > +???????????????????????pr_err("Failed to enable clk '%s': %d\n", > > +???????????????????????????????clks[i].id, ret); > > +???????????????????????goto err; > > +???????????????} > > +???????} > > + > > +???????return 0; > > + > > +err: > > +???????while (--i >= 0) > > +???????????????clk_put(clks[i].clk); > > Shouldn't this be clk_disable? > Good catch! Will change in the formal version if Maintainer accepts this idea. > And you can probably use clk_bulk_disable(i, clks) instead Probably i'd prefer keep clk_disable to match with clk_enable to make things more clear. Thanks Regards Dong Aisheng
next prev parent reply other threads:[~2017-04-13 14:02 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-12 4:03 [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories Dong Aisheng 2017-04-12 4:03 ` Dong Aisheng 2017-04-11 17:01 ` Florian Fainelli 2017-04-11 17:01 ` Florian Fainelli 2017-04-13 13:58 ` Dong Aisheng 2017-04-13 13:58 ` Dong Aisheng 2017-04-12 4:03 ` [RFC PATCH 1/3] clk: add " Dong Aisheng 2017-04-12 4:03 ` Dong Aisheng 2017-04-11 17:19 ` Leonard Crestez 2017-04-11 17:19 ` Leonard Crestez 2017-04-13 14:02 ` Dong Aisheng [this message] 2017-04-13 14:02 ` Dong Aisheng 2017-04-13 19:57 ` Geert Uytterhoeven 2017-04-13 19:57 ` Geert Uytterhoeven 2017-04-13 19:57 ` Geert Uytterhoeven 2017-04-13 14:25 ` Dong Aisheng 2017-04-13 14:25 ` Dong Aisheng 2017-04-13 19:56 ` Geert Uytterhoeven 2017-04-13 19:56 ` Geert Uytterhoeven 2017-04-13 19:56 ` Geert Uytterhoeven 2017-04-14 16:14 ` Dong Aisheng 2017-04-14 16:14 ` Dong Aisheng 2017-04-14 16:14 ` Dong Aisheng 2017-04-22 3:16 ` Stephen Boyd 2017-04-22 3:16 ` Stephen Boyd 2017-05-08 11:34 ` Dong Aisheng 2017-05-08 11:34 ` Dong Aisheng 2017-04-12 4:03 ` [RFC PATCH 2/3] clk: add managed version of clk_bulk_get Dong Aisheng 2017-04-12 4:03 ` Dong Aisheng 2017-04-13 14:37 ` Dong Aisheng 2017-04-13 14:37 ` Dong Aisheng 2017-04-22 2:58 ` Stephen Boyd 2017-04-22 2:58 ` Stephen Boyd 2017-05-08 11:41 ` Dong Aisheng 2017-05-08 11:41 ` Dong Aisheng 2017-04-22 2:55 ` Stephen Boyd 2017-04-22 2:55 ` Stephen Boyd 2017-05-08 11:37 ` Dong Aisheng 2017-05-08 11:37 ` Dong Aisheng 2017-04-12 4:03 ` [RFC PATCH 3/3] cpufreq: imx6q: refine clk operations Dong Aisheng 2017-04-12 4:03 ` Dong Aisheng 2017-04-11 17:48 ` Leonard Crestez 2017-04-11 17:48 ` Leonard Crestez 2017-04-13 14:21 ` Dong Aisheng 2017-04-13 14:21 ` Dong Aisheng 2017-04-22 3:04 ` [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories Stephen Boyd 2017-04-22 3:04 ` Stephen Boyd 2017-05-08 11:07 ` Dong Aisheng 2017-05-08 11:07 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170413140225.GB24254@b29396-OptiPlex-7040 \ --to=dongas86@gmail.com \ --cc=aisheng.dong@nxp.com \ --cc=anson.huang@nxp.com \ --cc=broonie@kernel.org \ --cc=fabio.estevam@nxp.com \ --cc=kernel@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=octavian.purdila@nxp.com \ --cc=ping.bai@nxp.com \ --cc=rjw@rjwysocki.net \ --cc=sboyd@codeaurora.org \ --cc=shawnguo@kernel.org \ --cc=viresh.kumar@linaro.org \ --cc=yibin.gong@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.