All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dong Aisheng <dongas86@gmail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
	broonie@kernel.org, yibin.gong@nxp.com, rjw@rjwysocki.net,
	viresh.kumar@linaro.org, mturquette@baylibre.com,
	shawnguo@kernel.org, fabio.estevam@nxp.com, anson.huang@nxp.com,
	ping.bai@nxp.com, leonard.crestez@nxp.com,
	octavian.purdila@nxp.com
Subject: Re: [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories
Date: Mon, 8 May 2017 19:07:26 +0800	[thread overview]
Message-ID: <20170508110726.GA18153@b29396-OptiPlex-7040> (raw)
In-Reply-To: <20170422030419.GV7065@codeaurora.org>

On Fri, Apr 21, 2017 at 08:04:19PM -0700, Stephen Boyd wrote:
> On 04/12, Dong Aisheng wrote:
> > 
> > Together with the err path handling for each clocks, it does make
> > things a bit ugly.
> > 
> > Since we already have regulator_bulk_get accessories, i thought we
> > probably could introduce clk_bulk_get as well to handle such case to
> > ease the driver owners' life. 
> > 
> > Besides IMX cpufreq driver, there is also some similar cases
> > in kernel which could befinit from this api as well.
> > e.g.
> > drivers/cpufreq/tegra124-cpufreq.c
> > drivers/cpufreq/s3c2412-cpufreq.c
> > sound/soc/samsung/smdk_spdif.c
> > arch/arm/mach-omap1/serial.c
> > ...
> > 
> > And actually, if we handle clocks more than 3, then it might be
> > worthy to try, which there is quite many manay in kernel and
> > that probably could save a lot codes.
> > 
> > This is a RFC patch intending to bring up the idea to discuss.
> > 
> 
> Idea seems fine to me. Please also add Russell King, as we need
> an ack from him on the clk.h API changes.
> 

Great! Thanks! And sorry to miss Russell King.
Quite willing to add him to help review in the next series.

Regards
Dong Aisheng

WARNING: multiple messages have this Message-ID (diff)
From: dongas86@gmail.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories
Date: Mon, 8 May 2017 19:07:26 +0800	[thread overview]
Message-ID: <20170508110726.GA18153@b29396-OptiPlex-7040> (raw)
In-Reply-To: <20170422030419.GV7065@codeaurora.org>

On Fri, Apr 21, 2017 at 08:04:19PM -0700, Stephen Boyd wrote:
> On 04/12, Dong Aisheng wrote:
> > 
> > Together with the err path handling for each clocks, it does make
> > things a bit ugly.
> > 
> > Since we already have regulator_bulk_get accessories, i thought we
> > probably could introduce clk_bulk_get as well to handle such case to
> > ease the driver owners' life. 
> > 
> > Besides IMX cpufreq driver, there is also some similar cases
> > in kernel which could befinit from this api as well.
> > e.g.
> > drivers/cpufreq/tegra124-cpufreq.c
> > drivers/cpufreq/s3c2412-cpufreq.c
> > sound/soc/samsung/smdk_spdif.c
> > arch/arm/mach-omap1/serial.c
> > ...
> > 
> > And actually, if we handle clocks more than 3, then it might be
> > worthy to try, which there is quite many manay in kernel and
> > that probably could save a lot codes.
> > 
> > This is a RFC patch intending to bring up the idea to discuss.
> > 
> 
> Idea seems fine to me. Please also add Russell King, as we need
> an ack from him on the clk.h API changes.
> 

Great! Thanks! And sorry to miss Russell King.
Quite willing to add him to help review in the next series.

Regards
Dong Aisheng

  reply	other threads:[~2017-05-08 11:07 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12  4:03 [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories Dong Aisheng
2017-04-12  4:03 ` Dong Aisheng
2017-04-11 17:01 ` Florian Fainelli
2017-04-11 17:01   ` Florian Fainelli
2017-04-13 13:58   ` Dong Aisheng
2017-04-13 13:58     ` Dong Aisheng
2017-04-12  4:03 ` [RFC PATCH 1/3] clk: add " Dong Aisheng
2017-04-12  4:03   ` Dong Aisheng
2017-04-11 17:19   ` Leonard Crestez
2017-04-11 17:19     ` Leonard Crestez
2017-04-13 14:02     ` Dong Aisheng
2017-04-13 14:02       ` Dong Aisheng
2017-04-13 19:57     ` Geert Uytterhoeven
2017-04-13 19:57       ` Geert Uytterhoeven
2017-04-13 19:57       ` Geert Uytterhoeven
2017-04-13 14:25   ` Dong Aisheng
2017-04-13 14:25     ` Dong Aisheng
2017-04-13 19:56   ` Geert Uytterhoeven
2017-04-13 19:56     ` Geert Uytterhoeven
2017-04-13 19:56     ` Geert Uytterhoeven
2017-04-14 16:14     ` Dong Aisheng
2017-04-14 16:14       ` Dong Aisheng
2017-04-14 16:14       ` Dong Aisheng
2017-04-22  3:16   ` Stephen Boyd
2017-04-22  3:16     ` Stephen Boyd
2017-05-08 11:34     ` Dong Aisheng
2017-05-08 11:34       ` Dong Aisheng
2017-04-12  4:03 ` [RFC PATCH 2/3] clk: add managed version of clk_bulk_get Dong Aisheng
2017-04-12  4:03   ` Dong Aisheng
2017-04-13 14:37   ` Dong Aisheng
2017-04-13 14:37     ` Dong Aisheng
2017-04-22  2:58     ` Stephen Boyd
2017-04-22  2:58       ` Stephen Boyd
2017-05-08 11:41       ` Dong Aisheng
2017-05-08 11:41         ` Dong Aisheng
2017-04-22  2:55   ` Stephen Boyd
2017-04-22  2:55     ` Stephen Boyd
2017-05-08 11:37     ` Dong Aisheng
2017-05-08 11:37       ` Dong Aisheng
2017-04-12  4:03 ` [RFC PATCH 3/3] cpufreq: imx6q: refine clk operations Dong Aisheng
2017-04-12  4:03   ` Dong Aisheng
2017-04-11 17:48   ` Leonard Crestez
2017-04-11 17:48     ` Leonard Crestez
2017-04-13 14:21     ` Dong Aisheng
2017-04-13 14:21       ` Dong Aisheng
2017-04-22  3:04 ` [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories Stephen Boyd
2017-04-22  3:04   ` Stephen Boyd
2017-05-08 11:07   ` Dong Aisheng [this message]
2017-05-08 11:07     ` Dong Aisheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170508110726.GA18153@b29396-OptiPlex-7040 \
    --to=dongas86@gmail.com \
    --cc=aisheng.dong@nxp.com \
    --cc=anson.huang@nxp.com \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=octavian.purdila@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=rjw@rjwysocki.net \
    --cc=sboyd@codeaurora.org \
    --cc=shawnguo@kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.