From: Tony Lindgren <tony@atomide.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, "Wolfram Sang" <wsa@the-dreams.de>,
linux-arm-kernel@lists.infradead.org,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-omap@vger.kernel.org,
"Russell King" <linux@armlinux.org.uk>,
"Mark Jackson" <mpfj@newflow.co.uk>
Subject: Re: [PATCH v3 03/21] ARM: dts: omap: Add generic compatible string for I2C EEPROM
Date: Fri, 14 Apr 2017 07:17:35 -0700 [thread overview]
Message-ID: <20170414141734.GR5339@atomide.com> (raw)
In-Reply-To: <20170414010445.21727-4-javier@osg.samsung.com>
* Javier Martinez Canillas <javier@osg.samsung.com> [170413 18:08]:
> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
>
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Looks good to me assuming this will get merged in a single series:
Acked-by: Tony Lindgren <tony@atomide.com>
Or if you want me to pick this patch separately, let me know.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Javier Martinez Canillas
<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Wolfram Sang" <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Russell King" <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
"Mark Jackson" <mpfj-2FZW7xY0fHgqdlJmJB21zg@public.gmane.org>
Subject: Re: [PATCH v3 03/21] ARM: dts: omap: Add generic compatible string for I2C EEPROM
Date: Fri, 14 Apr 2017 07:17:35 -0700 [thread overview]
Message-ID: <20170414141734.GR5339@atomide.com> (raw)
In-Reply-To: <20170414010445.21727-4-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
* Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> [170413 18:08]:
> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
>
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
>
> Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Looks good to me assuming this will get merged in a single series:
Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Or if you want me to pick this patch separately, let me know.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/21] ARM: dts: omap: Add generic compatible string for I2C EEPROM
Date: Fri, 14 Apr 2017 07:17:35 -0700 [thread overview]
Message-ID: <20170414141734.GR5339@atomide.com> (raw)
In-Reply-To: <20170414010445.21727-4-javier@osg.samsung.com>
* Javier Martinez Canillas <javier@osg.samsung.com> [170413 18:08]:
> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
>
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Looks good to me assuming this will get merged in a single series:
Acked-by: Tony Lindgren <tony@atomide.com>
Or if you want me to pick this patch separately, let me know.
Regards,
Tony
next prev parent reply other threads:[~2017-04-14 14:17 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 1:04 [PATCH v3 00/21] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 01/21] dt-bindings: i2c: eeprom: Document manufacturer used as generic fallback Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-19 23:27 ` Rob Herring
2017-04-19 23:27 ` Rob Herring
2017-04-19 23:35 ` Rob Herring
2017-04-19 23:35 ` Rob Herring
2017-05-15 10:48 ` Javier Martinez Canillas
2017-05-15 10:48 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 02/21] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 03/21] ARM: dts: omap: Add generic compatible string for I2C EEPROM Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 14:17 ` Tony Lindgren [this message]
2017-04-14 14:17 ` Tony Lindgren
2017-04-14 14:17 ` Tony Lindgren
2017-04-19 23:56 ` Rob Herring
2017-04-19 23:56 ` Rob Herring
2017-04-19 23:56 ` Rob Herring
2017-05-15 10:55 ` Javier Martinez Canillas
2017-05-15 10:55 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 04/21] ARM: dts: turris-omnia: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 05/21] ARM: dts: at91: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-05-15 9:32 ` Alexandre Belloni
2017-05-15 9:32 ` Alexandre Belloni
2017-05-15 9:32 ` Alexandre Belloni
2017-04-14 1:04 ` [PATCH v3 06/21] ARM: dts: efm32: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 07/21] ARM: dts: imx: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 08/21] ARM: dts: keystone: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 09/21] ARM: dts: lpc18xx: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 10/21] ARM: dts: r7s72100: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 11/21] ARM: dts: koelsch: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 12/21] ARM: dts: socfpga: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 13/21] ARM: dts: uniphier: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 14/21] ARM: dts: zynq: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 15/21] arm64: dts: ls1043a: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 16/21] arm64: zynqmp: " Javier Martinez Canillas
2017-04-14 1:04 ` Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 17/21] powerpc/5200: " Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 18/21] powerpc/fsl: " Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 19/21] powerpc/512x: " Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 20/21] powerpc/83xx: " Javier Martinez Canillas
2017-04-14 1:04 ` [PATCH v3 21/21] powerpc/44x: " Javier Martinez Canillas
2017-04-20 0:12 ` [PATCH v3 00/21] eeprom: at24: Add OF device ID table Rob Herring
2017-04-20 0:12 ` Rob Herring
2017-04-20 0:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414141734.GR5339@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mpfj@newflow.co.uk \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.