All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, a.hajda@samsung.com,
	geert@linux-m68k.org, Laura Abbott <labbott@redhat.com>,
	robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()
Date: Fri, 28 Apr 2017 18:14:11 +0200	[thread overview]
Message-ID: <20170428161411.GA26277@kroah.com> (raw)
In-Reply-To: <20170425182549.GA18677@e104818-lin.cambridge.arm.com>

On Tue, Apr 25, 2017 at 07:25:49PM +0100, Catalin Marinas wrote:
> On Tue, Apr 25, 2017 at 07:22:23PM +0100, Catalin Marinas wrote:
> > The dma_common_pages_remap() function allocates a vm_struct object and
> > initialises the pages pointer to value passed as argument. However, when
> > this function is called dma_common_contiguous_remap(), the pages array
> > is only temporarily allocated, being freed shortly after
> > dma_common_contiguous_remap() returns. Architecture code checking the
> > validity of an area->pages pointer would incorrectly dereference already
> > freed pointers. This has been exposed by the arm64 commit 44176bb38fa4
> > ("arm64: Add support for DMA_ATTR_FORCE_CONTIGUOUS to IOMMU").
> > 
> > Fixes: 513510ddba96 ("common: dma-mapping: introduce common remapping functions")
> > Cc: Laura Abbott <labbott@redhat.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Reported-by: Andrzej Hajda <a.hajda@samsung.com>
> > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> 
> Small correction on the subject, the prefix should be something like:
> 
> drivers: dma-mapping:
> 
> It's not an arm64 patch.

If you want to take it through your tree:
	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
otherwise feel free to resend it with a fixed subject line and I can
take it :)

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()
Date: Fri, 28 Apr 2017 18:14:11 +0200	[thread overview]
Message-ID: <20170428161411.GA26277@kroah.com> (raw)
In-Reply-To: <20170425182549.GA18677@e104818-lin.cambridge.arm.com>

On Tue, Apr 25, 2017 at 07:25:49PM +0100, Catalin Marinas wrote:
> On Tue, Apr 25, 2017 at 07:22:23PM +0100, Catalin Marinas wrote:
> > The dma_common_pages_remap() function allocates a vm_struct object and
> > initialises the pages pointer to value passed as argument. However, when
> > this function is called dma_common_contiguous_remap(), the pages array
> > is only temporarily allocated, being freed shortly after
> > dma_common_contiguous_remap() returns. Architecture code checking the
> > validity of an area->pages pointer would incorrectly dereference already
> > freed pointers. This has been exposed by the arm64 commit 44176bb38fa4
> > ("arm64: Add support for DMA_ATTR_FORCE_CONTIGUOUS to IOMMU").
> > 
> > Fixes: 513510ddba96 ("common: dma-mapping: introduce common remapping functions")
> > Cc: Laura Abbott <labbott@redhat.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Reported-by: Andrzej Hajda <a.hajda@samsung.com>
> > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> 
> Small correction on the subject, the prefix should be something like:
> 
> drivers: dma-mapping:
> 
> It's not an arm64 patch.

If you want to take it through your tree:
	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
otherwise feel free to resend it with a fixed subject line and I can
take it :)

thanks,

greg k-h

  reply	other threads:[~2017-04-28 16:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 18:22 [PATCH] arm64: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap() Catalin Marinas
2017-04-25 18:22 ` Catalin Marinas
2017-04-25 18:25 ` [PATCH] drivers: dma-mapping: " Catalin Marinas
2017-04-25 18:25   ` Catalin Marinas
2017-04-28 16:14   ` Greg Kroah-Hartman [this message]
2017-04-28 16:14     ` Greg Kroah-Hartman
2017-04-25 19:38 ` [PATCH] arm64: " Laura Abbott
2017-04-25 19:38   ` Laura Abbott
2017-05-03 12:10 ` Robin Murphy
2017-05-03 12:10   ` Robin Murphy
2017-05-03 14:12   ` Catalin Marinas
2017-05-03 14:12     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170428161411.GA26277@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hajda@samsung.com \
    --cc=catalin.marinas@arm.com \
    --cc=geert@linux-m68k.org \
    --cc=labbott@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.