All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Colin King <colin.king@canonical.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/sched: remove redundant null check on head
Date: Wed, 3 May 2017 16:15:33 +0200	[thread overview]
Message-ID: <20170503141533.GC2077@nanopsycho.orion> (raw)
In-Reply-To: <20170503135040.32023-1-colin.king@canonical.com>

Wed, May 03, 2017 at 03:50:40PM CEST, colin.king@canonical.com wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>head is previously null checked and so the 2nd null check on head
>is redundant and therefore can be removed.
>
>Detected by CoverityScan, CID#1399505 ("Logically dead code")
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Jiri Pirko <jiri@mellanox.com>

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Pirko <jiri@resnulli.us>
To: Colin King <colin.king@canonical.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/sched: remove redundant null check on head
Date: Wed, 03 May 2017 14:15:33 +0000	[thread overview]
Message-ID: <20170503141533.GC2077@nanopsycho.orion> (raw)
In-Reply-To: <20170503135040.32023-1-colin.king@canonical.com>

Wed, May 03, 2017 at 03:50:40PM CEST, colin.king@canonical.com wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>head is previously null checked and so the 2nd null check on head
>is redundant and therefore can be removed.
>
>Detected by CoverityScan, CID#1399505 ("Logically dead code")
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Jiri Pirko <jiri@mellanox.com>

  reply	other threads:[~2017-05-03 14:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 13:50 [PATCH] net/sched: remove redundant null check on head Colin King
2017-05-03 13:50 ` Colin King
2017-05-03 14:15 ` Jiri Pirko [this message]
2017-05-03 14:15   ` Jiri Pirko
2017-05-03 14:21 ` walter harms
2017-05-03 14:21   ` walter harms
2017-05-03 15:12   ` Jiri Pirko
2017-05-03 15:12     ` Jiri Pirko
2017-05-03 17:20 ` walter harms
2017-05-04 15:01 ` David Miller
2017-05-04 15:01   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503141533.GC2077@nanopsycho.orion \
    --to=jiri@resnulli.us \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.