From: Sebastian Reichel <sebastian.reichel@collabora.co.uk> To: Mike Looijmans <mike.looijmans@topic.nl> Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com Subject: Re: [PATCH v2] dt-bindings: power: New bindings for ltc3651-charger Date: Mon, 15 May 2017 15:17:54 +0200 [thread overview] Message-ID: <20170515131754.pbnvgiqa2awkgnyp@earth> (raw) In-Reply-To: <1494308190-3687-1-git-send-email-mike.looijmans@topic.nl> [-- Attachment #1: Type: text/plain, Size: 2006 bytes --] Hi Mike, On Tue, May 09, 2017 at 07:36:30AM +0200, Mike Looijmans wrote: > This adds the devicetree bindings documentation for the LTC3651 battery charger. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> Thanks, queued. -- Sebastian > --- > v2: Add "lltc," vendor prefix to gpios > Expand irq paragraph > > .../bindings/power/supply/ltc3651-charger.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > new file mode 100644 > index 0000000..71f2840 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > @@ -0,0 +1,27 @@ > +ltc3651-charger > + > +Required properties: > + - compatible: "lltc,ltc3651-charger" > + - lltc,acpr-gpios: Connect to ACPR output. See remark below. > + > +Optional properties: > + - lltc,fault-gpios: Connect to FAULT output. See remark below. > + - lltc,chrg-gpios: Connect to CHRG output. See remark below. > + > +The ltc3651 outputs are open-drain type and active low. The driver assumes the > +GPIO reports "active" when the output is asserted, so if the pins have been > +connected directly, the GPIO flags should be set to active low also. > + > +The driver will attempt to aquire interrupts for all GPIOs to detect changes in > +line state. If the system is not capabale of providing interrupts, the driver > +cannot report changes and userspace will need to periodically read the sysfs > +attributes to detect changes. > + > +Example: > + > + charger: battery-charger { > + compatible = "lltc,ltc3651-charger"; > + lltc,acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; > + lltc,fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; > + lltc,chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; > + }; > -- > 1.9.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> To: Mike Looijmans <mike.looijmans-Oq418RWZeHk@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org Subject: Re: [PATCH v2] dt-bindings: power: New bindings for ltc3651-charger Date: Mon, 15 May 2017 15:17:54 +0200 [thread overview] Message-ID: <20170515131754.pbnvgiqa2awkgnyp@earth> (raw) In-Reply-To: <1494308190-3687-1-git-send-email-mike.looijmans-Oq418RWZeHk@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 2026 bytes --] Hi Mike, On Tue, May 09, 2017 at 07:36:30AM +0200, Mike Looijmans wrote: > This adds the devicetree bindings documentation for the LTC3651 battery charger. > > Signed-off-by: Mike Looijmans <mike.looijmans-Oq418RWZeHk@public.gmane.org> Thanks, queued. -- Sebastian > --- > v2: Add "lltc," vendor prefix to gpios > Expand irq paragraph > > .../bindings/power/supply/ltc3651-charger.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > new file mode 100644 > index 0000000..71f2840 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > @@ -0,0 +1,27 @@ > +ltc3651-charger > + > +Required properties: > + - compatible: "lltc,ltc3651-charger" > + - lltc,acpr-gpios: Connect to ACPR output. See remark below. > + > +Optional properties: > + - lltc,fault-gpios: Connect to FAULT output. See remark below. > + - lltc,chrg-gpios: Connect to CHRG output. See remark below. > + > +The ltc3651 outputs are open-drain type and active low. The driver assumes the > +GPIO reports "active" when the output is asserted, so if the pins have been > +connected directly, the GPIO flags should be set to active low also. > + > +The driver will attempt to aquire interrupts for all GPIOs to detect changes in > +line state. If the system is not capabale of providing interrupts, the driver > +cannot report changes and userspace will need to periodically read the sysfs > +attributes to detect changes. > + > +Example: > + > + charger: battery-charger { > + compatible = "lltc,ltc3651-charger"; > + lltc,acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; > + lltc,fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; > + lltc,chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; > + }; > -- > 1.9.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-15 13:18 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-05 6:38 [PATCH] dt-bindings: power: New bindings for ltc3651-charger Mike Looijmans 2017-05-08 17:12 ` Rob Herring 2017-05-09 5:26 ` Mike Looijmans 2017-05-09 5:26 ` Mike Looijmans 2017-05-09 5:36 ` [PATCH v2] " Mike Looijmans 2017-05-09 5:36 ` Mike Looijmans 2017-05-12 20:11 ` Rob Herring 2017-05-15 13:17 ` Sebastian Reichel [this message] 2017-05-15 13:17 ` Sebastian Reichel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170515131754.pbnvgiqa2awkgnyp@earth \ --to=sebastian.reichel@collabora.co.uk \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mike.looijmans@topic.nl \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.