* [PATCH] dt-bindings: power: New bindings for ltc3651-charger @ 2017-05-05 6:38 Mike Looijmans 2017-05-08 17:12 ` Rob Herring 0 siblings, 1 reply; 9+ messages in thread From: Mike Looijmans @ 2017-05-05 6:38 UTC (permalink / raw) To: devicetree Cc: sre, linux-pm, linux-kernel, robh+dt, mark.rutland, Mike Looijmans This adds the devicetree bindings documentation for the LTC3651 battery charger. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- .../bindings/power/supply/ltc3651-charger.txt | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt new file mode 100644 index 0000000..a7dd80f --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt @@ -0,0 +1,26 @@ +ltc3651-charger + +Required properties: + - compatible: "lltc,ltc3651-charger" + - acpr-gpios: Connect to ACPR output. See remark below. + +Optional properties: + - fault-gpios: Connect to FAULT output. See remark below. + - chrg-gpios: Connect to CHRG output. See remark below. + +The ltc3651 outputs are open-drain type and active low. The driver assumes the +GPIO reports "active" when the output is asserted, so if the pins have been +connected directly, the GPIO flags should be set to active low also. + +The driver will attempt to aquire interrupts for all GPIOs. If the system is +not capabale of providing that, the driver cannot report changes and userspace +will need to periodically read the sysfs attributes to detect changes. + +Example: + + charger: battery-charger { + compatible = "lltc,ltc3651-charger"; + acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; + fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; + chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; + }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: New bindings for ltc3651-charger 2017-05-05 6:38 [PATCH] dt-bindings: power: New bindings for ltc3651-charger Mike Looijmans @ 2017-05-08 17:12 ` Rob Herring 2017-05-09 5:26 ` Mike Looijmans 2017-05-09 5:36 ` Mike Looijmans 0 siblings, 2 replies; 9+ messages in thread From: Rob Herring @ 2017-05-08 17:12 UTC (permalink / raw) To: Mike Looijmans; +Cc: devicetree, sre, linux-pm, linux-kernel, mark.rutland On Fri, May 05, 2017 at 08:38:35AM +0200, Mike Looijmans wrote: > This adds the devicetree bindings documentation for the LTC3651 battery charger. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > .../bindings/power/supply/ltc3651-charger.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > new file mode 100644 > index 0000000..a7dd80f > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > @@ -0,0 +1,26 @@ > +ltc3651-charger > + > +Required properties: > + - compatible: "lltc,ltc3651-charger" > + - acpr-gpios: Connect to ACPR output. See remark below. > + > +Optional properties: > + - fault-gpios: Connect to FAULT output. See remark below. > + - chrg-gpios: Connect to CHRG output. See remark below. All the gpios need vendor prefix. > + > +The ltc3651 outputs are open-drain type and active low. The driver assumes the > +GPIO reports "active" when the output is asserted, so if the pins have been > +connected directly, the GPIO flags should be set to active low also. > + > +The driver will attempt to aquire interrupts for all GPIOs. If the system is > +not capabale of providing that, the driver cannot report changes and userspace > +will need to periodically read the sysfs attributes to detect changes. If these are interrupts, then you should use the interrupt binding instead (most GPIO controllers are also interrupt controllers). > + > +Example: > + > + charger: battery-charger { > + compatible = "lltc,ltc3651-charger"; > + acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; > + fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; > + chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; > + }; > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: New bindings for ltc3651-charger 2017-05-08 17:12 ` Rob Herring @ 2017-05-09 5:26 ` Mike Looijmans 2017-05-09 5:36 ` Mike Looijmans 1 sibling, 0 replies; 9+ messages in thread From: Mike Looijmans @ 2017-05-09 5:26 UTC (permalink / raw) To: Rob Herring; +Cc: devicetree, sre, linux-pm, linux-kernel, mark.rutland On 08-05-17 19:12, Rob Herring wrote: > On Fri, May 05, 2017 at 08:38:35AM +0200, Mike Looijmans wrote: >> This adds the devicetree bindings documentation for the LTC3651 battery charger. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> --- >> .../bindings/power/supply/ltc3651-charger.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt >> >> diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt >> new file mode 100644 >> index 0000000..a7dd80f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt >> @@ -0,0 +1,26 @@ >> +ltc3651-charger >> + >> +Required properties: >> + - compatible: "lltc,ltc3651-charger" >> + - acpr-gpios: Connect to ACPR output. See remark below. >> + >> +Optional properties: >> + - fault-gpios: Connect to FAULT output. See remark below. >> + - chrg-gpios: Connect to CHRG output. See remark below. > > All the gpios need vendor prefix. Will prefix "lltc," adjust the driver and submit new patches. > >> + >> +The ltc3651 outputs are open-drain type and active low. The driver assumes the >> +GPIO reports "active" when the output is asserted, so if the pins have been >> +connected directly, the GPIO flags should be set to active low also. >> + >> +The driver will attempt to aquire interrupts for all GPIOs. If the system is >> +not capabale of providing that, the driver cannot report changes and userspace >> +will need to periodically read the sysfs attributes to detect changes. > > If these are interrupts, then you should use the interrupt binding > instead (most GPIO controllers are also interrupt controllers). They're GPIO (the driver needs the current state), the use of interrupts is just to detect changes. Similar to gpio-charger for example. Interrupt bindings cannot provide the current state of the line. > >> + >> +Example: >> + >> + charger: battery-charger { >> + compatible = "lltc,ltc3651-charger"; >> + acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; >> + fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; >> + chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; >> + }; >> -- >> 1.9.1 >> Kind regards, Mike Looijmans System Expert TOPIC Products Materiaalweg 4, NL-5681 RJ Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 E-mail: mike.looijmans@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: power: New bindings for ltc3651-charger @ 2017-05-09 5:26 ` Mike Looijmans 0 siblings, 0 replies; 9+ messages in thread From: Mike Looijmans @ 2017-05-09 5:26 UTC (permalink / raw) To: Rob Herring; +Cc: devicetree, sre, linux-pm, linux-kernel, mark.rutland On 08-05-17 19:12, Rob Herring wrote: > On Fri, May 05, 2017 at 08:38:35AM +0200, Mike Looijmans wrote: >> This adds the devicetree bindings documentation for the LTC3651 battery charger. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> --- >> .../bindings/power/supply/ltc3651-charger.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt >> >> diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt >> new file mode 100644 >> index 0000000..a7dd80f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt >> @@ -0,0 +1,26 @@ >> +ltc3651-charger >> + >> +Required properties: >> + - compatible: "lltc,ltc3651-charger" >> + - acpr-gpios: Connect to ACPR output. See remark below. >> + >> +Optional properties: >> + - fault-gpios: Connect to FAULT output. See remark below. >> + - chrg-gpios: Connect to CHRG output. See remark below. > > All the gpios need vendor prefix. Will prefix "lltc," adjust the driver and submit new patches. > >> + >> +The ltc3651 outputs are open-drain type and active low. The driver assumes the >> +GPIO reports "active" when the output is asserted, so if the pins have been >> +connected directly, the GPIO flags should be set to active low also. >> + >> +The driver will attempt to aquire interrupts for all GPIOs. If the system is >> +not capabale of providing that, the driver cannot report changes and userspace >> +will need to periodically read the sysfs attributes to detect changes. > > If these are interrupts, then you should use the interrupt binding > instead (most GPIO controllers are also interrupt controllers). They're GPIO (the driver needs the current state), the use of interrupts is just to detect changes. Similar to gpio-charger for example. Interrupt bindings cannot provide the current state of the line. > >> + >> +Example: >> + >> + charger: battery-charger { >> + compatible = "lltc,ltc3651-charger"; >> + acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; >> + fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; >> + chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; >> + }; >> -- >> 1.9.1 >> Kind regards, Mike Looijmans System Expert TOPIC Products Materiaalweg 4, NL-5681 RJ Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 E-mail: mike.looijmans@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] dt-bindings: power: New bindings for ltc3651-charger 2017-05-08 17:12 ` Rob Herring @ 2017-05-09 5:36 ` Mike Looijmans 2017-05-09 5:36 ` Mike Looijmans 1 sibling, 0 replies; 9+ messages in thread From: Mike Looijmans @ 2017-05-09 5:36 UTC (permalink / raw) To: devicetree; +Cc: sre, linux-pm, linux-kernel, mark.rutland, Mike Looijmans This adds the devicetree bindings documentation for the LTC3651 battery charger. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- v2: Add "lltc," vendor prefix to gpios Expand irq paragraph .../bindings/power/supply/ltc3651-charger.txt | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt new file mode 100644 index 0000000..71f2840 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt @@ -0,0 +1,27 @@ +ltc3651-charger + +Required properties: + - compatible: "lltc,ltc3651-charger" + - lltc,acpr-gpios: Connect to ACPR output. See remark below. + +Optional properties: + - lltc,fault-gpios: Connect to FAULT output. See remark below. + - lltc,chrg-gpios: Connect to CHRG output. See remark below. + +The ltc3651 outputs are open-drain type and active low. The driver assumes the +GPIO reports "active" when the output is asserted, so if the pins have been +connected directly, the GPIO flags should be set to active low also. + +The driver will attempt to aquire interrupts for all GPIOs to detect changes in +line state. If the system is not capabale of providing interrupts, the driver +cannot report changes and userspace will need to periodically read the sysfs +attributes to detect changes. + +Example: + + charger: battery-charger { + compatible = "lltc,ltc3651-charger"; + lltc,acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; + lltc,fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; + lltc,chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; + }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2] dt-bindings: power: New bindings for ltc3651-charger @ 2017-05-09 5:36 ` Mike Looijmans 0 siblings, 0 replies; 9+ messages in thread From: Mike Looijmans @ 2017-05-09 5:36 UTC (permalink / raw) To: devicetree-u79uwXL29TY76Z2rM5mHXA Cc: sre-DgEjT+Ai2ygdnm+yROfE0A, linux-pm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8, Mike Looijmans This adds the devicetree bindings documentation for the LTC3651 battery charger. Signed-off-by: Mike Looijmans <mike.looijmans-Oq418RWZeHk@public.gmane.org> --- v2: Add "lltc," vendor prefix to gpios Expand irq paragraph .../bindings/power/supply/ltc3651-charger.txt | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt new file mode 100644 index 0000000..71f2840 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt @@ -0,0 +1,27 @@ +ltc3651-charger + +Required properties: + - compatible: "lltc,ltc3651-charger" + - lltc,acpr-gpios: Connect to ACPR output. See remark below. + +Optional properties: + - lltc,fault-gpios: Connect to FAULT output. See remark below. + - lltc,chrg-gpios: Connect to CHRG output. See remark below. + +The ltc3651 outputs are open-drain type and active low. The driver assumes the +GPIO reports "active" when the output is asserted, so if the pins have been +connected directly, the GPIO flags should be set to active low also. + +The driver will attempt to aquire interrupts for all GPIOs to detect changes in +line state. If the system is not capabale of providing interrupts, the driver +cannot report changes and userspace will need to periodically read the sysfs +attributes to detect changes. + +Example: + + charger: battery-charger { + compatible = "lltc,ltc3651-charger"; + lltc,acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; + lltc,fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; + lltc,chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; + }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: power: New bindings for ltc3651-charger 2017-05-09 5:36 ` Mike Looijmans (?) @ 2017-05-12 20:11 ` Rob Herring -1 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2017-05-12 20:11 UTC (permalink / raw) To: Mike Looijmans; +Cc: devicetree, sre, linux-pm, linux-kernel, mark.rutland On Tue, May 09, 2017 at 07:36:30AM +0200, Mike Looijmans wrote: > This adds the devicetree bindings documentation for the LTC3651 battery charger. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > v2: Add "lltc," vendor prefix to gpios > Expand irq paragraph > > .../bindings/power/supply/ltc3651-charger.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: power: New bindings for ltc3651-charger @ 2017-05-15 13:17 ` Sebastian Reichel 0 siblings, 0 replies; 9+ messages in thread From: Sebastian Reichel @ 2017-05-15 13:17 UTC (permalink / raw) To: Mike Looijmans; +Cc: devicetree, linux-pm, linux-kernel, mark.rutland [-- Attachment #1: Type: text/plain, Size: 2006 bytes --] Hi Mike, On Tue, May 09, 2017 at 07:36:30AM +0200, Mike Looijmans wrote: > This adds the devicetree bindings documentation for the LTC3651 battery charger. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> Thanks, queued. -- Sebastian > --- > v2: Add "lltc," vendor prefix to gpios > Expand irq paragraph > > .../bindings/power/supply/ltc3651-charger.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > new file mode 100644 > index 0000000..71f2840 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > @@ -0,0 +1,27 @@ > +ltc3651-charger > + > +Required properties: > + - compatible: "lltc,ltc3651-charger" > + - lltc,acpr-gpios: Connect to ACPR output. See remark below. > + > +Optional properties: > + - lltc,fault-gpios: Connect to FAULT output. See remark below. > + - lltc,chrg-gpios: Connect to CHRG output. See remark below. > + > +The ltc3651 outputs are open-drain type and active low. The driver assumes the > +GPIO reports "active" when the output is asserted, so if the pins have been > +connected directly, the GPIO flags should be set to active low also. > + > +The driver will attempt to aquire interrupts for all GPIOs to detect changes in > +line state. If the system is not capabale of providing interrupts, the driver > +cannot report changes and userspace will need to periodically read the sysfs > +attributes to detect changes. > + > +Example: > + > + charger: battery-charger { > + compatible = "lltc,ltc3651-charger"; > + lltc,acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; > + lltc,fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; > + lltc,chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; > + }; > -- > 1.9.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] dt-bindings: power: New bindings for ltc3651-charger @ 2017-05-15 13:17 ` Sebastian Reichel 0 siblings, 0 replies; 9+ messages in thread From: Sebastian Reichel @ 2017-05-15 13:17 UTC (permalink / raw) To: Mike Looijmans Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-pm-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, mark.rutland-5wv7dgnIgG8 [-- Attachment #1: Type: text/plain, Size: 2026 bytes --] Hi Mike, On Tue, May 09, 2017 at 07:36:30AM +0200, Mike Looijmans wrote: > This adds the devicetree bindings documentation for the LTC3651 battery charger. > > Signed-off-by: Mike Looijmans <mike.looijmans-Oq418RWZeHk@public.gmane.org> Thanks, queued. -- Sebastian > --- > v2: Add "lltc," vendor prefix to gpios > Expand irq paragraph > > .../bindings/power/supply/ltc3651-charger.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > new file mode 100644 > index 0000000..71f2840 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt > @@ -0,0 +1,27 @@ > +ltc3651-charger > + > +Required properties: > + - compatible: "lltc,ltc3651-charger" > + - lltc,acpr-gpios: Connect to ACPR output. See remark below. > + > +Optional properties: > + - lltc,fault-gpios: Connect to FAULT output. See remark below. > + - lltc,chrg-gpios: Connect to CHRG output. See remark below. > + > +The ltc3651 outputs are open-drain type and active low. The driver assumes the > +GPIO reports "active" when the output is asserted, so if the pins have been > +connected directly, the GPIO flags should be set to active low also. > + > +The driver will attempt to aquire interrupts for all GPIOs to detect changes in > +line state. If the system is not capabale of providing interrupts, the driver > +cannot report changes and userspace will need to periodically read the sysfs > +attributes to detect changes. > + > +Example: > + > + charger: battery-charger { > + compatible = "lltc,ltc3651-charger"; > + lltc,acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>; > + lltc,fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>; > + lltc,chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>; > + }; > -- > 1.9.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-05-15 13:18 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-05 6:38 [PATCH] dt-bindings: power: New bindings for ltc3651-charger Mike Looijmans 2017-05-08 17:12 ` Rob Herring 2017-05-09 5:26 ` Mike Looijmans 2017-05-09 5:26 ` Mike Looijmans 2017-05-09 5:36 ` [PATCH v2] " Mike Looijmans 2017-05-09 5:36 ` Mike Looijmans 2017-05-12 20:11 ` Rob Herring 2017-05-15 13:17 ` Sebastian Reichel 2017-05-15 13:17 ` Sebastian Reichel
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.