[meta-rockchip] [PATCH v3 0/3] Add video codec recipes

[meta-rockchip] [PATCH v3 0/3] Add video codec recipes

[ayaka]

Those packages are the userspace libraries for the Rockchip
Android video codec driver.

Also a minimal image used for verified the media framework is included.

ayaka (3):
  recipes-multimedia: add Rockchip MPP library
  recipes-multimedia: add gstreamer rockchip support
  recipes-multimedia: images: rockchip media image

 .../gstreamer/gstreamer1.0-rockchip.inc            | 32 ++++++++++++++++++++++
 .../gstreamer/gstreamer1.0-rockchip_20170516.bb    |  9 ++++++
 .../gstreamer/gstreamer1.0-rockchip_git.bb         | 13 +++++++++
 recipes-multimedia/images/rockchip-media-image.bb  | 21 ++++++++++++++
 recipes-multimedia/rockchip-mpp/rockchip-mpp.inc   | 21 ++++++++++++++
 .../rockchip-mpp/rockchip-mpp_20170412.bb          |  9 ++++++
 .../rockchip-mpp/rockchip-mpp_git.bb               | 16 +++++++++++
 7 files changed, 121 insertions(+)
 create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
 create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170516.bb
 create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb
 create mode 100644 recipes-multimedia/images/rockchip-media-image.bb
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb

-- 
2.9.4

[PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

[ayaka]

MPP means Media Process Platform. The MPP is a middleware
for the other video encoder/decoder interface, translating
the video information into the hardware registers.

Signed-off-by: ayaka <ayaka@soulik.info>
---
 recipes-multimedia/rockchip-mpp/rockchip-mpp.inc    | 21 +++++++++++++++++++++
 .../rockchip-mpp/rockchip-mpp_20170412.bb           |  9 +++++++++
 recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb | 16 ++++++++++++++++
 3 files changed, 46 insertions(+)
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
 create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb

diff --git a/recipes-multimedia/rockchip-mpp/rockchip-mpp.inc b/recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
new file mode 100644
index 0000000..6a45637
--- /dev/null
+++ b/recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
@@ -0,0 +1,21 @@
+# Copyright (C) 2016 - 2017 Randy Li <ayaka@soulik.info>
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://inc/rk_mpi.h;beginline=4;endline=14;md5=acbba394ae5639b0c786f60c1f48e3d6"
+
+inherit pkgconfig cmake
+
+EXTRA_OECMAKE = "     \
+    -DRKPLATFORM=ON   \
+    -DHAVE_DRM=ON     \
+"
+
+PACKAGES = "${PN}-dbg ${PN}-staticdev ${PN}-dev ${PN} rockchip-vpu"
+FILES_rockchip-vpu = "${libdir}/lib*vpu${SOLIBS}"
+FILES_${PN} = "${libdir}/lib*mpp${SOLIBS}"
+FILES_${PN}-dev = "${libdir}/lib*${SOLIBSDEV} ${includedir} ${libdir}/pkgconfig"
+SECTION_${PN}-dev = "devel"
+FILES_${PN}-staticdev = "${libdir}/*.a"
+SECTION_${PN}-staticdev = "devel"
diff --git a/recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb b/recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
new file mode 100644
index 0000000..501306a
--- /dev/null
+++ b/recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
@@ -0,0 +1,9 @@
+# Copyright (C) 2016 - 2017 Randy Li <ayaka@soulik.info>
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+include rockchip-mpp.inc
+
+TAG = "release_${PV}"
+SRC_URI = "git://github.com/rockchip-linux/mpp.git;tag=${TAG};nobranch=1"
+
+S = "${WORKDIR}/git"
diff --git a/recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb b/recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb
new file mode 100644
index 0000000..23f3f15
--- /dev/null
+++ b/recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb
@@ -0,0 +1,16 @@
+# Copyright (C) 2016 - 2017 Randy Li <ayaka@soulik.info>
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+
+DEFAULT_PREFERENCE = "-1"
+
+include rockchip-mpp.inc
+DEPENDS = "git-replacement-native"
+
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESPATH_prepend := "${THISDIR}/${PN}:"
+
+SRCREV = "${AUTOREV}"
+SRC_URI = "git://github.com/rockchip-linux/mpp.git;branch=develop"
+
+S = "${WORKDIR}/git"
-- 
2.9.4

[PATCH v3 2/3] recipes-multimedia: add gstreamer rockchip support

[ayaka]

This Gstreamer plugin provides a encoder and decoder plugin
for Gstreamer through the Rockchip MPP library.

Signed-off-by: ayaka <ayaka@soulik.info>
---
 .../gstreamer/gstreamer1.0-rockchip.inc            | 32 ++++++++++++++++++++++
 .../gstreamer/gstreamer1.0-rockchip_20170516.bb    |  9 ++++++
 .../gstreamer/gstreamer1.0-rockchip_git.bb         | 13 +++++++++
 3 files changed, 54 insertions(+)
 create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
 create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170516.bb
 create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb

diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
new file mode 100644
index 0000000..fd8fc98
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
@@ -0,0 +1,32 @@
+# Copyright (C) 2016 - 2017 Randy Li <ayaka@soulik.info>
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+
+require recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
+
+DESCRIPTION = "GStreamer 1.0 plugins for Rockchip platforms"
+
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=6d1e4aa87f6192354d3de840cf774d93"
+DEPENDS += "gstreamer1.0-plugins-base"
+
+inherit gettext autotools pkgconfig
+
+PACKAGECONFIG ??= " \
+    mpp             \
+"
+PACKAGECONFIG[mpp]    = "--enable-rockchipmpp,--disable-rockchipmpp,rockchip-mpp"
+PACKAGECONFIG[vpudec] = "--enable-vpudec,--disable-vpudec,rockchip-vpu"
+PACKAGECONFIG[drm]    = "--enable-drmrockchip,--disable-drmrockchip,libdrm-rockchip"
+
+EXTRA_OECONF += "    \
+    --disable-kms    \
+"
+EXTRA_OECONF_remove = "--disable-gtk-doc"
+
+do_configure[prefuncs] = " delete_pkg_m4_file"
+
+do_configure() {
+    NOCONFIGURE=true ${S}/autogen.sh
+    oe_runconf
+}
diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170516.bb b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170516.bb
new file mode 100644
index 0000000..e3fecaf
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170516.bb
@@ -0,0 +1,9 @@
+# Copyright (C) 2016 - 2017 Randy Li <ayaka@soulik.info>
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+include gstreamer1.0-rockchip.inc
+
+TAG = "release_${PV}"
+SRC_URI = "git://github.com/rockchip-linux/gstreamer-rockchip.git;tag=${TAG};nobranch=1"
+
+S = "${WORKDIR}/git"
diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb
new file mode 100644
index 0000000..bd20121
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb
@@ -0,0 +1,13 @@
+# Copyright (C) 2016 - 2017 Randy Li <ayaka@soulik.info>
+# Released under the GNU GENERAL PUBLIC LICENSE Version 2
+# (see COPYING.GPLv2 for the terms)
+
+DEFAULT_PREFERENCE = "-1"
+
+include gstreamer1.0-rockchip.inc
+
+SRCBRANCH ?= "develop"
+SRCREV = "${AUTOREV}"
+SRC_URI = "git://github.com/rockchip-linux/gstreamer-rockchip.git;branch=develop"
+
+S = "${WORKDIR}/git"
-- 
2.9.4

[PATCH v3 3/3] recipes-multimedia: images: rockchip media image

[ayaka]

A image for debugging the hardware video encoder/decoder.
I also use this image for developing the Gstreamer.

Signed-off-by: ayaka <ayaka@soulik.info>
---
 recipes-multimedia/images/rockchip-media-image.bb | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 recipes-multimedia/images/rockchip-media-image.bb

diff --git a/recipes-multimedia/images/rockchip-media-image.bb b/recipes-multimedia/images/rockchip-media-image.bb
new file mode 100644
index 0000000..ea993c1
--- /dev/null
+++ b/recipes-multimedia/images/rockchip-media-image.bb
@@ -0,0 +1,21 @@
+# Copyright (C) 2017 Randy Li <ayaka@soulik.info>
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+include recipes-core/images/core-image-minimal.bb
+
+LICENSE = "MIT"
+DESCRIPTION = "Multimedia image for Rockchip devices."
+
+IMAGE_FEATURES_append = " package-management ssh-server-dropbear"
+IMAGE_INSTALL_append = " gdbserver gstreamer1.0-rockchip      \
+ gstreamer1.0-meta-base gstreamer1.0-meta-video gstreamer1.0-meta-audio \
+ gstreamer1.0-plugins-good-isomp4 gstreamer1.0-plugins-good-multifile \
+ gstreamer1.0-plugins-good-imagefreeze \
+ gstreamer1.0-plugins-bad-autoconvert  gstreamer1.0-plugins-bad-camerabin2 \
+ gstreamer1.0-plugins-bad-kmssink gstreamer1.0-plugins-bad-rawparse \
+ gstreamer1.0-plugins-bad-videoparsersbad \
+ gstreamer1.0-plugins-bad-mpegtsdemux \
+ gstreamer1.0-meta-debug \
+"
+
+TOOLCHAIN_HOST_TASK += "nativesdk-cmake"
-- 
2.9.4

Re: [meta-rockchip] [PATCH v3 0/3] Add video codec recipes

[Khem Raj]

On Tue, May 16, 2017 at 7:18 AM, ayaka <ayaka@soulik.info> wrote:
> Those packages are the userspace libraries for the Rockchip
> Android video codec driver.
>
> Also a minimal image used for verified the media framework is included.
>

some recipes are pinned with GPL-2.0 and some with other licenses. Usually
metadata is better under MIT, is it intentional ? if not then it would
be good to follow consistent license for metadata

> ayaka (3):
>   recipes-multimedia: add Rockchip MPP library
>   recipes-multimedia: add gstreamer rockchip support
>   recipes-multimedia: images: rockchip media image
>
>  .../gstreamer/gstreamer1.0-rockchip.inc            | 32 ++++++++++++++++++++++
>  .../gstreamer/gstreamer1.0-rockchip_20170516.bb    |  9 ++++++
>  .../gstreamer/gstreamer1.0-rockchip_git.bb         | 13 +++++++++
>  recipes-multimedia/images/rockchip-media-image.bb  | 21 ++++++++++++++
>  recipes-multimedia/rockchip-mpp/rockchip-mpp.inc   | 21 ++++++++++++++
>  .../rockchip-mpp/rockchip-mpp_20170412.bb          |  9 ++++++
>  .../rockchip-mpp/rockchip-mpp_git.bb               | 16 +++++++++++
>  7 files changed, 121 insertions(+)
>  create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
>  create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170516.bb
>  create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb
>  create mode 100644 recipes-multimedia/images/rockchip-media-image.bb
>  create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
>  create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
>  create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb
>
> --
> 2.9.4
>

Re: [meta-rockchip] [PATCH v3 0/3] Add video codec recipes

[ayaka]

On 05/16/2017 10:24 PM, Khem Raj wrote:
> On Tue, May 16, 2017 at 7:18 AM, ayaka <ayaka@soulik.info> wrote:
>> Those packages are the userspace libraries for the Rockchip
>> Android video codec driver.
>>
>> Also a minimal image used for verified the media framework is included.
>>
> some recipes are pinned with GPL-2.0 and some with other licenses. Usually
> metadata is better under MIT, is it intentional ? if not then it would
Yes. I want to keep it from secret as much as possible.
> be good to follow consistent license for metadata
>
>> ayaka (3):
>>    recipes-multimedia: add Rockchip MPP library
>>    recipes-multimedia: add gstreamer rockchip support
>>    recipes-multimedia: images: rockchip media image
>>
>>   .../gstreamer/gstreamer1.0-rockchip.inc            | 32 ++++++++++++++++++++++
>>   .../gstreamer/gstreamer1.0-rockchip_20170516.bb    |  9 ++++++
>>   .../gstreamer/gstreamer1.0-rockchip_git.bb         | 13 +++++++++
>>   recipes-multimedia/images/rockchip-media-image.bb  | 21 ++++++++++++++
>>   recipes-multimedia/rockchip-mpp/rockchip-mpp.inc   | 21 ++++++++++++++
>>   .../rockchip-mpp/rockchip-mpp_20170412.bb          |  9 ++++++
>>   .../rockchip-mpp/rockchip-mpp_git.bb               | 16 +++++++++++
>>   7 files changed, 121 insertions(+)
>>   create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip.inc
>>   create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_20170516.bb
>>   create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-rockchip_git.bb
>>   create mode 100644 recipes-multimedia/images/rockchip-media-image.bb
>>   create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp.inc
>>   create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_20170412.bb
>>   create mode 100644 recipes-multimedia/rockchip-mpp/rockchip-mpp_git.bb
>>
>> --
>> 2.9.4
>>

Re: [PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

[Trevor Woerner]

Randy,

Neither of the issues that were identified in your v2 of this patch were
addressed in this v3. Namely:

1) please use your real name (first, last) in your signed-off-by line
2) please don't create a package from this recipe whose name doesn't include
   the recipe name (i.e. please don't create "rockchip-vpu" from a recipe
   "rockchip-mpp"), suggestions were provided

Aside from the email headers and the version of git used, this patch is
identical to the v2 you submitted.

Best regards,
	Trevor

Re: [PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

[Romain Perier]

Hello,


Le 16/05/2017 à 20:44, Trevor Woerner a écrit :
> Randy,
>
> Neither of the issues that were identified in your v2 of this patch were
> addressed in this v3. Namely:
>
> 1) please use your real name (first, last) in your signed-off-by line
> 2) please don't create a package from this recipe whose name doesn't include
>    the recipe name (i.e. please don't create "rockchip-vpu" from a recipe
>    "rockchip-mpp"), suggestions were provided
>
> Aside from the email headers and the version of git used, this patch is
> identical to the v2 you submitted.
>
> Best regards,
> 	Trevor
+1

And please, include a changelog in your new version, at least in the
cover letter, something like:

Changes in v3:
- Item1 fixed
- Item2 fixed

Changes in v2:
- Item1 fixed
- Item2 fixed


Thanks,
Romain

Re: [PATCH v3 1/3] recipes-multimedia: add Rockchip MPP library

[Ayaka]

從我的 iPad 傳送

> Romain Perier <romain.perier@collabora.com> 於 2017年5月17日 下午2:48 寫道：
> 
> Hello,
> 
> 
>> Le 16/05/2017 à 20:44, Trevor Woerner a écrit :
>> Randy,
>> 
>> Neither of the issues that were identified in your v2 of this patch were
>> addressed in this v3. Namely:
>> 
>> 1) please use your real name (first, last) in your signed-off-by line
>> 2) please don't create a package from this recipe whose name doesn't include
>>   the recipe name (i.e. please don't create "rockchip-vpu" from a recipe
>>   "rockchip-mpp"), suggestions were provided
It is a isolated library. I would suggest a new library named rockchip-mpp-vpu.
>> 
>> Aside from the email headers and the version of git used, this patch is
>> identical to the v2 you submitted.
>> 
>> Best regards,
>>    Trevor
> +1
> 
> And please, include a changelog in your new version, at least in the
> cover letter, something like:
> 
> Changes in v3:
> - Item1 fixed
> - Item2 fixed
> 
> Changes in v2:
> - Item1 fixed
> - Item2 fixed
> 
> 
> Thanks,
> Romain