From: Liviu Dudau <Liviu.Dudau@arm.com> To: Boris Brezillon <boris.brezillon@free-electrons.com> Cc: "Daniel Vetter" <daniel.vetter@intel.com>, "Jani Nikula" <jani.nikula@linux.intel.com>, "Brian Starkey" <brian.starkey@arm.com>, "Sean Paul" <seanpaul@chromium.org>, "DRI devel" <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>, "Ville Syrjälä" <ville.syrjala@linux.intel.com>, "Eric Anholt" <eric@anholt.net> Subject: Re: [PATCH v5 0/2] drm: Introduce writeback connectors Date: Tue, 23 May 2017 15:38:42 +0100 [thread overview] Message-ID: <20170523143842.GA7799@e110455-lin.cambridge.arm.com> (raw) In-Reply-To: <20170523163355.45756354@bbrezillon> On Tue, May 23, 2017 at 04:33:55PM +0200, Boris Brezillon wrote: > Hi Liviu, Hi Boris, > > On Mon, 15 May 2017 18:20:55 +0100 > Liviu Dudau <Liviu.Dudau@arm.com> wrote: > > > Hi, > > > > This is v5 of the writeback connector series. Boris Brezillon thought > > that having to explicitly instantiate an encoder when using drm_writeback_connector > > is a bit too cumbersome, so I'm pushing out this version where we embed > > a virtual encoder inside drm_writeback_connector in order to satisfy the > > DRM framework. The caller of drm_writeback_connector_init() can control > > the embedded encoder by passing the drm_encoder_helper_funcs to be used. > > > > Comments are welcome on the suitability of this series. > > Whole series is: > > Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> > Tested-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > Note that I tested it with the kms_writeback igt tests (available in > your branch [1]). Thanks a lot! Now that you seem to be happy with the series (right?) I'll try to push the kms_writeback tests into igt and get this series accepted. Best regards, Liviu > > I'll post the VC4 changes soon. > > Thanks, > > Boris > > > > > Best regards, > > Liviu > > > > Brian Starkey (2): > > drm: Add writeback connector type > > drm: writeback: Add out-fences for writeback connectors > > > > Documentation/gpu/drm-kms.rst | 9 + > > drivers/gpu/drm/Makefile | 2 +- > > drivers/gpu/drm/drm_atomic.c | 229 ++++++++++++++++++++++- > > drivers/gpu/drm/drm_atomic_helper.c | 6 + > > drivers/gpu/drm/drm_connector.c | 4 +- > > drivers/gpu/drm/drm_writeback.c | 362 ++++++++++++++++++++++++++++++++++++ > > include/drm/drm_atomic.h | 11 ++ > > include/drm/drm_connector.h | 13 ++ > > include/drm/drm_mode_config.h | 22 +++ > > include/drm/drm_writeback.h | 127 +++++++++++++ > > include/uapi/drm/drm_mode.h | 1 + > > 11 files changed, 775 insertions(+), 11 deletions(-) > > create mode 100644 drivers/gpu/drm/drm_writeback.c > > create mode 100644 include/drm/drm_writeback.h > > > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
WARNING: multiple messages have this Message-ID (diff)
From: Liviu Dudau <Liviu.Dudau@arm.com> To: Boris Brezillon <boris.brezillon@free-electrons.com> Cc: LKML <linux-kernel@vger.kernel.org>, DRI devel <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH v5 0/2] drm: Introduce writeback connectors Date: Tue, 23 May 2017 15:38:42 +0100 [thread overview] Message-ID: <20170523143842.GA7799@e110455-lin.cambridge.arm.com> (raw) In-Reply-To: <20170523163355.45756354@bbrezillon> On Tue, May 23, 2017 at 04:33:55PM +0200, Boris Brezillon wrote: > Hi Liviu, Hi Boris, > > On Mon, 15 May 2017 18:20:55 +0100 > Liviu Dudau <Liviu.Dudau@arm.com> wrote: > > > Hi, > > > > This is v5 of the writeback connector series. Boris Brezillon thought > > that having to explicitly instantiate an encoder when using drm_writeback_connector > > is a bit too cumbersome, so I'm pushing out this version where we embed > > a virtual encoder inside drm_writeback_connector in order to satisfy the > > DRM framework. The caller of drm_writeback_connector_init() can control > > the embedded encoder by passing the drm_encoder_helper_funcs to be used. > > > > Comments are welcome on the suitability of this series. > > Whole series is: > > Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> > Tested-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > Note that I tested it with the kms_writeback igt tests (available in > your branch [1]). Thanks a lot! Now that you seem to be happy with the series (right?) I'll try to push the kms_writeback tests into igt and get this series accepted. Best regards, Liviu > > I'll post the VC4 changes soon. > > Thanks, > > Boris > > > > > Best regards, > > Liviu > > > > Brian Starkey (2): > > drm: Add writeback connector type > > drm: writeback: Add out-fences for writeback connectors > > > > Documentation/gpu/drm-kms.rst | 9 + > > drivers/gpu/drm/Makefile | 2 +- > > drivers/gpu/drm/drm_atomic.c | 229 ++++++++++++++++++++++- > > drivers/gpu/drm/drm_atomic_helper.c | 6 + > > drivers/gpu/drm/drm_connector.c | 4 +- > > drivers/gpu/drm/drm_writeback.c | 362 ++++++++++++++++++++++++++++++++++++ > > include/drm/drm_atomic.h | 11 ++ > > include/drm/drm_connector.h | 13 ++ > > include/drm/drm_mode_config.h | 22 +++ > > include/drm/drm_writeback.h | 127 +++++++++++++ > > include/uapi/drm/drm_mode.h | 1 + > > 11 files changed, 775 insertions(+), 11 deletions(-) > > create mode 100644 drivers/gpu/drm/drm_writeback.c > > create mode 100644 include/drm/drm_writeback.h > > > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-05-23 14:38 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-15 17:20 [PATCH v5 0/2] drm: Introduce writeback connectors Liviu Dudau 2017-05-15 17:20 ` Liviu Dudau 2017-05-15 17:20 ` [PATCH v5 1/2] drm: Add writeback connector type Liviu Dudau 2017-05-15 17:20 ` Liviu Dudau 2017-05-16 0:30 ` Rob Clark 2017-05-16 0:30 ` Rob Clark 2017-05-16 8:08 ` Liviu Dudau 2017-05-16 8:08 ` Liviu Dudau 2017-05-15 17:20 ` [PATCH v5 2/2] drm: writeback: Add out-fences for writeback connectors Liviu Dudau 2017-05-15 17:20 ` Liviu Dudau 2017-05-23 14:33 ` [PATCH v5 0/2] drm: Introduce " Boris Brezillon 2017-05-23 14:38 ` Liviu Dudau [this message] 2017-05-23 14:38 ` Liviu Dudau 2017-05-23 15:16 ` Boris Brezillon 2017-05-23 15:16 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170523143842.GA7799@e110455-lin.cambridge.arm.com \ --to=liviu.dudau@arm.com \ --cc=boris.brezillon@free-electrons.com \ --cc=brian.starkey@arm.com \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@anholt.net \ --cc=jani.nikula@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=seanpaul@chromium.org \ --cc=ville.syrjala@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.