[Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory

[Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory

[Romain Naour]

dhcp.mk try to create dhcp.conf in a non-existant directory.

Fixes:
http://autobuild.buildroot.net/results/40e/40e48f74b586ce380766cf31473932e43090671e

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/dhcp/dhcp.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
index 4d2cb06..45cae08 100644
--- a/package/dhcp/dhcp.mk
+++ b/package/dhcp/dhcp.mk
@@ -102,6 +102,7 @@ define DHCP_INSTALL_INIT_SYSTEMD
 	ln -sf ../../../../usr/lib/systemd/system/dhcpd.service \
 		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/dhcpd.service
 
+	mkdir -p $(TARGET_DIR)/usr/lib/tmpfiles.d
 	echo "d /var/lib/dhcp 0755 - - - -" > \
 		$(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
 	echo "f /var/lib/dhcp/dhcpd.leases - - - - -" >> \
-- 
2.9.4

[Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used

[Romain Naour]

tmpfile support is optional in systemd but the dhcp server install it's
config file in $(TARGET_DIR)/usr/lib/tmpfiles.d directory when systemd
is used as init system.

So it seems that dhcp server require tmpfile support for systemd based
system.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/dhcp/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
index d09256a..5340830 100644
--- a/package/dhcp/Config.in
+++ b/package/dhcp/Config.in
@@ -12,6 +12,7 @@ if BR2_PACKAGE_DHCP
 
 config BR2_PACKAGE_DHCP_SERVER
 	bool "dhcp server"
+	select BR2_PACKAGE_SYSTEMD_TMPFILES if BR2_PACKAGE_SYSTEMD
 	help
 	  DHCP server from the ISC DHCP distribution.
 
-- 
2.9.4

[Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory

[Bernd Kuhls]

Am Sat, 27 May 2017 00:13:47 +0200 schrieb Romain Naour:

> dhcp.mk try to create dhcp.conf in a non-existant directory.
> 
> Fixes:
> http://autobuild.buildroot.net/
results/40e/40e48f74b586ce380766cf31473932e43090671e
> 
> Signed-off-by: Romain Naour
> <romain.naour@gmail.com> ---
>  package/dhcp/dhcp.mk | 1 +
>  1 file changed, 1 insertion(+)

Tested-by: Bernd Kuhls <bernd.kuhls@t-online.de>
(compile tested)

[Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory

[Thomas Petazzoni]

Hello,

On Sat, 27 May 2017 00:13:47 +0200, Romain Naour wrote:
> dhcp.mk try to create dhcp.conf in a non-existant directory.
> 
> Fixes:
> http://autobuild.buildroot.net/results/40e/40e48f74b586ce380766cf31473932e43090671e
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/dhcp/dhcp.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory

[Peter Korsgaard]

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > dhcp.mk try to create dhcp.conf in a non-existant directory.
 > Fixes:
 > http://autobuild.buildroot.net/results/40e/40e48f74b586ce380766cf31473932e43090671e

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used

[Thomas Petazzoni]

Hello,

On Sat, 27 May 2017 00:13:48 +0200, Romain Naour wrote:
> tmpfile support is optional in systemd but the dhcp server install it's
> config file in $(TARGET_DIR)/usr/lib/tmpfiles.d directory when systemd
> is used as init system.
> 
> So it seems that dhcp server require tmpfile support for systemd based
> system.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/dhcp/Config.in | 1 +
>  1 file changed, 1 insertion(+)

I'm not a big expert in systemd stuff, but nobody else complained for
almost a month, so I've applied your patch. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Sat, 27 May 2017 00:13:48 +0200, Romain Naour wrote:
 >> tmpfile support is optional in systemd but the dhcp server install it's
 >> config file in $(TARGET_DIR)/usr/lib/tmpfiles.d directory when systemd
 >> is used as init system.
 >> 
 >> So it seems that dhcp server require tmpfile support for systemd based
 >> system.
 >> 
 >> Signed-off-by: Romain Naour <romain.naour@gmail.com>
 >> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
 >> ---
 >> package/dhcp/Config.in | 1 +
 >> 1 file changed, 1 insertion(+)

 > I'm not a big expert in systemd stuff, but nobody else complained for
 > almost a month, so I've applied your patch. Thanks!

Committed to 2017.02.x and 2017.05.x, thanks.

-- 
Bye, Peter Korsgaard