* [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory
@ 2017-05-26 22:13 Romain Naour
2017-05-26 22:13 ` [Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used Romain Naour
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Romain Naour @ 2017-05-26 22:13 UTC (permalink / raw)
To: buildroot
dhcp.mk try to create dhcp.conf in a non-existant directory.
Fixes:
http://autobuild.buildroot.net/results/40e/40e48f74b586ce380766cf31473932e43090671e
Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
package/dhcp/dhcp.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/dhcp/dhcp.mk b/package/dhcp/dhcp.mk
index 4d2cb06..45cae08 100644
--- a/package/dhcp/dhcp.mk
+++ b/package/dhcp/dhcp.mk
@@ -102,6 +102,7 @@ define DHCP_INSTALL_INIT_SYSTEMD
ln -sf ../../../../usr/lib/systemd/system/dhcpd.service \
$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/dhcpd.service
+ mkdir -p $(TARGET_DIR)/usr/lib/tmpfiles.d
echo "d /var/lib/dhcp 0755 - - - -" > \
$(TARGET_DIR)/usr/lib/tmpfiles.d/dhcpd.conf
echo "f /var/lib/dhcp/dhcpd.leases - - - - -" >> \
--
2.9.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used
2017-05-26 22:13 [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory Romain Naour
@ 2017-05-26 22:13 ` Romain Naour
2017-06-24 21:28 ` Thomas Petazzoni
2017-05-27 7:45 ` [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory Bernd Kuhls
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Romain Naour @ 2017-05-26 22:13 UTC (permalink / raw)
To: buildroot
tmpfile support is optional in systemd but the dhcp server install it's
config file in $(TARGET_DIR)/usr/lib/tmpfiles.d directory when systemd
is used as init system.
So it seems that dhcp server require tmpfile support for systemd based
system.
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/dhcp/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/dhcp/Config.in b/package/dhcp/Config.in
index d09256a..5340830 100644
--- a/package/dhcp/Config.in
+++ b/package/dhcp/Config.in
@@ -12,6 +12,7 @@ if BR2_PACKAGE_DHCP
config BR2_PACKAGE_DHCP_SERVER
bool "dhcp server"
+ select BR2_PACKAGE_SYSTEMD_TMPFILES if BR2_PACKAGE_SYSTEMD
help
DHCP server from the ISC DHCP distribution.
--
2.9.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used
2017-05-26 22:13 ` [Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used Romain Naour
@ 2017-06-24 21:28 ` Thomas Petazzoni
2017-06-26 20:24 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2017-06-24 21:28 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 27 May 2017 00:13:48 +0200, Romain Naour wrote:
> tmpfile support is optional in systemd but the dhcp server install it's
> config file in $(TARGET_DIR)/usr/lib/tmpfiles.d directory when systemd
> is used as init system.
>
> So it seems that dhcp server require tmpfile support for systemd based
> system.
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/dhcp/Config.in | 1 +
> 1 file changed, 1 insertion(+)
I'm not a big expert in systemd stuff, but nobody else complained for
almost a month, so I've applied your patch. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used
2017-06-24 21:28 ` Thomas Petazzoni
@ 2017-06-26 20:24 ` Peter Korsgaard
0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2017-06-26 20:24 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Hello,
> On Sat, 27 May 2017 00:13:48 +0200, Romain Naour wrote:
>> tmpfile support is optional in systemd but the dhcp server install it's
>> config file in $(TARGET_DIR)/usr/lib/tmpfiles.d directory when systemd
>> is used as init system.
>>
>> So it seems that dhcp server require tmpfile support for systemd based
>> system.
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>> package/dhcp/Config.in | 1 +
>> 1 file changed, 1 insertion(+)
> I'm not a big expert in systemd stuff, but nobody else complained for
> almost a month, so I've applied your patch. Thanks!
Committed to 2017.02.x and 2017.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory
2017-05-26 22:13 [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory Romain Naour
2017-05-26 22:13 ` [Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used Romain Naour
@ 2017-05-27 7:45 ` Bernd Kuhls
2017-05-27 15:18 ` Thomas Petazzoni
2017-06-01 14:19 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Bernd Kuhls @ 2017-05-27 7:45 UTC (permalink / raw)
To: buildroot
Am Sat, 27 May 2017 00:13:47 +0200 schrieb Romain Naour:
> dhcp.mk try to create dhcp.conf in a non-existant directory.
>
> Fixes:
> http://autobuild.buildroot.net/
results/40e/40e48f74b586ce380766cf31473932e43090671e
>
> Signed-off-by: Romain Naour
> <romain.naour@gmail.com> ---
> package/dhcp/dhcp.mk | 1 +
> 1 file changed, 1 insertion(+)
Tested-by: Bernd Kuhls <bernd.kuhls@t-online.de>
(compile tested)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory
2017-05-26 22:13 [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory Romain Naour
2017-05-26 22:13 ` [Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used Romain Naour
2017-05-27 7:45 ` [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory Bernd Kuhls
@ 2017-05-27 15:18 ` Thomas Petazzoni
2017-06-01 14:19 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2017-05-27 15:18 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 27 May 2017 00:13:47 +0200, Romain Naour wrote:
> dhcp.mk try to create dhcp.conf in a non-existant directory.
>
> Fixes:
> http://autobuild.buildroot.net/results/40e/40e48f74b586ce380766cf31473932e43090671e
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> package/dhcp/dhcp.mk | 1 +
> 1 file changed, 1 insertion(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory
2017-05-26 22:13 [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory Romain Naour
` (2 preceding siblings ...)
2017-05-27 15:18 ` Thomas Petazzoni
@ 2017-06-01 14:19 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2017-06-01 14:19 UTC (permalink / raw)
To: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> dhcp.mk try to create dhcp.conf in a non-existant directory.
> Fixes:
> http://autobuild.buildroot.net/results/40e/40e48f74b586ce380766cf31473932e43090671e
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
Committed to 2017.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-06-26 20:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-26 22:13 [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory Romain Naour
2017-05-26 22:13 ` [Buildroot] [PATCH 2/2] package/dhcp: dhcp server: select systemd tmpfile support when systemd is used Romain Naour
2017-06-24 21:28 ` Thomas Petazzoni
2017-06-26 20:24 ` Peter Korsgaard
2017-05-27 7:45 ` [Buildroot] [PATCH 1/2] package/dhcp: create tmpfiles.d directory Bernd Kuhls
2017-05-27 15:18 ` Thomas Petazzoni
2017-06-01 14:19 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.