All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rakesh Pandit <rakesh@tuxera.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	Keith Busch <keith.busch@intel.com>,
	Christoph Hellwig <hch@lst.de>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	<linux-nvme@lists.infradead.org>, <linux-block@vger.kernel.org>
Subject: Re: [PATCH] nvme: fix hang in remove path
Date: Mon, 5 Jun 2017 11:47:33 +0300	[thread overview]
Message-ID: <20170605084732.GA30881@dhcp-216.srv.tuxera.com> (raw)
In-Reply-To: <20170605084434.GA30864@dhcp-216.srv.tuxera.com>

On Mon, Jun 05, 2017 at 11:44:34AM +0300, Rakesh Pandit wrote:
> On Sun, Jun 04, 2017 at 06:24:09PM +0300, Sagi Grimberg wrote:
> > 
> > > It would make sense to still add:
> > > 
> > > if (ctrl->state == NVME_CTRL_DELETING || ctrl->state == NVME_CTRL_DEAD)
> > > 	return
> > > 
> > > inside nvme_configure_apst at the top irrespective of this change.
> > 
> > I'm not sure what is the value given that it is taken care of in
> > .queue_rq?
> 
> We would avoid getting error message which says: "failed to set APST
> feature 7".  Why an error if controller is already under reset.

I meant deletion.  Of course not a huge value but worth a fix IMHO
while we are at it.

> 
> Note 7 here is NVME_SC_ABORT_REQ.  Also we would avoid walking through
> all power states inside the nvme_configure_apst as
> nvme_set_latency_tolerance was called with value
> PM_QOS_LATENCY_TOLERANCE_NO_CONSTRAINT (-1) which sets
> ctrl->ps_max_latency_us to U64_MAX and tries to send a sync command
> which of course fails with error message.

WARNING: multiple messages have this Message-ID (diff)
From: rakesh@tuxera.com (Rakesh Pandit)
Subject: [PATCH] nvme: fix hang in remove path
Date: Mon, 5 Jun 2017 11:47:33 +0300	[thread overview]
Message-ID: <20170605084732.GA30881@dhcp-216.srv.tuxera.com> (raw)
In-Reply-To: <20170605084434.GA30864@dhcp-216.srv.tuxera.com>

On Mon, Jun 05, 2017@11:44:34AM +0300, Rakesh Pandit wrote:
> On Sun, Jun 04, 2017@06:24:09PM +0300, Sagi Grimberg wrote:
> > 
> > > It would make sense to still add:
> > > 
> > > if (ctrl->state == NVME_CTRL_DELETING || ctrl->state == NVME_CTRL_DEAD)
> > > 	return
> > > 
> > > inside nvme_configure_apst at the top irrespective of this change.
> > 
> > I'm not sure what is the value given that it is taken care of in
> > .queue_rq?
> 
> We would avoid getting error message which says: "failed to set APST
> feature 7".  Why an error if controller is already under reset.

I meant deletion.  Of course not a huge value but worth a fix IMHO
while we are at it.

> 
> Note 7 here is NVME_SC_ABORT_REQ.  Also we would avoid walking through
> all power states inside the nvme_configure_apst as
> nvme_set_latency_tolerance was called with value
> PM_QOS_LATENCY_TOLERANCE_NO_CONSTRAINT (-1) which sets
> ctrl->ps_max_latency_us to U64_MAX and tries to send a sync command
> which of course fails with error message.

  reply	other threads:[~2017-06-05  8:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02  8:32 [PATCH] nvme: fix hang in remove path Ming Lei
2017-06-02  8:32 ` Ming Lei
2017-06-02 13:36 ` Sagi Grimberg
2017-06-02 13:36   ` Sagi Grimberg
2017-06-02 18:04 ` Rakesh Pandit
2017-06-02 18:04   ` Rakesh Pandit
2017-06-04 15:24   ` Sagi Grimberg
2017-06-04 15:24     ` Sagi Grimberg
2017-06-05  8:44     ` Rakesh Pandit
2017-06-05  8:44       ` Rakesh Pandit
2017-06-05  8:47       ` Rakesh Pandit [this message]
2017-06-05  8:47         ` Rakesh Pandit
2017-06-05 19:45         ` Rakesh Pandit
2017-06-05 19:45           ` Rakesh Pandit
2017-06-06  7:10           ` Sagi Grimberg
2017-06-06  7:10             ` Sagi Grimberg
2017-06-06  7:12             ` Christoph Hellwig
2017-06-06  7:12               ` Christoph Hellwig
2017-06-06  7:30               ` Rakesh Pandit
2017-06-06  7:30                 ` Rakesh Pandit
2017-06-05  8:20 ` Christoph Hellwig
2017-06-05  8:20   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170605084732.GA30881@dhcp-216.srv.tuxera.com \
    --to=rakesh@tuxera.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.