From: Sagi Grimberg <sagi@grimberg.me>
To: Rakesh Pandit <rakesh@tuxera.com>, Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] nvme: fix hang in remove path
Date: Sun, 4 Jun 2017 18:24:09 +0300 [thread overview]
Message-ID: <244bc065-92eb-c3e0-faa7-11569fc326d6@grimberg.me> (raw)
In-Reply-To: <20170602180435.GA23335@dhcp-216.srv.tuxera.com>
> It would make sense to still add:
>
> if (ctrl->state == NVME_CTRL_DELETING || ctrl->state == NVME_CTRL_DEAD)
> return
>
> inside nvme_configure_apst at the top irrespective of this change.
I'm not sure what is the value given that it is taken care of in
.queue_rq?
WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] nvme: fix hang in remove path
Date: Sun, 4 Jun 2017 18:24:09 +0300 [thread overview]
Message-ID: <244bc065-92eb-c3e0-faa7-11569fc326d6@grimberg.me> (raw)
In-Reply-To: <20170602180435.GA23335@dhcp-216.srv.tuxera.com>
> It would make sense to still add:
>
> if (ctrl->state == NVME_CTRL_DELETING || ctrl->state == NVME_CTRL_DEAD)
> return
>
> inside nvme_configure_apst at the top irrespective of this change.
I'm not sure what is the value given that it is taken care of in
.queue_rq?
next prev parent reply other threads:[~2017-06-04 15:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 8:32 [PATCH] nvme: fix hang in remove path Ming Lei
2017-06-02 8:32 ` Ming Lei
2017-06-02 13:36 ` Sagi Grimberg
2017-06-02 13:36 ` Sagi Grimberg
2017-06-02 18:04 ` Rakesh Pandit
2017-06-02 18:04 ` Rakesh Pandit
2017-06-04 15:24 ` Sagi Grimberg [this message]
2017-06-04 15:24 ` Sagi Grimberg
2017-06-05 8:44 ` Rakesh Pandit
2017-06-05 8:44 ` Rakesh Pandit
2017-06-05 8:47 ` Rakesh Pandit
2017-06-05 8:47 ` Rakesh Pandit
2017-06-05 19:45 ` Rakesh Pandit
2017-06-05 19:45 ` Rakesh Pandit
2017-06-06 7:10 ` Sagi Grimberg
2017-06-06 7:10 ` Sagi Grimberg
2017-06-06 7:12 ` Christoph Hellwig
2017-06-06 7:12 ` Christoph Hellwig
2017-06-06 7:30 ` Rakesh Pandit
2017-06-06 7:30 ` Rakesh Pandit
2017-06-05 8:20 ` Christoph Hellwig
2017-06-05 8:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=244bc065-92eb-c3e0-faa7-11569fc326d6@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=rakesh@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.