* [meta-oe][V2 patch] rrdtool: allow configuration to disable nls @ 2017-05-18 2:07 Randy MacLeod 2017-05-29 1:12 ` Randy MacLeod 2017-06-15 23:47 ` [meta-oe][PATCH v2] " Randy MacLeod 0 siblings, 2 replies; 6+ messages in thread From: Randy MacLeod @ 2017-05-18 2:07 UTC (permalink / raw) To: openembedded-devel When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error: autoreconf: failed to run autopoint: No such file or directory Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it. Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support. Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> --- meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb index db2df28a0..3ccefb995 100644 --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb @@ -22,7 +22,7 @@ BBCLASSEXTEND = "native" SYSTEMD_PACKAGES = "rrdcached" SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service" -EXTRA_AUTORECONF = "-I m4" +EXTRA_AUTORECONF = "-I m4 --exclude=autopoint" PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}" @@ -49,6 +49,7 @@ EXTRA_OECONF = " \ --disable-lua \ --disable-tcl \ --disable-rpath \ + --enable-nls=${USE_NLS} \ " export STAGING_LIBDIR -- 2.11.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-oe][V2 patch] rrdtool: allow configuration to disable nls 2017-05-18 2:07 [meta-oe][V2 patch] rrdtool: allow configuration to disable nls Randy MacLeod @ 2017-05-29 1:12 ` Randy MacLeod 2017-05-29 1:14 ` Randy MacLeod 2017-06-15 23:47 ` [meta-oe][PATCH v2] " Randy MacLeod 1 sibling, 1 reply; 6+ messages in thread From: Randy MacLeod @ 2017-05-29 1:12 UTC (permalink / raw) To: openembedded-devel, Martin Jansa Martin, You've merged v1: [oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency Could you drop that for this fix since it's a somewhat better approach. ../Randy On 2017-05-17 10:07 PM, Randy MacLeod wrote: > When building rrdtool for a 'tiny' distro, that does not have native > language support (NLS) in glibc, configure fails with the error: > autoreconf: failed to run autopoint: No such file or directory > Autopoint is part of gettext but without NLS support we populate the > sysroot with gettext-minimal-native rather then the full set of > gettext executables. This version does not install autopoint, nor > should it. > > Tell autoreconf to skip the check for the autopoint script > regardless of NLS support and use the USE_NLS varible > to conditionally enable NLS support. > > Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> > --- > meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb > index db2df28a0..3ccefb995 100644 > --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb > +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb > @@ -22,7 +22,7 @@ BBCLASSEXTEND = "native" > SYSTEMD_PACKAGES = "rrdcached" > SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service" > > -EXTRA_AUTORECONF = "-I m4" > +EXTRA_AUTORECONF = "-I m4 --exclude=autopoint" > > PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}" > > @@ -49,6 +49,7 @@ EXTRA_OECONF = " \ > --disable-lua \ > --disable-tcl \ > --disable-rpath \ > + --enable-nls=${USE_NLS} \ > " > > export STAGING_LIBDIR > -- # Randy MacLeod. SMTS, Linux, Wind River Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][V2 patch] rrdtool: allow configuration to disable nls 2017-05-29 1:12 ` Randy MacLeod @ 2017-05-29 1:14 ` Randy MacLeod 2017-06-05 11:14 ` Martin Jansa 0 siblings, 1 reply; 6+ messages in thread From: Randy MacLeod @ 2017-05-29 1:14 UTC (permalink / raw) To: openembedded-devel, Martin Jansa On 2017-05-28 09:12 PM, Randy MacLeod wrote: > > Martin, > > You've merged v1: > [oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency err I mean, you've merged v1 to master-next to be clear. ../Randy > Could you drop that for this fix since it's a somewhat better approach. > > ../Randy > > On 2017-05-17 10:07 PM, Randy MacLeod wrote: >> When building rrdtool for a 'tiny' distro, that does not have native >> language support (NLS) in glibc, configure fails with the error: >> autoreconf: failed to run autopoint: No such file or directory >> Autopoint is part of gettext but without NLS support we populate the >> sysroot with gettext-minimal-native rather then the full set of >> gettext executables. This version does not install autopoint, nor >> should it. >> >> Tell autoreconf to skip the check for the autopoint script >> regardless of NLS support and use the USE_NLS varible >> to conditionally enable NLS support. >> >> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> >> --- >> meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >> b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >> index db2df28a0..3ccefb995 100644 >> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >> @@ -22,7 +22,7 @@ BBCLASSEXTEND = "native" >> SYSTEMD_PACKAGES = "rrdcached" >> SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service" >> -EXTRA_AUTORECONF = "-I m4" >> +EXTRA_AUTORECONF = "-I m4 --exclude=autopoint" >> PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', >> 'systemd', d)}" >> @@ -49,6 +49,7 @@ EXTRA_OECONF = " \ >> --disable-lua \ >> --disable-tcl \ >> --disable-rpath \ >> + --enable-nls=${USE_NLS} \ >> " >> export STAGING_LIBDIR >> > > -- # Randy MacLeod. SMTS, Linux, Wind River Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][V2 patch] rrdtool: allow configuration to disable nls 2017-05-29 1:14 ` Randy MacLeod @ 2017-06-05 11:14 ` Martin Jansa 2017-06-05 14:02 ` Jose Lamego 0 siblings, 1 reply; 6+ messages in thread From: Martin Jansa @ 2017-06-05 11:14 UTC (permalink / raw) To: Randy MacLeod; +Cc: openembedded-devel This v2 didn't make it to patchwork and it was too late when I've noticed it and found this e-mail. So I've merged v1 to master and immediately reverted it. Resend v2 again, this time patchwork might do its job. On Mon, May 29, 2017 at 3:14 AM, Randy MacLeod <randy.macleod@windriver.com> wrote: > On 2017-05-28 09:12 PM, Randy MacLeod wrote: > >> >> Martin, >> >> You've merged v1: >> [oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency >> > > err I mean, you've merged v1 to master-next to be clear. > ../Randy > > > Could you drop that for this fix since it's a somewhat better approach. >> >> ../Randy >> >> On 2017-05-17 10:07 PM, Randy MacLeod wrote: >> >>> When building rrdtool for a 'tiny' distro, that does not have native >>> language support (NLS) in glibc, configure fails with the error: >>> autoreconf: failed to run autopoint: No such file or directory >>> Autopoint is part of gettext but without NLS support we populate the >>> sysroot with gettext-minimal-native rather then the full set of >>> gettext executables. This version does not install autopoint, nor >>> should it. >>> >>> Tell autoreconf to skip the check for the autopoint script >>> regardless of NLS support and use the USE_NLS varible >>> to conditionally enable NLS support. >>> >>> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> >>> --- >>> meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >>> b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >>> index db2df28a0..3ccefb995 100644 >>> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >>> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >>> @@ -22,7 +22,7 @@ BBCLASSEXTEND = "native" >>> SYSTEMD_PACKAGES = "rrdcached" >>> SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service" >>> -EXTRA_AUTORECONF = "-I m4" >>> +EXTRA_AUTORECONF = "-I m4 --exclude=autopoint" >>> PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', >>> 'systemd', d)}" >>> @@ -49,6 +49,7 @@ EXTRA_OECONF = " \ >>> --disable-lua \ >>> --disable-tcl \ >>> --disable-rpath \ >>> + --enable-nls=${USE_NLS} \ >>> " >>> export STAGING_LIBDIR >>> >>> >> >> > > -- > # Randy MacLeod. SMTS, Linux, Wind River > Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, > Canada, K2K 2W5 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][V2 patch] rrdtool: allow configuration to disable nls 2017-06-05 11:14 ` Martin Jansa @ 2017-06-05 14:02 ` Jose Lamego 0 siblings, 0 replies; 6+ messages in thread From: Jose Lamego @ 2017-06-05 14:02 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1.1: Type: text/plain, Size: 3332 bytes --] On 06/05/2017 06:14 AM, Martin Jansa wrote: > This v2 didn't make it to patchwork and it was too late when I've noticed > it and found this e-mail. > > So I've merged v1 to master and immediately reverted it. > > Resend v2 again, this time patchwork might do its job. Randy, to ensure patchwork to identify your patch as such, please use the appropriate prefix (you may use --subject-prefix="meta-oe][PATCH v2" when creating your patch) as described in http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded optionally, you can also include --in-reply-to=20170518020701.2773-1-Randy.MacLeod@windriver.com which adds your first patch's message id as reference in patch v2, ensuring patchwork to display it as revision 2 of the series. This is only required in cases where the patch name changes between revisions to keep thread continuity. Regards > > On Mon, May 29, 2017 at 3:14 AM, Randy MacLeod <randy.macleod@windriver.com> > wrote: > >> On 2017-05-28 09:12 PM, Randy MacLeod wrote: >> >>> >>> Martin, >>> >>> You've merged v1: >>> [oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency >>> >> >> err I mean, you've merged v1 to master-next to be clear. >> ../Randy >> >> >> Could you drop that for this fix since it's a somewhat better approach. >>> >>> ../Randy >>> >>> On 2017-05-17 10:07 PM, Randy MacLeod wrote: >>> >>>> When building rrdtool for a 'tiny' distro, that does not have native >>>> language support (NLS) in glibc, configure fails with the error: >>>> autoreconf: failed to run autopoint: No such file or directory >>>> Autopoint is part of gettext but without NLS support we populate the >>>> sysroot with gettext-minimal-native rather then the full set of >>>> gettext executables. This version does not install autopoint, nor >>>> should it. >>>> >>>> Tell autoreconf to skip the check for the autopoint script >>>> regardless of NLS support and use the USE_NLS varible >>>> to conditionally enable NLS support. >>>> >>>> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> >>>> --- >>>> meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >>>> b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >>>> index db2df28a0..3ccefb995 100644 >>>> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >>>> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb >>>> @@ -22,7 +22,7 @@ BBCLASSEXTEND = "native" >>>> SYSTEMD_PACKAGES = "rrdcached" >>>> SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service" >>>> -EXTRA_AUTORECONF = "-I m4" >>>> +EXTRA_AUTORECONF = "-I m4 --exclude=autopoint" >>>> PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', >>>> 'systemd', d)}" >>>> @@ -49,6 +49,7 @@ EXTRA_OECONF = " \ >>>> --disable-lua \ >>>> --disable-tcl \ >>>> --disable-rpath \ >>>> + --enable-nls=${USE_NLS} \ >>>> " >>>> export STAGING_LIBDIR >>>> >>>> >>> >>> >> >> -- >> # Randy MacLeod. SMTS, Linux, Wind River >> Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, >> Canada, K2K 2W5 >> -- Jose Lamego | OTC Embedded Platforms & Tools | GDC [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 484 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [meta-oe][PATCH v2] rrdtool: allow configuration to disable nls 2017-05-18 2:07 [meta-oe][V2 patch] rrdtool: allow configuration to disable nls Randy MacLeod 2017-05-29 1:12 ` Randy MacLeod @ 2017-06-15 23:47 ` Randy MacLeod 1 sibling, 0 replies; 6+ messages in thread From: Randy MacLeod @ 2017-06-15 23:47 UTC (permalink / raw) To: openembedded-devel When building rrdtool for a 'tiny' distro, that does not have native language support (NLS) in glibc, configure fails with the error: autoreconf: failed to run autopoint: No such file or directory Autopoint is part of gettext but without NLS support we populate the sysroot with gettext-minimal-native rather then the full set of gettext executables. This version does not install autopoint, nor should it. Tell autoreconf to skip the check for the autopoint script regardless of NLS support and use the USE_NLS varible to conditionally enable NLS support. Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> --- meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb index db2df28a0..3ccefb995 100644 --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb @@ -22,7 +22,7 @@ BBCLASSEXTEND = "native" SYSTEMD_PACKAGES = "rrdcached" SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service" -EXTRA_AUTORECONF = "-I m4" +EXTRA_AUTORECONF = "-I m4 --exclude=autopoint" PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}" @@ -49,6 +49,7 @@ EXTRA_OECONF = " \ --disable-lua \ --disable-tcl \ --disable-rpath \ + --enable-nls=${USE_NLS} \ " export STAGING_LIBDIR -- 2.11.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-15 23:55 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-18 2:07 [meta-oe][V2 patch] rrdtool: allow configuration to disable nls Randy MacLeod 2017-05-29 1:12 ` Randy MacLeod 2017-05-29 1:14 ` Randy MacLeod 2017-06-05 11:14 ` Martin Jansa 2017-06-05 14:02 ` Jose Lamego 2017-06-15 23:47 ` [meta-oe][PATCH v2] " Randy MacLeod
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.