From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Keerthy J <j-keerthy@ti.com>
Subject: Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers
Date: Tue, 20 Jun 2017 15:42:43 +0100 [thread overview]
Message-ID: <20170620144243.GB23750@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170519175708.6070-3-d-gerlach@ti.com>
On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
> + .arm
> + .align 3
> +
> +ENTRY(ti_emif_sram)
Will you ever want to have any of this code as Thumb?
> +extern inline void ti_emif_offsets(void)
> +{
"extern inline" is frowned upon in the kernel - any reason this
can't be "static inline" ?
Any reason not to provide a stub for when it's not configured,
and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers
Date: Tue, 20 Jun 2017 15:42:43 +0100 [thread overview]
Message-ID: <20170620144243.GB23750@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170519175708.6070-3-d-gerlach@ti.com>
On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
> + .arm
> + .align 3
> +
> +ENTRY(ti_emif_sram)
Will you ever want to have any of this code as Thumb?
> +extern inline void ti_emif_offsets(void)
> +{
"extern inline" is frowned upon in the kernel - any reason this
can't be "static inline" ?
Any reason not to provide a stub for when it's not configured,
and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-06-20 14:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 17:57 [PATCH v2 0/2] memory: Introduce ti-emif-sram driver Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-19 17:57 ` [PATCH v2 1/2] Documentation: dt: Update ti,emif bindings Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-20 1:45 ` Rob Herring
2017-05-20 1:45 ` Rob Herring
2017-05-20 1:45 ` Rob Herring
2017-05-22 14:53 ` Tony Lindgren
2017-05-22 14:53 ` Tony Lindgren
2017-05-22 14:53 ` Tony Lindgren
2017-05-19 17:57 ` [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-22 14:53 ` Tony Lindgren
2017-05-22 14:53 ` Tony Lindgren
2017-06-20 14:42 ` Russell King - ARM Linux [this message]
2017-06-20 14:42 ` Russell King - ARM Linux
2017-06-20 19:03 ` Dave Gerlach
2017-06-20 19:03 ` Dave Gerlach
2017-06-20 19:03 ` Dave Gerlach
2017-07-03 16:17 ` Johan Hovold
2017-07-03 16:17 ` Johan Hovold
2017-07-03 16:17 ` Johan Hovold
2017-07-06 18:59 ` Dave Gerlach
2017-07-06 18:59 ` Dave Gerlach
2017-07-06 18:59 ` Dave Gerlach
2017-07-10 11:31 ` Johan Hovold
2017-07-10 11:31 ` Johan Hovold
2017-07-10 11:31 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620144243.GB23750@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.