From: Dave Gerlach <d-gerlach@ti.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Rob Herring <robh+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, Keerthy J <j-keerthy@ti.com>
Subject: Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers
Date: Tue, 20 Jun 2017 14:03:35 -0500 [thread overview]
Message-ID: <fdfa1059-17f7-74f7-4b88-2941af07a538@ti.com> (raw)
In-Reply-To: <20170620144243.GB23750@n2100.armlinux.org.uk>
Hi,
On 06/20/2017 09:42 AM, Russell King - ARM Linux wrote:
> On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
>> + .arm
>> + .align 3
>> +
>> +ENTRY(ti_emif_sram)
>
> Will you ever want to have any of this code as Thumb?
I cannot see any requirement for that. I will say it is tested and
inter-operates happily with CONFIG_THUMB_KERNEL, but because it's constrained to
am335x and am437x I don't think there are unknown situations where every single
instruction must be THUMB.
>
>> +extern inline void ti_emif_offsets(void)
>> +{
>
> "extern inline" is frowned upon in the kernel - any reason this
> can't be "static inline" ?
It should be static.
>
> Any reason not to provide a stub for when it's not configured,
> and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
>
No, I just was following the ifdef example set by others in the file, a stub
would be cleaner I agree.
Regards,
Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>
To: Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Santosh Shilimkar
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Keerthy J <j-keerthy-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers
Date: Tue, 20 Jun 2017 14:03:35 -0500 [thread overview]
Message-ID: <fdfa1059-17f7-74f7-4b88-2941af07a538@ti.com> (raw)
In-Reply-To: <20170620144243.GB23750-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
Hi,
On 06/20/2017 09:42 AM, Russell King - ARM Linux wrote:
> On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
>> + .arm
>> + .align 3
>> +
>> +ENTRY(ti_emif_sram)
>
> Will you ever want to have any of this code as Thumb?
I cannot see any requirement for that. I will say it is tested and
inter-operates happily with CONFIG_THUMB_KERNEL, but because it's constrained to
am335x and am437x I don't think there are unknown situations where every single
instruction must be THUMB.
>
>> +extern inline void ti_emif_offsets(void)
>> +{
>
> "extern inline" is frowned upon in the kernel - any reason this
> can't be "static inline" ?
It should be static.
>
> Any reason not to provide a stub for when it's not configured,
> and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
>
No, I just was following the ifdef example set by others in the file, a stub
would be cleaner I agree.
Regards,
Dave
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: d-gerlach@ti.com (Dave Gerlach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers
Date: Tue, 20 Jun 2017 14:03:35 -0500 [thread overview]
Message-ID: <fdfa1059-17f7-74f7-4b88-2941af07a538@ti.com> (raw)
In-Reply-To: <20170620144243.GB23750@n2100.armlinux.org.uk>
Hi,
On 06/20/2017 09:42 AM, Russell King - ARM Linux wrote:
> On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
>> + .arm
>> + .align 3
>> +
>> +ENTRY(ti_emif_sram)
>
> Will you ever want to have any of this code as Thumb?
I cannot see any requirement for that. I will say it is tested and
inter-operates happily with CONFIG_THUMB_KERNEL, but because it's constrained to
am335x and am437x I don't think there are unknown situations where every single
instruction must be THUMB.
>
>> +extern inline void ti_emif_offsets(void)
>> +{
>
> "extern inline" is frowned upon in the kernel - any reason this
> can't be "static inline" ?
It should be static.
>
> Any reason not to provide a stub for when it's not configured,
> and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
>
No, I just was following the ifdef example set by others in the file, a stub
would be cleaner I agree.
Regards,
Dave
next prev parent reply other threads:[~2017-06-20 19:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 17:57 [PATCH v2 0/2] memory: Introduce ti-emif-sram driver Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-19 17:57 ` [PATCH v2 1/2] Documentation: dt: Update ti,emif bindings Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-20 1:45 ` Rob Herring
2017-05-20 1:45 ` Rob Herring
2017-05-20 1:45 ` Rob Herring
2017-05-22 14:53 ` Tony Lindgren
2017-05-22 14:53 ` Tony Lindgren
2017-05-22 14:53 ` Tony Lindgren
2017-05-19 17:57 ` [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-19 17:57 ` Dave Gerlach
2017-05-22 14:53 ` Tony Lindgren
2017-05-22 14:53 ` Tony Lindgren
2017-06-20 14:42 ` Russell King - ARM Linux
2017-06-20 14:42 ` Russell King - ARM Linux
2017-06-20 19:03 ` Dave Gerlach [this message]
2017-06-20 19:03 ` Dave Gerlach
2017-06-20 19:03 ` Dave Gerlach
2017-07-03 16:17 ` Johan Hovold
2017-07-03 16:17 ` Johan Hovold
2017-07-03 16:17 ` Johan Hovold
2017-07-06 18:59 ` Dave Gerlach
2017-07-06 18:59 ` Dave Gerlach
2017-07-06 18:59 ` Dave Gerlach
2017-07-10 11:31 ` Johan Hovold
2017-07-10 11:31 ` Johan Hovold
2017-07-10 11:31 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdfa1059-17f7-74f7-4b88-2941af07a538@ti.com \
--to=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.