From: Christoph Hellwig <hch@infradead.org> To: Jens Axboe <axboe@kernel.dk> Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, adilger@dilger.ca, hch@infradead.org, martin.petersen@oracle.com, linux-nvme@lists.infradead.org Subject: Re: [PATCH 4/9] fs: add O_DIRECT support for sending down write life time hints Date: Mon, 26 Jun 2017 02:55:06 -0700 [thread overview] Message-ID: <20170626095506.GE14057@infradead.org> (raw) In-Reply-To: <1498004526-4543-5-git-send-email-axboe@kernel.dk> > @@ -385,6 +385,8 @@ dio_bio_alloc(struct dio *dio, struct dio_submit *sdio, > else > bio->bi_end_io = dio_bio_end_io; > > + bio->bi_opf |= write_hint_to_opf(iocb_write_hint(dio->iocb)); > + > sdio->bio = bio; > sdio->logical_offset_in_bio = sdio->cur_page_fs_offset; > } > diff --git a/fs/iomap.c b/fs/iomap.c > index c71a64b97fba..9c9f8406018b 100644 > --- a/fs/iomap.c > +++ b/fs/iomap.c > @@ -804,6 +804,7 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length, > > if (dio->flags & IOMAP_DIO_WRITE) { > bio_set_op_attrs(bio, REQ_OP_WRITE, REQ_SYNC | REQ_IDLE); > + bio->bi_opf |= write_hint_to_opf(inode_write_hint(inode)); This should be iocb based as well, otherwise you'll miss out on the per-file hints. Also please don't add a > 80 char line. (And yes, I should fix the one just above, too) > task_io_account_write(bio->bi_iter.bi_size); > } else { > bio_set_op_attrs(bio, REQ_OP_READ, 0); > -- > 2.7.4 > ---end quoted text---
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig) Subject: [PATCH 4/9] fs: add O_DIRECT support for sending down write life time hints Date: Mon, 26 Jun 2017 02:55:06 -0700 [thread overview] Message-ID: <20170626095506.GE14057@infradead.org> (raw) In-Reply-To: <1498004526-4543-5-git-send-email-axboe@kernel.dk> > @@ -385,6 +385,8 @@ dio_bio_alloc(struct dio *dio, struct dio_submit *sdio, > else > bio->bi_end_io = dio_bio_end_io; > > + bio->bi_opf |= write_hint_to_opf(iocb_write_hint(dio->iocb)); > + > sdio->bio = bio; > sdio->logical_offset_in_bio = sdio->cur_page_fs_offset; > } > diff --git a/fs/iomap.c b/fs/iomap.c > index c71a64b97fba..9c9f8406018b 100644 > --- a/fs/iomap.c > +++ b/fs/iomap.c > @@ -804,6 +804,7 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length, > > if (dio->flags & IOMAP_DIO_WRITE) { > bio_set_op_attrs(bio, REQ_OP_WRITE, REQ_SYNC | REQ_IDLE); > + bio->bi_opf |= write_hint_to_opf(inode_write_hint(inode)); This should be iocb based as well, otherwise you'll miss out on the per-file hints. Also please don't add a > 80 char line. (And yes, I should fix the one just above, too) > task_io_account_write(bio->bi_iter.bi_size); > } else { > bio_set_op_attrs(bio, REQ_OP_READ, 0); > -- > 2.7.4 > ---end quoted text---
next prev parent reply other threads:[~2017-06-26 9:55 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-21 0:21 [PATCHSET v9] Add support for write life time hints Jens Axboe 2017-06-21 0:21 ` Jens Axboe 2017-06-21 0:21 ` [PATCH 1/9] fs: add fcntl() interface for setting/getting " Jens Axboe 2017-06-21 0:21 ` Jens Axboe 2017-06-26 9:51 ` Christoph Hellwig 2017-06-26 9:51 ` Christoph Hellwig 2017-06-26 9:51 ` Christoph Hellwig 2017-06-26 13:55 ` Jens Axboe 2017-06-26 13:55 ` Jens Axboe 2017-06-26 13:55 ` Jens Axboe 2017-06-26 16:09 ` Darrick J. Wong 2017-06-26 16:09 ` Darrick J. Wong 2017-06-26 16:09 ` Darrick J. Wong 2017-06-26 16:29 ` Jens Axboe 2017-06-26 16:29 ` Jens Axboe 2017-06-26 16:29 ` Jens Axboe 2017-06-21 0:21 ` [PATCH 2/9] block: add support for write hints in a bio Jens Axboe 2017-06-21 0:21 ` Jens Axboe 2017-06-26 9:52 ` Christoph Hellwig 2017-06-26 9:52 ` Christoph Hellwig 2017-06-21 0:22 ` [PATCH 3/9] blk-mq: expose stream write hints through debugfs Jens Axboe 2017-06-21 0:22 ` Jens Axboe 2017-06-26 9:52 ` Christoph Hellwig 2017-06-26 9:52 ` Christoph Hellwig 2017-06-21 0:22 ` [PATCH 4/9] fs: add O_DIRECT support for sending down write life time hints Jens Axboe 2017-06-21 0:22 ` Jens Axboe 2017-06-26 9:55 ` Christoph Hellwig [this message] 2017-06-26 9:55 ` Christoph Hellwig 2017-06-26 14:12 ` Jens Axboe 2017-06-26 14:12 ` Jens Axboe 2017-06-21 0:22 ` [PATCH 5/9] fs: add support for buffered writeback to pass down write hints Jens Axboe 2017-06-21 0:22 ` Jens Axboe 2017-06-21 0:22 ` [PATCH 6/9] ext4: add support for passing in write hints for buffered writes Jens Axboe 2017-06-21 0:22 ` Jens Axboe 2017-06-21 0:22 ` [PATCH 7/9] xfs: " Jens Axboe 2017-06-21 0:22 ` Jens Axboe 2017-06-21 1:35 ` Darrick J. Wong 2017-06-21 1:35 ` Darrick J. Wong 2017-06-21 1:46 ` Jens Axboe 2017-06-21 1:46 ` Jens Axboe 2017-06-26 9:56 ` Christoph Hellwig 2017-06-26 9:56 ` Christoph Hellwig 2017-06-26 14:16 ` Jens Axboe 2017-06-26 14:16 ` Jens Axboe 2017-06-21 0:22 ` [PATCH 8/9] btrfs: " Jens Axboe 2017-06-21 0:22 ` Jens Axboe 2017-06-21 0:22 ` [PATCH 9/9] nvme: add support for streams and directives Jens Axboe 2017-06-21 0:22 ` Jens Axboe 2017-06-26 9:59 ` Christoph Hellwig 2017-06-26 9:59 ` Christoph Hellwig 2017-06-26 13:56 ` Jens Axboe 2017-06-26 13:56 ` Jens Axboe 2017-06-26 19:36 ` Andreas Dilger 2017-06-26 19:36 ` Andreas Dilger 2017-06-26 19:39 ` Jens Axboe 2017-06-26 19:39 ` Jens Axboe 2017-06-27 14:11 ` Christoph Hellwig 2017-06-27 14:11 ` Christoph Hellwig 2017-06-27 14:16 ` Jens Axboe 2017-06-27 14:16 ` Jens Axboe 2017-06-27 14:44 ` Christoph Hellwig 2017-06-27 14:44 ` Christoph Hellwig 2017-06-27 14:46 ` Jens Axboe 2017-06-27 14:46 ` Jens Axboe 2017-06-27 14:56 ` Jens Axboe 2017-06-27 14:56 ` Jens Axboe 2017-06-26 17:52 ` Martin K. Petersen 2017-06-26 17:52 ` Martin K. Petersen 2017-06-26 18:00 ` Jens Axboe 2017-06-26 18:00 ` Jens Axboe 2017-06-21 1:30 ` [PATCHSET v9] Add support for write life time hints Martin K. Petersen 2017-06-21 1:30 ` Martin K. Petersen 2017-06-21 1:45 ` Jens Axboe 2017-06-21 1:45 ` Jens Axboe -- strict thread matches above, loose matches on Subject: below -- 2017-06-26 15:37 [PATCHSET v10] " Jens Axboe 2017-06-26 15:37 ` [PATCH 4/9] fs: add O_DIRECT support for sending down " Jens Axboe 2017-06-27 14:53 ` Christoph Hellwig 2017-06-19 17:04 [PATCHSET v8] Add support for " Jens Axboe 2017-06-19 17:04 ` [PATCH 4/9] fs: add O_DIRECT support for sending down " Jens Axboe 2017-06-19 17:04 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170626095506.GE14057@infradead.org \ --to=hch@infradead.org \ --cc=adilger@dilger.ca \ --cc=axboe@kernel.dk \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=martin.petersen@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.