All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	adilger@dilger.ca, martin.petersen@oracle.com,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 9/9] nvme: add support for streams and directives
Date: Mon, 26 Jun 2017 13:52:02 -0400	[thread overview]
Message-ID: <yq17ezy4oxp.fsf@oracle.com> (raw)
In-Reply-To: <20170626095907.GG14057@infradead.org> (Christoph Hellwig's message of "Mon, 26 Jun 2017 02:59:07 -0700")


Christoph,

>  - can we keep a module option to disable streams, or in fact for
>    now maybe to explicitly enable it?  I expect this to be interesting
>    at least for the first devices that implement it.  Also given that
>    it needs to be explicitly enabled I would expect some overhead of
>    just enabling it when never used

Yeah, based on my experiments we'll need to drive this as an opt-in
feature for now. Short term the module option is OK. Once more devices
start materializing we probably need a white/blacklist/quirk scheme.

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH 9/9] nvme: add support for streams and directives
Date: Mon, 26 Jun 2017 13:52:02 -0400	[thread overview]
Message-ID: <yq17ezy4oxp.fsf@oracle.com> (raw)
In-Reply-To: <20170626095907.GG14057@infradead.org> (Christoph Hellwig's message of "Mon, 26 Jun 2017 02:59:07 -0700")


Christoph,

>  - can we keep a module option to disable streams, or in fact for
>    now maybe to explicitly enable it?  I expect this to be interesting
>    at least for the first devices that implement it.  Also given that
>    it needs to be explicitly enabled I would expect some overhead of
>    just enabling it when never used

Yeah, based on my experiments we'll need to drive this as an opt-in
feature for now. Short term the module option is OK. Once more devices
start materializing we probably need a white/blacklist/quirk scheme.

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2017-06-26 17:52 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  0:21 [PATCHSET v9] Add support for write life time hints Jens Axboe
2017-06-21  0:21 ` Jens Axboe
2017-06-21  0:21 ` [PATCH 1/9] fs: add fcntl() interface for setting/getting " Jens Axboe
2017-06-21  0:21   ` Jens Axboe
2017-06-26  9:51   ` Christoph Hellwig
2017-06-26  9:51     ` Christoph Hellwig
2017-06-26  9:51     ` Christoph Hellwig
2017-06-26 13:55     ` Jens Axboe
2017-06-26 13:55       ` Jens Axboe
2017-06-26 13:55       ` Jens Axboe
2017-06-26 16:09       ` Darrick J. Wong
2017-06-26 16:09         ` Darrick J. Wong
2017-06-26 16:09         ` Darrick J. Wong
2017-06-26 16:29         ` Jens Axboe
2017-06-26 16:29           ` Jens Axboe
2017-06-26 16:29           ` Jens Axboe
2017-06-21  0:21 ` [PATCH 2/9] block: add support for write hints in a bio Jens Axboe
2017-06-21  0:21   ` Jens Axboe
2017-06-26  9:52   ` Christoph Hellwig
2017-06-26  9:52     ` Christoph Hellwig
2017-06-21  0:22 ` [PATCH 3/9] blk-mq: expose stream write hints through debugfs Jens Axboe
2017-06-21  0:22   ` Jens Axboe
2017-06-26  9:52   ` Christoph Hellwig
2017-06-26  9:52     ` Christoph Hellwig
2017-06-21  0:22 ` [PATCH 4/9] fs: add O_DIRECT support for sending down write life time hints Jens Axboe
2017-06-21  0:22   ` Jens Axboe
2017-06-26  9:55   ` Christoph Hellwig
2017-06-26  9:55     ` Christoph Hellwig
2017-06-26 14:12     ` Jens Axboe
2017-06-26 14:12       ` Jens Axboe
2017-06-21  0:22 ` [PATCH 5/9] fs: add support for buffered writeback to pass down write hints Jens Axboe
2017-06-21  0:22   ` Jens Axboe
2017-06-21  0:22 ` [PATCH 6/9] ext4: add support for passing in write hints for buffered writes Jens Axboe
2017-06-21  0:22   ` Jens Axboe
2017-06-21  0:22 ` [PATCH 7/9] xfs: " Jens Axboe
2017-06-21  0:22   ` Jens Axboe
2017-06-21  1:35   ` Darrick J. Wong
2017-06-21  1:35     ` Darrick J. Wong
2017-06-21  1:46     ` Jens Axboe
2017-06-21  1:46       ` Jens Axboe
2017-06-26  9:56   ` Christoph Hellwig
2017-06-26  9:56     ` Christoph Hellwig
2017-06-26 14:16     ` Jens Axboe
2017-06-26 14:16       ` Jens Axboe
2017-06-21  0:22 ` [PATCH 8/9] btrfs: " Jens Axboe
2017-06-21  0:22   ` Jens Axboe
2017-06-21  0:22 ` [PATCH 9/9] nvme: add support for streams and directives Jens Axboe
2017-06-21  0:22   ` Jens Axboe
2017-06-26  9:59   ` Christoph Hellwig
2017-06-26  9:59     ` Christoph Hellwig
2017-06-26 13:56     ` Jens Axboe
2017-06-26 13:56       ` Jens Axboe
2017-06-26 19:36       ` Andreas Dilger
2017-06-26 19:36         ` Andreas Dilger
2017-06-26 19:39         ` Jens Axboe
2017-06-26 19:39           ` Jens Axboe
2017-06-27 14:11       ` Christoph Hellwig
2017-06-27 14:11         ` Christoph Hellwig
2017-06-27 14:16         ` Jens Axboe
2017-06-27 14:16           ` Jens Axboe
2017-06-27 14:44           ` Christoph Hellwig
2017-06-27 14:44             ` Christoph Hellwig
2017-06-27 14:46             ` Jens Axboe
2017-06-27 14:46               ` Jens Axboe
2017-06-27 14:56               ` Jens Axboe
2017-06-27 14:56                 ` Jens Axboe
2017-06-26 17:52     ` Martin K. Petersen [this message]
2017-06-26 17:52       ` Martin K. Petersen
2017-06-26 18:00       ` Jens Axboe
2017-06-26 18:00         ` Jens Axboe
2017-06-21  1:30 ` [PATCHSET v9] Add support for write life time hints Martin K. Petersen
2017-06-21  1:30   ` Martin K. Petersen
2017-06-21  1:45   ` Jens Axboe
2017-06-21  1:45     ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2017-06-26 15:37 [PATCHSET v10] " Jens Axboe
2017-06-26 15:38 ` [PATCH 9/9] nvme: add support for streams and directives Jens Axboe
2017-06-19 17:04 [PATCHSET v8] Add support for write life time hints Jens Axboe
2017-06-19 17:05 ` [PATCH 9/9] nvme: add support for streams and directives Jens Axboe
2017-06-19 17:05   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq17ezy4oxp.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=adilger@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.