All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds
@ 2017-06-27  8:08 ` Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-06-27  8:08 UTC (permalink / raw)
  To: Ben Skeggs, David Airlie, dri-devel, nouveau; +Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Array thresolds should be named thresholds, rename it. Also make it static
static const char * const

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
index e93b2410c38b..6449771b9dc6 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
@@ -83,7 +83,7 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
 {
 	struct nvkm_subdev *subdev = &therm->subdev;
 	bool active;
-	const char *thresolds[] = {
+	static const char * const thresholds[] = {
 		"fanboost", "downclock", "critical", "shutdown"
 	};
 	int temperature = therm->func->temp_get(therm);
@@ -94,10 +94,10 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
 	if (dir == NVKM_THERM_THRS_FALLING)
 		nvkm_info(subdev,
 			  "temperature (%i C) went below the '%s' threshold\n",
-			  temperature, thresolds[thrs]);
+			  temperature, thresholds[thrs]);
 	else
 		nvkm_info(subdev, "temperature (%i C) hit the '%s' threshold\n",
-			  temperature, thresolds[thrs]);
+			  temperature, thresholds[thrs]);
 
 	active = (dir == NVKM_THERM_THRS_RISING);
 	switch (thrs) {
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds
@ 2017-06-27  8:08 ` Colin King
  0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2017-06-27  8:08 UTC (permalink / raw)
  To: Ben Skeggs, David Airlie, dri-devel, nouveau; +Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Array thresolds should be named thresholds, rename it. Also make it static
static const char * const

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
index e93b2410c38b..6449771b9dc6 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
@@ -83,7 +83,7 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
 {
 	struct nvkm_subdev *subdev = &therm->subdev;
 	bool active;
-	const char *thresolds[] = {
+	static const char * const thresholds[] = {
 		"fanboost", "downclock", "critical", "shutdown"
 	};
 	int temperature = therm->func->temp_get(therm);
@@ -94,10 +94,10 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
 	if (dir == NVKM_THERM_THRS_FALLING)
 		nvkm_info(subdev,
 			  "temperature (%i C) went below the '%s' threshold\n",
-			  temperature, thresolds[thrs]);
+			  temperature, thresholds[thrs]);
 	else
 		nvkm_info(subdev, "temperature (%i C) hit the '%s' threshold\n",
-			  temperature, thresolds[thrs]);
+			  temperature, thresholds[thrs]);
 
 	active = (dir == NVKM_THERM_THRS_RISING);
 	switch (thrs) {
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds
  2017-06-27  8:08 ` Colin King
@ 2017-06-27 10:07   ` Martin Peres
  -1 siblings, 0 replies; 4+ messages in thread
From: Martin Peres @ 2017-06-27 10:07 UTC (permalink / raw)
  To: Colin King, Ben Skeggs, David Airlie, dri-devel, nouveau; +Cc: linux-kernel

On 27/06/17 11:08, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Array thresolds should be named thresholds, rename it. Also make it static
> static const char * const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks for doing this,

Reviewed-by: Martin Peres <martin.peres@free.fr>

> ---
>   drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> index e93b2410c38b..6449771b9dc6 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> @@ -83,7 +83,7 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
>   {
>   	struct nvkm_subdev *subdev = &therm->subdev;
>   	bool active;
> -	const char *thresolds[] = {
> +	static const char * const thresholds[] = {
>   		"fanboost", "downclock", "critical", "shutdown"
>   	};
>   	int temperature = therm->func->temp_get(therm);
> @@ -94,10 +94,10 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
>   	if (dir == NVKM_THERM_THRS_FALLING)
>   		nvkm_info(subdev,
>   			  "temperature (%i C) went below the '%s' threshold\n",
> -			  temperature, thresolds[thrs]);
> +			  temperature, thresholds[thrs]);
>   	else
>   		nvkm_info(subdev, "temperature (%i C) hit the '%s' threshold\n",
> -			  temperature, thresolds[thrs]);
> +			  temperature, thresholds[thrs]);
>   
>   	active = (dir == NVKM_THERM_THRS_RISING);
>   	switch (thrs) {
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds
@ 2017-06-27 10:07   ` Martin Peres
  0 siblings, 0 replies; 4+ messages in thread
From: Martin Peres @ 2017-06-27 10:07 UTC (permalink / raw)
  To: Colin King, Ben Skeggs, David Airlie, dri-devel, nouveau; +Cc: linux-kernel

On 27/06/17 11:08, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Array thresolds should be named thresholds, rename it. Also make it static
> static const char * const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks for doing this,

Reviewed-by: Martin Peres <martin.peres@free.fr>

> ---
>   drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> index e93b2410c38b..6449771b9dc6 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> @@ -83,7 +83,7 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
>   {
>   	struct nvkm_subdev *subdev = &therm->subdev;
>   	bool active;
> -	const char *thresolds[] = {
> +	static const char * const thresholds[] = {
>   		"fanboost", "downclock", "critical", "shutdown"
>   	};
>   	int temperature = therm->func->temp_get(therm);
> @@ -94,10 +94,10 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
>   	if (dir == NVKM_THERM_THRS_FALLING)
>   		nvkm_info(subdev,
>   			  "temperature (%i C) went below the '%s' threshold\n",
> -			  temperature, thresolds[thrs]);
> +			  temperature, thresholds[thrs]);
>   	else
>   		nvkm_info(subdev, "temperature (%i C) hit the '%s' threshold\n",
> -			  temperature, thresolds[thrs]);
> +			  temperature, thresholds[thrs]);
>   
>   	active = (dir == NVKM_THERM_THRS_RISING);
>   	switch (thrs) {
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-27 10:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27  8:08 [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds Colin King
2017-06-27  8:08 ` Colin King
2017-06-27 10:07 ` [Nouveau] " Martin Peres
2017-06-27 10:07   ` Martin Peres

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.