From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, nsekhar@ti.com,
david@lechnology.com, wsa@the-dreams.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, nicolas.ferre@microchip.com
Subject: Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses
Date: Fri, 30 Jun 2017 09:20:32 +0200 [thread overview]
Message-ID: <20170630072032.tbnatpnh3rej4lmf@pengutronix.de> (raw)
In-Reply-To: <1498736351-9021-3-git-send-email-claudiu.beznea@microchip.com>
Hallo,
On Thu, Jun 29, 2017 at 02:39:10PM +0300, Claudiu Beznea wrote:
> diff --git a/include/linux/platform_data/at24.h b/include/linux/platform_data/at24.h
> index 271a4e2..d55c454 100644
> --- a/include/linux/platform_data/at24.h
> +++ b/include/linux/platform_data/at24.h
> @@ -50,6 +50,7 @@ struct at24_platform_data {
> #define AT24_FLAG_TAKE8ADDR BIT(4) /* take always 8 addresses (24c00) */
> #define AT24_FLAG_SERIAL BIT(3) /* factory-programmed serial number */
> #define AT24_FLAG_MAC BIT(2) /* factory-programmed mac address */
> + u8 offset;
Assuming you rename the property, please adapt the member name here
accordingly.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Claudiu Beznea <claudiu.beznea-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
nsekhar-l0cyMroinI0@public.gmane.org,
david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org
Subject: Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses
Date: Fri, 30 Jun 2017 09:20:32 +0200 [thread overview]
Message-ID: <20170630072032.tbnatpnh3rej4lmf@pengutronix.de> (raw)
In-Reply-To: <1498736351-9021-3-git-send-email-claudiu.beznea-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
Hallo,
On Thu, Jun 29, 2017 at 02:39:10PM +0300, Claudiu Beznea wrote:
> diff --git a/include/linux/platform_data/at24.h b/include/linux/platform_data/at24.h
> index 271a4e2..d55c454 100644
> --- a/include/linux/platform_data/at24.h
> +++ b/include/linux/platform_data/at24.h
> @@ -50,6 +50,7 @@ struct at24_platform_data {
> #define AT24_FLAG_TAKE8ADDR BIT(4) /* take always 8 addresses (24c00) */
> #define AT24_FLAG_SERIAL BIT(3) /* factory-programmed serial number */
> #define AT24_FLAG_MAC BIT(2) /* factory-programmed mac address */
> + u8 offset;
Assuming you rename the property, please adapt the member name here
accordingly.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-30 7:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 11:39 [RFC PATCH 0/3] Add at24 functionality to read form different EEPROM offsets Claudiu Beznea
2017-06-29 11:39 ` Claudiu Beznea
2017-06-29 11:39 ` [PATCH 1/3] dt-bindings: i2c: eeprom: document all at24 bindings Claudiu Beznea
2017-06-29 11:39 ` Claudiu Beznea
2017-06-29 11:39 ` [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses Claudiu Beznea
2017-06-29 11:39 ` Claudiu Beznea
2017-06-29 11:56 ` Andy Shevchenko
2017-06-29 13:30 ` Ludovic Desroches
2017-07-05 9:31 ` m18063
2017-06-29 15:32 ` David Lechner
2017-06-29 15:32 ` David Lechner
2017-07-05 9:33 ` m18063
2017-07-05 9:33 ` m18063
2017-06-30 7:20 ` Uwe Kleine-König [this message]
2017-06-30 7:20 ` Uwe Kleine-König
2017-07-05 9:33 ` m18063
2017-07-05 9:33 ` m18063
2017-06-29 11:39 ` [RFC PATCH 3/3] dt-bindings: i2c: eeprom: document "start-offset" binding Claudiu Beznea
2017-06-29 11:39 ` Claudiu Beznea
2017-07-06 15:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630072032.tbnatpnh3rej4lmf@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=claudiu.beznea@microchip.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.