* [PATCH] kmod: add dependencies for test module
@ 2017-06-30 15:47 Arnd Bergmann
2017-06-30 22:54 ` Luis R. Rodriguez
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-06-30 15:47 UTC (permalink / raw)
To: Andrew Morton, Luis R. Rodriguez; +Cc: Arnd Bergmann, linux-kernel
When we try to 'select' drivers whose dependencies are not met,
we get a kconfig warning and undefined behavior as further 'select'
statements in those drivers can not be honored:
warning: (TEST_KMOD) selects TUN which has unmet direct dependencies (NETDEVICES && NET_CORE && INET)
warning: (TEST_KMOD) selects XFS_FS which has unmet direct dependencies (BLOCK && (64BIT || LBDAF))
ERROR: "iomap_zero_range" [fs/xfs/xfs.ko] undefined!
ERROR: "iomap_fiemap" [fs/xfs/xfs.ko] undefined!
ERROR: "iomap_page_mkwrite" [fs/xfs/xfs.ko] undefined!
To work around that, this adds the dependencies required by the
'tun', 'xfs' and 'btrfs' modules for CONFIG_TEST_KMOD, guaranteeing
that we can always enable those, and fixing the 'randconfig' issues.
Unfortunately, there is another problem that I have not found a
good solution for: If any of the three drivers are built-in rather
than loadable modules, then the module load test will later fail
at runtime.
Fixes: ec159fed8677 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/Kconfig.debug | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 411cddd713c0..0f7ba738ef7a 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1883,6 +1883,8 @@ config TEST_KMOD
tristate "kmod stress tester"
default n
depends on m
+ depends on BLOCK && (64BIT || LBDAF) # for XFS, BTRFS
+ depends on NETDEVICES && NET_CORE && INET # for TUN
select TEST_LKM
select XFS_FS
select TUN
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kmod: add dependencies for test module
2017-06-30 15:47 [PATCH] kmod: add dependencies for test module Arnd Bergmann
@ 2017-06-30 22:54 ` Luis R. Rodriguez
0 siblings, 0 replies; 2+ messages in thread
From: Luis R. Rodriguez @ 2017-06-30 22:54 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Andrew Morton, Luis R. Rodriguez, linux-kernel
On Fri, Jun 30, 2017 at 05:47:44PM +0200, Arnd Bergmann wrote:
> When we try to 'select' drivers whose dependencies are not met,
> we get a kconfig warning and undefined behavior as further 'select'
> statements in those drivers can not be honored:
>
> warning: (TEST_KMOD) selects TUN which has unmet direct dependencies (NETDEVICES && NET_CORE && INET)
> warning: (TEST_KMOD) selects XFS_FS which has unmet direct dependencies (BLOCK && (64BIT || LBDAF))
> ERROR: "iomap_zero_range" [fs/xfs/xfs.ko] undefined!
> ERROR: "iomap_fiemap" [fs/xfs/xfs.ko] undefined!
> ERROR: "iomap_page_mkwrite" [fs/xfs/xfs.ko] undefined!
>
> To work around that, this adds the dependencies required by the
> 'tun', 'xfs' and 'btrfs' modules for CONFIG_TEST_KMOD, guaranteeing
> that we can always enable those, and fixing the 'randconfig' issues.
>
> Unfortunately, there is another problem that I have not found a
> good solution for: If any of the three drivers are built-in rather
> than loadable modules, then the module load test will later fail
> at runtime.
>
> Fixes: ec159fed8677 ("kmod: add test driver to stress test the module loader")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Luis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-30 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 15:47 [PATCH] kmod: add dependencies for test module Arnd Bergmann
2017-06-30 22:54 ` Luis R. Rodriguez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.