All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Christoph Hellwig <hch@lst.de>,
	Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH 0/8] correct quiescing in several block drivers
Date: Tue, 4 Jul 2017 16:12:46 +0800	[thread overview]
Message-ID: <20170704081244.GB29053@ming.t460p> (raw)
In-Reply-To: <1499154912-10420-1-git-send-email-sagi@grimberg.me>

On Tue, Jul 04, 2017 at 10:55:04AM +0300, Sagi Grimberg wrote:
> Before we either iterate on tags or cleanup the request queue
> we must guarantee that the hw queues are stop and no inflight
> .queue_rq is active. Thats what blk_mq_quiesce_queue is for, so
> use it where appropriate.

queue freezing is used in cleanup path, and not required to
quiesce queue.

quiesce is required for canceling request via blk_mq_tagset_busy_iter()
for avoiding double release.

I think we should make it clear in comment log.

> 
> Sagi Grimberg (8):
>   nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw
>     queues
>   nvme-fc: quiesce/unquiesce admin_q instead of start/stop its hw queues
>   nvme-loop: quiesce/unquiesce admin_q instead of start/stop its hw
>     queues
>   nvme-pci: quiesce/unquiesce admin_q instead of start/stop its hw
>     queues
>   nbd: quiesce request queues to make sure no submissions are inflight
>   mtip32xx: quiesce request queues to make sure no submissions are
>     inflight
>   virtio_blk: quiesce/unquiesce live IO when entering PM states
>   xen-blockfront: quiesce IO before device removal
> 
>  drivers/block/mtip32xx/mtip32xx.c |  8 ++++----
>  drivers/block/nbd.c               |  4 ++--
>  drivers/block/virtio_blk.c        |  4 ++--
>  drivers/block/xen-blkfront.c      |  8 ++++----
>  drivers/nvme/host/fc.c            |  8 +++++---
>  drivers/nvme/host/pci.c           | 10 ++++++----
>  drivers/nvme/host/rdma.c          |  7 ++++---
>  drivers/nvme/target/loop.c        |  2 +-
>  8 files changed, 28 insertions(+), 23 deletions(-)
> 
> -- 
> 2.7.4
> 

-- 
Ming

WARNING: multiple messages have this Message-ID (diff)
From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH 0/8] correct quiescing in several block drivers
Date: Tue, 4 Jul 2017 16:12:46 +0800	[thread overview]
Message-ID: <20170704081244.GB29053@ming.t460p> (raw)
In-Reply-To: <1499154912-10420-1-git-send-email-sagi@grimberg.me>

On Tue, Jul 04, 2017@10:55:04AM +0300, Sagi Grimberg wrote:
> Before we either iterate on tags or cleanup the request queue
> we must guarantee that the hw queues are stop and no inflight
> .queue_rq is active. Thats what blk_mq_quiesce_queue is for, so
> use it where appropriate.

queue freezing is used in cleanup path, and not required to
quiesce queue.

quiesce is required for canceling request via blk_mq_tagset_busy_iter()
for avoiding double release.

I think we should make it clear in comment log.

> 
> Sagi Grimberg (8):
>   nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw
>     queues
>   nvme-fc: quiesce/unquiesce admin_q instead of start/stop its hw queues
>   nvme-loop: quiesce/unquiesce admin_q instead of start/stop its hw
>     queues
>   nvme-pci: quiesce/unquiesce admin_q instead of start/stop its hw
>     queues
>   nbd: quiesce request queues to make sure no submissions are inflight
>   mtip32xx: quiesce request queues to make sure no submissions are
>     inflight
>   virtio_blk: quiesce/unquiesce live IO when entering PM states
>   xen-blockfront: quiesce IO before device removal
> 
>  drivers/block/mtip32xx/mtip32xx.c |  8 ++++----
>  drivers/block/nbd.c               |  4 ++--
>  drivers/block/virtio_blk.c        |  4 ++--
>  drivers/block/xen-blkfront.c      |  8 ++++----
>  drivers/nvme/host/fc.c            |  8 +++++---
>  drivers/nvme/host/pci.c           | 10 ++++++----
>  drivers/nvme/host/rdma.c          |  7 ++++---
>  drivers/nvme/target/loop.c        |  2 +-
>  8 files changed, 28 insertions(+), 23 deletions(-)
> 
> -- 
> 2.7.4
> 

-- 
Ming

  parent reply	other threads:[~2017-07-04  8:12 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04  7:55 [PATCH 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-04  7:55 ` Sagi Grimberg
2017-07-04  7:55 ` [PATCH 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-04  7:55   ` Sagi Grimberg
2017-07-04  8:15   ` Ming Lei
2017-07-04  8:15     ` Ming Lei
2017-07-04  8:59     ` Sagi Grimberg
2017-07-04  8:59       ` Sagi Grimberg
2017-07-04  9:07       ` Sagi Grimberg
2017-07-04  9:07         ` Sagi Grimberg
2017-07-04 12:41         ` Ming Lei
2017-07-04 12:41           ` Ming Lei
2017-07-04 15:35           ` Sagi Grimberg
2017-07-04 15:35             ` Sagi Grimberg
2017-07-04  7:55 ` [PATCH 2/8] nvme-fc: " Sagi Grimberg
2017-07-04  7:55   ` Sagi Grimberg
2017-07-04  8:18   ` Ming Lei
2017-07-04  8:18     ` Ming Lei
2017-07-04  7:55 ` [PATCH 3/8] nvme-loop: quiesce admin_q instead of stopping " Sagi Grimberg
2017-07-04  7:55   ` Sagi Grimberg
2017-07-04  8:23   ` Ming Lei
2017-07-04  8:23     ` Ming Lei
2017-07-04  9:24     ` Sagi Grimberg
2017-07-04  9:24       ` Sagi Grimberg
2017-07-04 10:38       ` Ming Lei
2017-07-04  7:55 ` [PATCH 4/8] nvme-pci: quiesce/unquiesce admin_q instead of start/stop its " Sagi Grimberg
2017-07-04  7:55   ` Sagi Grimberg
2017-07-04  8:26   ` Ming Lei
2017-07-04  8:26     ` Ming Lei
2017-07-04  7:55 ` [PATCH 5/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-04  7:55   ` Sagi Grimberg
2017-07-04  8:28   ` Ming Lei
2017-07-04  8:28     ` Ming Lei
2017-07-04  7:55 ` [PATCH 6/8] mtip32xx: " Sagi Grimberg
2017-07-04  7:55   ` Sagi Grimberg
2017-07-04 22:32   ` Ming Lei
2017-07-04 22:32     ` Ming Lei
2017-07-05  6:34     ` Sagi Grimberg
2017-07-05  6:34       ` Sagi Grimberg
2017-07-04  7:55 ` [PATCH 7/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
2017-07-04  7:55   ` Sagi Grimberg
2017-07-04  8:41   ` Ming Lei
2017-07-04  8:41     ` Ming Lei
2017-07-04 21:39   ` Michael S. Tsirkin
2017-07-04 21:39     ` Michael S. Tsirkin
2017-07-04  7:55 ` [PATCH 8/8] xen-blockfront: quiesce IO before device removal Sagi Grimberg
2017-07-04  7:55   ` Sagi Grimberg
2017-07-04 22:19   ` Ming Lei
2017-07-04 22:19     ` Ming Lei
2017-07-05  6:29     ` Sagi Grimberg
2017-07-05  6:29       ` Sagi Grimberg
2017-07-05 22:56       ` Christoph Hellwig
2017-07-05 22:56         ` Christoph Hellwig
2017-07-06  6:52         ` Sagi Grimberg
2017-07-06  6:52           ` Sagi Grimberg
2017-07-04  8:12 ` Ming Lei [this message]
2017-07-04  8:12   ` [PATCH 0/8] correct quiescing in several block drivers Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170704081244.GB29053@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.