From: Sagi Grimberg <sagi@grimberg.me>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH 6/8] mtip32xx: quiesce request queues to make sure no submissions are inflight
Date: Wed, 5 Jul 2017 09:34:16 +0300 [thread overview]
Message-ID: <fd1a48c9-5912-69a6-7ade-32b07e21403b@grimberg.me> (raw)
In-Reply-To: <20170704223251.GB3732@ming.t460p>
>> @@ -3995,7 +3995,7 @@ static int mtip_block_remove(struct driver_data *dd)
>> dd->disk->disk_name);
>>
>> blk_freeze_queue_start(dd->queue);
>> - blk_mq_stop_hw_queues(dd->queue);
>> + blk_mq_quiesce_queue(dd->queue);
>> blk_mq_tagset_busy_iter(&dd->tags, mtip_no_dev_cleanup, dd);
>
> We still need to unquiesce queue for avoiding hanging blk_freeze_queue()
> in blk_cleanup_queue() since any new request queued during quiescing
> can't be dispatched to driver/device.
Yes, already added it in v2.
> There are other blk_mq_tagset_busy_iter() in mtip_service_thread(),
> which looks need quiesce too.
Wasn't sure about those two... I agree it looks like quiescing is
needed, will add in v2.
> This case is even worse, because both
> mtip_abort_cmd() and mtip_queue_cmd() do not check if the req is
> started.
Its easy enough to add.
WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 6/8] mtip32xx: quiesce request queues to make sure no submissions are inflight
Date: Wed, 5 Jul 2017 09:34:16 +0300 [thread overview]
Message-ID: <fd1a48c9-5912-69a6-7ade-32b07e21403b@grimberg.me> (raw)
In-Reply-To: <20170704223251.GB3732@ming.t460p>
>> @@ -3995,7 +3995,7 @@ static int mtip_block_remove(struct driver_data *dd)
>> dd->disk->disk_name);
>>
>> blk_freeze_queue_start(dd->queue);
>> - blk_mq_stop_hw_queues(dd->queue);
>> + blk_mq_quiesce_queue(dd->queue);
>> blk_mq_tagset_busy_iter(&dd->tags, mtip_no_dev_cleanup, dd);
>
> We still need to unquiesce queue for avoiding hanging blk_freeze_queue()
> in blk_cleanup_queue() since any new request queued during quiescing
> can't be dispatched to driver/device.
Yes, already added it in v2.
> There are other blk_mq_tagset_busy_iter() in mtip_service_thread(),
> which looks need quiesce too.
Wasn't sure about those two... I agree it looks like quiescing is
needed, will add in v2.
> This case is even worse, because both
> mtip_abort_cmd() and mtip_queue_cmd() do not check if the req is
> started.
Its easy enough to add.
next prev parent reply other threads:[~2017-07-05 6:34 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 7:55 [PATCH 0/8] correct quiescing in several block drivers Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 7:55 ` [PATCH 1/8] nvme-rdma: quiesce/unquiesce admin_q instead of start/stop its hw queues Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:15 ` Ming Lei
2017-07-04 8:15 ` Ming Lei
2017-07-04 8:59 ` Sagi Grimberg
2017-07-04 8:59 ` Sagi Grimberg
2017-07-04 9:07 ` Sagi Grimberg
2017-07-04 9:07 ` Sagi Grimberg
2017-07-04 12:41 ` Ming Lei
2017-07-04 12:41 ` Ming Lei
2017-07-04 15:35 ` Sagi Grimberg
2017-07-04 15:35 ` Sagi Grimberg
2017-07-04 7:55 ` [PATCH 2/8] nvme-fc: " Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:18 ` Ming Lei
2017-07-04 8:18 ` Ming Lei
2017-07-04 7:55 ` [PATCH 3/8] nvme-loop: quiesce admin_q instead of stopping " Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:23 ` Ming Lei
2017-07-04 8:23 ` Ming Lei
2017-07-04 9:24 ` Sagi Grimberg
2017-07-04 9:24 ` Sagi Grimberg
2017-07-04 10:38 ` Ming Lei
2017-07-04 7:55 ` [PATCH 4/8] nvme-pci: quiesce/unquiesce admin_q instead of start/stop its " Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:26 ` Ming Lei
2017-07-04 8:26 ` Ming Lei
2017-07-04 7:55 ` [PATCH 5/8] nbd: quiesce request queues to make sure no submissions are inflight Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:28 ` Ming Lei
2017-07-04 8:28 ` Ming Lei
2017-07-04 7:55 ` [PATCH 6/8] mtip32xx: " Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 22:32 ` Ming Lei
2017-07-04 22:32 ` Ming Lei
2017-07-05 6:34 ` Sagi Grimberg [this message]
2017-07-05 6:34 ` Sagi Grimberg
2017-07-04 7:55 ` [PATCH 7/8] virtio_blk: quiesce/unquiesce live IO when entering PM states Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 8:41 ` Ming Lei
2017-07-04 8:41 ` Ming Lei
2017-07-04 21:39 ` Michael S. Tsirkin
2017-07-04 21:39 ` Michael S. Tsirkin
2017-07-04 7:55 ` [PATCH 8/8] xen-blockfront: quiesce IO before device removal Sagi Grimberg
2017-07-04 7:55 ` Sagi Grimberg
2017-07-04 22:19 ` Ming Lei
2017-07-04 22:19 ` Ming Lei
2017-07-05 6:29 ` Sagi Grimberg
2017-07-05 6:29 ` Sagi Grimberg
2017-07-05 22:56 ` Christoph Hellwig
2017-07-05 22:56 ` Christoph Hellwig
2017-07-06 6:52 ` Sagi Grimberg
2017-07-06 6:52 ` Sagi Grimberg
2017-07-04 8:12 ` [PATCH 0/8] correct quiescing in several block drivers Ming Lei
2017-07-04 8:12 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1a48c9-5912-69a6-7ade-32b07e21403b@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.