All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: David Wu <david.wu@rock-chips.com>
Cc: thierry.reding@gmail.com, heiko@sntech.de,
	boris.brezillon@free-electrons.com, catalin.marinas@arm.com,
	briannorris@chromium.org, dianders@chromium.org,
	mark.rutland@arm.com, huangtao@rock-chips.com,
	linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328
Date: Thu, 6 Jul 2017 12:17:57 -0500	[thread overview]
Message-ID: <20170706171757.qmnvmdyjuj77tt27@rob-hp-laptop> (raw)
In-Reply-To: <1498739271-27431-5-git-send-email-david.wu@rock-chips.com>

On Thu, Jun 29, 2017 at 08:27:50PM +0800, David Wu wrote:
> The rk3328 soc supports atomic update, we could lock the configuration
> of period and duty at first, after unlock is configured, the period and
> duty are effective at the same time.
> 
> If the polarity, period and duty need to be configured together,
> the way for atomic update is "configure lock and old polarity" ->
> "configure period and duty" -> "configure unlock and new polarity".
> 
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> ---
>  .../devicetree/bindings/pwm/pwm-rockchip.txt       |  1 +

The subject is a bit misleading as you are adding support for a new 
version of the IP. Otherwise,

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/pwm/pwm-rockchip.c                         | 50 +++++++++++++++++++---
>  2 files changed, 46 insertions(+), 5 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328
Date: Thu, 6 Jul 2017 12:17:57 -0500	[thread overview]
Message-ID: <20170706171757.qmnvmdyjuj77tt27@rob-hp-laptop> (raw)
In-Reply-To: <1498739271-27431-5-git-send-email-david.wu@rock-chips.com>

On Thu, Jun 29, 2017 at 08:27:50PM +0800, David Wu wrote:
> The rk3328 soc supports atomic update, we could lock the configuration
> of period and duty at first, after unlock is configured, the period and
> duty are effective at the same time.
> 
> If the polarity, period and duty need to be configured together,
> the way for atomic update is "configure lock and old polarity" ->
> "configure period and duty" -> "configure unlock and new polarity".
> 
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> ---
>  .../devicetree/bindings/pwm/pwm-rockchip.txt       |  1 +

The subject is a bit misleading as you are adding support for a new 
version of the IP. Otherwise,

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/pwm/pwm-rockchip.c                         | 50 +++++++++++++++++++---
>  2 files changed, 46 insertions(+), 5 deletions(-)

  parent reply	other threads:[~2017-07-06 17:18 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 12:27 [PATCH 0/5] Add rk3328 pwm support David Wu
2017-06-29 12:27 ` David Wu
2017-06-29 12:27 ` David Wu
2017-06-29 12:27 ` [PATCH 1/5] pwm: rockchip: Add APB and function both clocks support David Wu
2017-06-29 12:27   ` David Wu
2017-06-29 12:27   ` David Wu
2017-07-06 17:12   ` Rob Herring
2017-07-06 17:12     ` Rob Herring
2017-07-06 17:12     ` Rob Herring
2017-06-29 12:27 ` [PATCH 2/5] pwm: rockchip: Remove the judge from return value of rockchip_pwm_config() David Wu
2017-06-29 12:27   ` David Wu
2017-07-03 18:31   ` Boris Brezillon
2017-07-03 18:31     ` Boris Brezillon
2017-06-29 12:27 ` [PATCH 3/5] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config() David Wu
2017-06-29 12:27   ` David Wu
2017-06-29 12:27   ` David Wu
2017-07-03 18:36   ` Boris Brezillon
2017-07-03 18:36     ` Boris Brezillon
2017-07-03 18:36     ` Boris Brezillon
2017-07-04  6:46     ` David.Wu
2017-07-04  6:46       ` David.Wu
2017-06-29 12:27 ` [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328 David Wu
2017-06-29 12:27   ` David Wu
2017-07-03 18:39   ` Boris Brezillon
2017-07-03 18:39     ` Boris Brezillon
2017-07-04  7:37     ` David.Wu
2017-07-04  7:37       ` David.Wu
2017-07-06 17:17   ` Rob Herring [this message]
2017-07-06 17:17     ` Rob Herring
2017-06-29 12:34 ` [PATCH 5/5] Arm64: dts: rockchip: Add pwm nodes " David Wu
2017-06-29 12:34   ` David Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706171757.qmnvmdyjuj77tt27@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=briannorris@chromium.org \
    --cc=catalin.marinas@arm.com \
    --cc=david.wu@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.