From: Johannes Thumshirn <jthumshirn@suse.de> To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>, Keith Busch <keith.busch@intel.com> Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>, Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>, Johannes Thumshirn <jthumshirn@suse.de> Subject: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots Date: Fri, 14 Jul 2017 14:05:17 +0200 [thread overview] Message-ID: <20170714120517.13552-3-jthumshirn@suse.de> (raw) In-Reply-To: <20170714120517.13552-1-jthumshirn@suse.de> The NVMe target has no way to preserve controller serial IDs across reboots which breaks udev scripts doing SYMLINK+="dev/disk/by-id/nvme-$env{ID_SERIAL}-part%n. Export the randomly generated serial number via configfs and allow setting of a serial via configfs to mitigate this breakage. Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- drivers/nvme/target/configfs.c | 22 ++++++++++++++++++++++ drivers/nvme/target/core.c | 2 ++ 2 files changed, 24 insertions(+) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index a358ecd93e11..9f19f0bde8f2 100644 --- a/drivers/nvme/target/configfs.c +++ b/drivers/nvme/target/configfs.c @@ -686,9 +686,31 @@ static ssize_t nvmet_subsys_version_store(struct config_item *item, } CONFIGFS_ATTR(nvmet_subsys_, version); +static ssize_t nvmet_subsys_attr_serial_show(struct config_item *item, + char *page) +{ + struct nvmet_subsys *subsys = to_subsys(item); + + return snprintf(page, PAGE_SIZE, "%llx\n", subsys->serial); +} + +static ssize_t nvmet_subsys_attr_serial_store(struct config_item *item, + const char *page, size_t count) +{ + struct nvmet_subsys *subsys = to_subsys(item); + + down_write(&nvmet_config_sem); + sscanf(page, "%llx\n", &subsys->serial); + up_write(&nvmet_config_sem); + + return count; +} +CONFIGFS_ATTR(nvmet_subsys_, attr_serial); + static struct configfs_attribute *nvmet_subsys_attrs[] = { &nvmet_subsys_attr_attr_allow_any_host, &nvmet_subsys_attr_version, + &nvmet_subsys_attr_attr_serial, NULL, }; diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 02efa7113d23..8feeed8c709c 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -924,8 +924,10 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn, if (!subsys) return NULL; + down_write(&nvmet_config_sem); subsys->ver = NVME_VS(1, 3, 0); /* NVMe 1.3.0 */ get_random_bytes(&subsys->serial, sizeof(subsys->serial)); + up_write(&nvmet_config_sem); switch (type) { case NVME_NQN_NVME: -- 2.12.3
WARNING: multiple messages have this Message-ID (diff)
From: jthumshirn@suse.de (Johannes Thumshirn) Subject: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots Date: Fri, 14 Jul 2017 14:05:17 +0200 [thread overview] Message-ID: <20170714120517.13552-3-jthumshirn@suse.de> (raw) In-Reply-To: <20170714120517.13552-1-jthumshirn@suse.de> The NVMe target has no way to preserve controller serial IDs across reboots which breaks udev scripts doing SYMLINK+="dev/disk/by-id/nvme-$env{ID_SERIAL}-part%n. Export the randomly generated serial number via configfs and allow setting of a serial via configfs to mitigate this breakage. Signed-off-by: Johannes Thumshirn <jthumshirn at suse.de> --- drivers/nvme/target/configfs.c | 22 ++++++++++++++++++++++ drivers/nvme/target/core.c | 2 ++ 2 files changed, 24 insertions(+) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index a358ecd93e11..9f19f0bde8f2 100644 --- a/drivers/nvme/target/configfs.c +++ b/drivers/nvme/target/configfs.c @@ -686,9 +686,31 @@ static ssize_t nvmet_subsys_version_store(struct config_item *item, } CONFIGFS_ATTR(nvmet_subsys_, version); +static ssize_t nvmet_subsys_attr_serial_show(struct config_item *item, + char *page) +{ + struct nvmet_subsys *subsys = to_subsys(item); + + return snprintf(page, PAGE_SIZE, "%llx\n", subsys->serial); +} + +static ssize_t nvmet_subsys_attr_serial_store(struct config_item *item, + const char *page, size_t count) +{ + struct nvmet_subsys *subsys = to_subsys(item); + + down_write(&nvmet_config_sem); + sscanf(page, "%llx\n", &subsys->serial); + up_write(&nvmet_config_sem); + + return count; +} +CONFIGFS_ATTR(nvmet_subsys_, attr_serial); + static struct configfs_attribute *nvmet_subsys_attrs[] = { &nvmet_subsys_attr_attr_allow_any_host, &nvmet_subsys_attr_version, + &nvmet_subsys_attr_attr_serial, NULL, }; diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 02efa7113d23..8feeed8c709c 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -924,8 +924,10 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn, if (!subsys) return NULL; + down_write(&nvmet_config_sem); subsys->ver = NVME_VS(1, 3, 0); /* NVMe 1.3.0 */ get_random_bytes(&subsys->serial, sizeof(subsys->serial)); + up_write(&nvmet_config_sem); switch (type) { case NVME_NQN_NVME: -- 2.12.3
next prev parent reply other threads:[~2017-07-14 12:05 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-14 12:05 [PATCH v2 0/2] Provide a stable serial number Johannes Thumshirn 2017-07-14 12:05 ` Johannes Thumshirn 2017-07-14 12:05 ` [PATCH v2 1/2] nvmet: Move serial number from controller to subsystem Johannes Thumshirn 2017-07-14 12:05 ` Johannes Thumshirn 2017-07-14 12:31 ` Christoph Hellwig 2017-07-14 12:31 ` Christoph Hellwig 2017-07-14 12:05 ` Johannes Thumshirn [this message] 2017-07-14 12:05 ` [PATCH v2 2/2] nvmet: preserve controller serial number between reboots Johannes Thumshirn 2017-07-14 12:32 ` Christoph Hellwig 2017-07-14 12:32 ` Christoph Hellwig 2017-07-14 12:46 ` Johannes Thumshirn 2017-07-14 12:46 ` Johannes Thumshirn 2017-07-14 12:48 ` Christoph Hellwig 2017-07-14 12:48 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170714120517.13552-3-jthumshirn@suse.de \ --to=jthumshirn@suse.de \ --cc=hch@lst.de \ --cc=keith.busch@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.