From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots
Date: Fri, 14 Jul 2017 14:32:08 +0200 [thread overview]
Message-ID: <20170714123208.GE26187@lst.de> (raw)
In-Reply-To: <20170714120517.13552-3-jthumshirn@suse.de>
This patch itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> static struct configfs_attribute *nvmet_subsys_attrs[] = {
> &nvmet_subsys_attr_attr_allow_any_host,
> &nvmet_subsys_attr_version,
> + &nvmet_subsys_attr_attr_serial,
but the new version attribute really needs the attr prefix so that
nvmetcli can pick it up. And we should also add nvmetcli support
for it. Can you do the rename before your series to ease backporting
as that should go into 3.12 (just like your serial number fix).
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots
Date: Fri, 14 Jul 2017 14:32:08 +0200 [thread overview]
Message-ID: <20170714123208.GE26187@lst.de> (raw)
In-Reply-To: <20170714120517.13552-3-jthumshirn@suse.de>
This patch itself looks good:
Reviewed-by: Christoph Hellwig <hch at lst.de>
> static struct configfs_attribute *nvmet_subsys_attrs[] = {
> &nvmet_subsys_attr_attr_allow_any_host,
> &nvmet_subsys_attr_version,
> + &nvmet_subsys_attr_attr_serial,
but the new version attribute really needs the attr prefix so that
nvmetcli can pick it up. And we should also add nvmetcli support
for it. Can you do the rename before your series to ease backporting
as that should go into 3.12 (just like your serial number fix).
next prev parent reply other threads:[~2017-07-14 12:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 12:05 [PATCH v2 0/2] Provide a stable serial number Johannes Thumshirn
2017-07-14 12:05 ` Johannes Thumshirn
2017-07-14 12:05 ` [PATCH v2 1/2] nvmet: Move serial number from controller to subsystem Johannes Thumshirn
2017-07-14 12:05 ` Johannes Thumshirn
2017-07-14 12:31 ` Christoph Hellwig
2017-07-14 12:31 ` Christoph Hellwig
2017-07-14 12:05 ` [PATCH v2 2/2] nvmet: preserve controller serial number between reboots Johannes Thumshirn
2017-07-14 12:05 ` Johannes Thumshirn
2017-07-14 12:32 ` Christoph Hellwig [this message]
2017-07-14 12:32 ` Christoph Hellwig
2017-07-14 12:46 ` Johannes Thumshirn
2017-07-14 12:46 ` Johannes Thumshirn
2017-07-14 12:48 ` Christoph Hellwig
2017-07-14 12:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714123208.GE26187@lst.de \
--to=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.