From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jonathan Cameron <jic23@kernel.org>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v3 3/5] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor
Date: Mon, 24 Jul 2017 10:29:38 +0200 [thread overview]
Message-ID: <20170724082938.vsq3zd22vb6lqvu3@flea> (raw)
In-Reply-To: <20170723141354.42646-4-icenowy@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
On Sun, Jul 23, 2017 at 10:13:52PM +0800, Icenowy Zheng wrote:
> This adds support for the Allwinner H3 thermal sensor.
>
> Allwinner H3 has a thermal sensor like the one in A33, but have its
> registers nearly all re-arranged, sample clock moved to CCU and a pair
> of bus clock and reset added. It's also the base of newer SoCs' thermal
> sensors.
>
> Some new options is added to gpadc_data struct, to mark the difference
> between the old GPADCs and THS's and the new THS's.
>
> Thermal sampling via interrupts are still not supported, and polling
> is used instead.
>
> The thermal sensors on A64 and H5 is like the one on H3, but with of
> course different formula factors.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Could you split it in half? One patch that would rework the existing
code, the other one adding the H3 support?
That's going to be much easier to review, bisect and revert if need be
that way.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Quentin Schulz
<quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v3 3/5] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor
Date: Mon, 24 Jul 2017 10:29:38 +0200 [thread overview]
Message-ID: <20170724082938.vsq3zd22vb6lqvu3@flea> (raw)
In-Reply-To: <20170723141354.42646-4-icenowy-h8G6r0blFSE@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Sun, Jul 23, 2017 at 10:13:52PM +0800, Icenowy Zheng wrote:
> This adds support for the Allwinner H3 thermal sensor.
>
> Allwinner H3 has a thermal sensor like the one in A33, but have its
> registers nearly all re-arranged, sample clock moved to CCU and a pair
> of bus clock and reset added. It's also the base of newer SoCs' thermal
> sensors.
>
> Some new options is added to gpadc_data struct, to mark the difference
> between the old GPADCs and THS's and the new THS's.
>
> Thermal sampling via interrupts are still not supported, and polling
> is used instead.
>
> The thermal sensors on A64 and H5 is like the one on H3, but with of
> course different formula factors.
>
> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Could you split it in half? One patch that would rework the existing
code, the other one adding the H3 support?
That's going to be much easier to review, bisect and revert if need be
that way.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor
Date: Mon, 24 Jul 2017 10:29:38 +0200 [thread overview]
Message-ID: <20170724082938.vsq3zd22vb6lqvu3@flea> (raw)
In-Reply-To: <20170723141354.42646-4-icenowy@aosc.io>
On Sun, Jul 23, 2017 at 10:13:52PM +0800, Icenowy Zheng wrote:
> This adds support for the Allwinner H3 thermal sensor.
>
> Allwinner H3 has a thermal sensor like the one in A33, but have its
> registers nearly all re-arranged, sample clock moved to CCU and a pair
> of bus clock and reset added. It's also the base of newer SoCs' thermal
> sensors.
>
> Some new options is added to gpadc_data struct, to mark the difference
> between the old GPADCs and THS's and the new THS's.
>
> Thermal sampling via interrupts are still not supported, and polling
> is used instead.
>
> The thermal sensors on A64 and H5 is like the one on H3, but with of
> course different formula factors.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
Could you split it in half? One patch that would rework the existing
code, the other one adding the H3 support?
That's going to be much easier to review, bisect and revert if need be
that way.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170724/8d45bb9e/attachment.sig>
next prev parent reply other threads:[~2017-07-24 8:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 14:13 [PATCH v3 0/5] IIO-based thermal sensor driver for Allwinner H3 SoC Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` [PATCH v3 1/5] dt-bindings: update the Allwinner GPADC device tree binding for H3 Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-24 6:01 ` [linux-sunxi] " Chen-Yu Tsai
2017-07-24 6:01 ` Chen-Yu Tsai
2017-07-24 6:01 ` Chen-Yu Tsai
2017-07-24 6:05 ` Chen-Yu Tsai
2017-07-24 6:05 ` Chen-Yu Tsai
2017-07-24 6:05 ` Chen-Yu Tsai
2017-08-03 16:31 ` Rob Herring
2017-08-03 16:31 ` Rob Herring
2017-08-03 16:31 ` Rob Herring
2017-08-08 10:51 ` Lee Jones
2017-08-08 10:51 ` Lee Jones
2017-08-08 10:51 ` Lee Jones
2017-08-08 11:56 ` [linux-sunxi] " Vincent Legoll
2017-08-08 11:56 ` Vincent Legoll
2017-08-08 11:56 ` Vincent Legoll
2017-07-23 14:13 ` [PATCH v3 2/5] iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to contain A23 Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-24 6:02 ` [linux-sunxi] " Chen-Yu Tsai
2017-07-24 6:02 ` Chen-Yu Tsai
2017-07-24 6:02 ` Chen-Yu Tsai
2017-07-24 6:06 ` icenowy
2017-07-24 6:06 ` icenowy at aosc.io
2017-07-24 6:06 ` icenowy
2017-07-24 6:06 ` icenowy-h8G6r0blFSE
2017-07-24 6:14 ` Chen-Yu Tsai
2017-07-24 6:14 ` Chen-Yu Tsai
2017-07-24 6:14 ` Chen-Yu Tsai
2017-07-23 14:13 ` [PATCH v3 3/5] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 16:35 ` Jonathan Cameron
2017-07-23 16:35 ` Jonathan Cameron
2017-07-23 16:35 ` Jonathan Cameron
2017-07-24 8:29 ` Maxime Ripard [this message]
2017-07-24 8:29 ` Maxime Ripard
2017-07-24 8:29 ` Maxime Ripard
2017-07-24 22:10 ` kbuild test robot
2017-07-24 22:10 ` kbuild test robot
2017-07-24 22:10 ` kbuild test robot
2017-07-24 22:14 ` kbuild test robot
2017-07-24 22:14 ` kbuild test robot
2017-07-24 22:14 ` kbuild test robot
2017-07-23 14:13 ` [PATCH v3 4/5] ARM: sun8i: h3: add support for the thermal sensor in H3 Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-24 6:07 ` [linux-sunxi] " Chen-Yu Tsai
2017-07-24 6:07 ` Chen-Yu Tsai
2017-07-24 6:07 ` Chen-Yu Tsai
2017-07-23 14:13 ` [PATCH v3 5/5] ARM: sun8i: h3: add partial CPU thermal zone Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724082938.vsq3zd22vb6lqvu3@flea \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=quentin.schulz@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.