From: Chen-Yu Tsai <wens@csie.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Jonathan Cameron <jic23@kernel.org>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-iio@vger.kernel.org,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH v3 2/5] iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to contain A23
Date: Mon, 24 Jul 2017 14:02:38 +0800 [thread overview]
Message-ID: <CAGb2v65a3tyr5EJLgB9mhz2aYsU9NkMSg+wF_aJuhmT3tNpL2w@mail.gmail.com> (raw)
In-Reply-To: <20170723141354.42646-3-icenowy@aosc.io>
On Sun, Jul 23, 2017 at 10:13 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> As the H3 SoC, which is also in sun8i line, has totally different
> register map for the thermal sensor (a cut down version of GPADC), we
> should rename A23/A33-specified registers to contain A23, in order to
> prevent obfuscation with H3 registers. Currently these registers are
> only prefixed "SUN8I", not "SUN8I_A23".
>
> Add "_A23" after "SUN8I" on the register names.
Nit: the compatible string as well as the initial driver targets the A33.
Naming the registers as such would be more consistent.
Otherwise,
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Quentin Schulz
<quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [linux-sunxi] [PATCH v3 2/5] iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to contain A23
Date: Mon, 24 Jul 2017 14:02:38 +0800 [thread overview]
Message-ID: <CAGb2v65a3tyr5EJLgB9mhz2aYsU9NkMSg+wF_aJuhmT3tNpL2w@mail.gmail.com> (raw)
In-Reply-To: <20170723141354.42646-3-icenowy-h8G6r0blFSE@public.gmane.org>
On Sun, Jul 23, 2017 at 10:13 PM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote:
> As the H3 SoC, which is also in sun8i line, has totally different
> register map for the thermal sensor (a cut down version of GPADC), we
> should rename A23/A33-specified registers to contain A23, in order to
> prevent obfuscation with H3 registers. Currently these registers are
> only prefixed "SUN8I", not "SUN8I_A23".
>
> Add "_A23" after "SUN8I" on the register names.
Nit: the compatible string as well as the initial driver targets the A33.
Naming the registers as such would be more consistent.
Otherwise,
Reviewed-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH v3 2/5] iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to contain A23
Date: Mon, 24 Jul 2017 14:02:38 +0800 [thread overview]
Message-ID: <CAGb2v65a3tyr5EJLgB9mhz2aYsU9NkMSg+wF_aJuhmT3tNpL2w@mail.gmail.com> (raw)
In-Reply-To: <20170723141354.42646-3-icenowy@aosc.io>
On Sun, Jul 23, 2017 at 10:13 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> As the H3 SoC, which is also in sun8i line, has totally different
> register map for the thermal sensor (a cut down version of GPADC), we
> should rename A23/A33-specified registers to contain A23, in order to
> prevent obfuscation with H3 registers. Currently these registers are
> only prefixed "SUN8I", not "SUN8I_A23".
>
> Add "_A23" after "SUN8I" on the register names.
Nit: the compatible string as well as the initial driver targets the A33.
Naming the registers as such would be more consistent.
Otherwise,
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
next prev parent reply other threads:[~2017-07-24 6:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 14:13 [PATCH v3 0/5] IIO-based thermal sensor driver for Allwinner H3 SoC Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` [PATCH v3 1/5] dt-bindings: update the Allwinner GPADC device tree binding for H3 Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-24 6:01 ` [linux-sunxi] " Chen-Yu Tsai
2017-07-24 6:01 ` Chen-Yu Tsai
2017-07-24 6:01 ` Chen-Yu Tsai
2017-07-24 6:05 ` Chen-Yu Tsai
2017-07-24 6:05 ` Chen-Yu Tsai
2017-07-24 6:05 ` Chen-Yu Tsai
2017-08-03 16:31 ` Rob Herring
2017-08-03 16:31 ` Rob Herring
2017-08-03 16:31 ` Rob Herring
2017-08-08 10:51 ` Lee Jones
2017-08-08 10:51 ` Lee Jones
2017-08-08 10:51 ` Lee Jones
2017-08-08 11:56 ` [linux-sunxi] " Vincent Legoll
2017-08-08 11:56 ` Vincent Legoll
2017-08-08 11:56 ` Vincent Legoll
2017-07-23 14:13 ` [PATCH v3 2/5] iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to contain A23 Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-24 6:02 ` Chen-Yu Tsai [this message]
2017-07-24 6:02 ` [linux-sunxi] " Chen-Yu Tsai
2017-07-24 6:02 ` Chen-Yu Tsai
2017-07-24 6:06 ` icenowy
2017-07-24 6:06 ` icenowy at aosc.io
2017-07-24 6:06 ` icenowy
2017-07-24 6:06 ` icenowy-h8G6r0blFSE
2017-07-24 6:14 ` Chen-Yu Tsai
2017-07-24 6:14 ` Chen-Yu Tsai
2017-07-24 6:14 ` Chen-Yu Tsai
2017-07-23 14:13 ` [PATCH v3 3/5] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 16:35 ` Jonathan Cameron
2017-07-23 16:35 ` Jonathan Cameron
2017-07-23 16:35 ` Jonathan Cameron
2017-07-24 8:29 ` Maxime Ripard
2017-07-24 8:29 ` Maxime Ripard
2017-07-24 8:29 ` Maxime Ripard
2017-07-24 22:10 ` kbuild test robot
2017-07-24 22:10 ` kbuild test robot
2017-07-24 22:10 ` kbuild test robot
2017-07-24 22:14 ` kbuild test robot
2017-07-24 22:14 ` kbuild test robot
2017-07-24 22:14 ` kbuild test robot
2017-07-23 14:13 ` [PATCH v3 4/5] ARM: sun8i: h3: add support for the thermal sensor in H3 Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-24 6:07 ` [linux-sunxi] " Chen-Yu Tsai
2017-07-24 6:07 ` Chen-Yu Tsai
2017-07-24 6:07 ` Chen-Yu Tsai
2017-07-23 14:13 ` [PATCH v3 5/5] ARM: sun8i: h3: add partial CPU thermal zone Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
2017-07-23 14:13 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v65a3tyr5EJLgB9mhz2aYsU9NkMSg+wF_aJuhmT3tNpL2w@mail.gmail.com \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=quentin.schulz@free-electrons.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.