From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Mark Brown <broonie@kernel.org>, Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible
Date: Fri, 4 Aug 2017 13:24:08 +0300 [thread overview]
Message-ID: <20170804102408.GX2369@lahna.fi.intel.com> (raw)
In-Reply-To: <b411858d-6a09-a3bc-555d-b1e648b9c8ed@siemens.com>
On Fri, Aug 04, 2017 at 12:18:28PM +0200, Jan Kiszka wrote:
> On 2017-08-04 12:10, Mika Westerberg wrote:
> > On Thu, Aug 03, 2017 at 01:40:32PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> We still need to request/free GPIOs passed via the legacy path of
> >> pxa2xx_spi_chip::gpio_cs, but we can use the gpiod API otherwise.
> >>
> >> Consistently use the descriptor API instead of the legacy one.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > There are some PXA2xx platforms under arch/arm/* which use this driver
> > and legacy GPIOs. I wonder if this causes any problems with them?
> >
> > That was one of the reasons I did not convert the whole driver over GPIO
> > descriptors.
>
> It shouldn't cause problems (famous last words) because I refrained from
> changing the interfaces to them. References that come in as legacy GPIO
> are still treated like that.
OK. I hope someone with a PXA2xx machine could still test it.
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>,
Haojian Zhuang
<haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>,
Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible
Date: Fri, 4 Aug 2017 13:24:08 +0300 [thread overview]
Message-ID: <20170804102408.GX2369@lahna.fi.intel.com> (raw)
In-Reply-To: <b411858d-6a09-a3bc-555d-b1e648b9c8ed-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
On Fri, Aug 04, 2017 at 12:18:28PM +0200, Jan Kiszka wrote:
> On 2017-08-04 12:10, Mika Westerberg wrote:
> > On Thu, Aug 03, 2017 at 01:40:32PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
> >>
> >> We still need to request/free GPIOs passed via the legacy path of
> >> pxa2xx_spi_chip::gpio_cs, but we can use the gpiod API otherwise.
> >>
> >> Consistently use the descriptor API instead of the legacy one.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
> >
> > There are some PXA2xx platforms under arch/arm/* which use this driver
> > and legacy GPIOs. I wonder if this causes any problems with them?
> >
> > That was one of the reasons I did not convert the whole driver over GPIO
> > descriptors.
>
> It shouldn't cause problems (famous last words) because I refrained from
> changing the interfaces to them. References that come in as legacy GPIO
> are still treated like that.
OK. I hope someone with a PXA2xx machine could still test it.
Acked-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mika.westerberg@linux.intel.com (Mika Westerberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible
Date: Fri, 4 Aug 2017 13:24:08 +0300 [thread overview]
Message-ID: <20170804102408.GX2369@lahna.fi.intel.com> (raw)
In-Reply-To: <b411858d-6a09-a3bc-555d-b1e648b9c8ed@siemens.com>
On Fri, Aug 04, 2017 at 12:18:28PM +0200, Jan Kiszka wrote:
> On 2017-08-04 12:10, Mika Westerberg wrote:
> > On Thu, Aug 03, 2017 at 01:40:32PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> We still need to request/free GPIOs passed via the legacy path of
> >> pxa2xx_spi_chip::gpio_cs, but we can use the gpiod API otherwise.
> >>
> >> Consistently use the descriptor API instead of the legacy one.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > There are some PXA2xx platforms under arch/arm/* which use this driver
> > and legacy GPIOs. I wonder if this causes any problems with them?
> >
> > That was one of the reasons I did not convert the whole driver over GPIO
> > descriptors.
>
> It shouldn't cause problems (famous last words) because I refrained from
> changing the interfaces to them. References that come in as legacy GPIO
> are still treated like that.
OK. I hope someone with a PXA2xx machine could still test it.
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2017-08-04 10:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 11:40 [PATCH RFC 0/2] spi: pxa2xx: gpiod cleanups and late CS GPIO allocation Jan Kiszka
2017-08-03 11:40 ` Jan Kiszka
2017-08-03 11:40 ` [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible Jan Kiszka
2017-08-03 11:40 ` Jan Kiszka
2017-08-03 11:40 ` Jan Kiszka
2017-08-04 10:10 ` Mika Westerberg
2017-08-04 10:10 ` Mika Westerberg
2017-08-04 10:10 ` Mika Westerberg
2017-08-04 10:18 ` Jan Kiszka
2017-08-04 10:18 ` Jan Kiszka
2017-08-04 10:18 ` Jan Kiszka
2017-08-04 10:24 ` Mika Westerberg [this message]
2017-08-04 10:24 ` Mika Westerberg
2017-08-04 10:24 ` Mika Westerberg
2017-08-04 11:43 ` Mark Brown
2017-08-04 11:43 ` Mark Brown
2017-08-04 11:43 ` Mark Brown
2017-08-04 11:44 ` Applied "spi: pxa2xx: Convert to GPIO descriptor API where possible" to the spi tree Mark Brown
2017-08-04 11:44 ` Mark Brown
2017-08-04 11:44 ` Mark Brown
2017-08-03 11:40 ` [PATCH RFC 2/2] spi: pxa2xx: Only claim CS GPIOs when the slave device is created Jan Kiszka
2017-08-03 11:40 ` Jan Kiszka
2017-08-03 11:40 ` Jan Kiszka
2017-08-04 10:29 ` Mika Westerberg
2017-08-04 10:29 ` Mika Westerberg
2017-08-04 10:29 ` Mika Westerberg
2017-08-04 11:43 ` Mark Brown
2017-08-04 11:43 ` Mark Brown
2017-08-04 11:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804102408.GX2369@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.