From: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
To: Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
Cc: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
Chris Paterson
<chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi
Date: Thu, 10 Aug 2017 10:01:21 +0200 [thread overview]
Message-ID: <20170810080121.GE16647@verge.net.au> (raw)
In-Reply-To: <12d923ba-184c-ef59-f27b-41a7592a5f93-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
On Wed, Aug 09, 2017 at 12:17:06PM +0300, Sergei Shtylyov wrote:
> On 8/8/2017 3:46 PM, Biju Das wrote:
>
> >Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> >---
> >This patch has been tested against Linux-next tag 20170727 and renesas-dev branch.
> >This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html
> >
> > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 55 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> >index 14222c72..5c2b140 100644
> >--- a/arch/arm/boot/dts/r8a7743.dtsi
> >+++ b/arch/arm/boot/dts/r8a7743.dtsi
> [...]
> >@@ -436,6 +439,58 @@
> > status = "disabled";
> > };
> >+ i2c6: i2c@e60b0000 {
>
> I'd use iic0 as the label.
I have no preference here other than that we try to be consistent
in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
>
> >+ /* doesn't need pinmux */
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "renesas,iic-r8a7743",
> >+ "renesas,rcar-gen2-iic",
> >+ "renesas,rmobile-iic";
> >+ reg = <0 0xe60b0000 0 0x425>;
> >+ interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> >+ clocks = <&cpg CPG_MOD 926>;
> >+ dmas = <&dmac0 0x77>, <&dmac0 0x78>,
> >+ <&dmac1 0x77>, <&dmac1 0x78>;
> >+ dma-names = "tx", "rx", "tx", "rx";
> >+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> >+ resets = <&cpg CPG_MOD 926>;
>
> CPG_MOD not needed here, it's not a "clocks" prop.
>
> [...]
>
> MBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Biju Das <biju.das@bp.renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Wolfram Sang <wsa@the-dreams.de>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Chris Paterson <chris.paterson2@renesas.com>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi
Date: Thu, 10 Aug 2017 10:01:21 +0200 [thread overview]
Message-ID: <20170810080121.GE16647@verge.net.au> (raw)
In-Reply-To: <12d923ba-184c-ef59-f27b-41a7592a5f93@cogentembedded.com>
On Wed, Aug 09, 2017 at 12:17:06PM +0300, Sergei Shtylyov wrote:
> On 8/8/2017 3:46 PM, Biju Das wrote:
>
> >Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >---
> >This patch has been tested against Linux-next tag 20170727 and renesas-dev branch.
> >This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html
> >
> > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 55 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> >index 14222c72..5c2b140 100644
> >--- a/arch/arm/boot/dts/r8a7743.dtsi
> >+++ b/arch/arm/boot/dts/r8a7743.dtsi
> [...]
> >@@ -436,6 +439,58 @@
> > status = "disabled";
> > };
> >+ i2c6: i2c@e60b0000 {
>
> I'd use iic0 as the label.
I have no preference here other than that we try to be consistent
in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
>
> >+ /* doesn't need pinmux */
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "renesas,iic-r8a7743",
> >+ "renesas,rcar-gen2-iic",
> >+ "renesas,rmobile-iic";
> >+ reg = <0 0xe60b0000 0 0x425>;
> >+ interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> >+ clocks = <&cpg CPG_MOD 926>;
> >+ dmas = <&dmac0 0x77>, <&dmac0 0x78>,
> >+ <&dmac1 0x77>, <&dmac1 0x78>;
> >+ dma-names = "tx", "rx", "tx", "rx";
> >+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> >+ resets = <&cpg CPG_MOD 926>;
>
> CPG_MOD not needed here, it's not a "clocks" prop.
>
> [...]
>
> MBR, Sergei
>
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi
Date: Thu, 10 Aug 2017 10:01:21 +0200 [thread overview]
Message-ID: <20170810080121.GE16647@verge.net.au> (raw)
In-Reply-To: <12d923ba-184c-ef59-f27b-41a7592a5f93@cogentembedded.com>
On Wed, Aug 09, 2017 at 12:17:06PM +0300, Sergei Shtylyov wrote:
> On 8/8/2017 3:46 PM, Biju Das wrote:
>
> >Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >---
> >This patch has been tested against Linux-next tag 20170727 and renesas-dev branch.
> >This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html
> >
> > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 55 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> >index 14222c72..5c2b140 100644
> >--- a/arch/arm/boot/dts/r8a7743.dtsi
> >+++ b/arch/arm/boot/dts/r8a7743.dtsi
> [...]
> >@@ -436,6 +439,58 @@
> > status = "disabled";
> > };
> >+ i2c6: i2c at e60b0000 {
>
> I'd use iic0 as the label.
I have no preference here other than that we try to be consistent
in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
>
> >+ /* doesn't need pinmux */
> >+ #address-cells = <1>;
> >+ #size-cells = <0>;
> >+ compatible = "renesas,iic-r8a7743",
> >+ "renesas,rcar-gen2-iic",
> >+ "renesas,rmobile-iic";
> >+ reg = <0 0xe60b0000 0 0x425>;
> >+ interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> >+ clocks = <&cpg CPG_MOD 926>;
> >+ dmas = <&dmac0 0x77>, <&dmac0 0x78>,
> >+ <&dmac1 0x77>, <&dmac1 0x78>;
> >+ dma-names = "tx", "rx", "tx", "rx";
> >+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> >+ resets = <&cpg CPG_MOD 926>;
>
> CPG_MOD not needed here, it's not a "clocks" prop.
>
> [...]
>
> MBR, Sergei
>
next prev parent reply other threads:[~2017-08-10 8:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 12:46 [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi Biju Das
2017-08-08 12:46 ` Biju Das
[not found] ` <1502196418-31341-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-08-09 8:56 ` Simon Horman
2017-08-09 8:56 ` Simon Horman
2017-08-09 8:56 ` Simon Horman
2017-08-09 9:17 ` Sergei Shtylyov
2017-08-09 9:17 ` Sergei Shtylyov
[not found] ` <12d923ba-184c-ef59-f27b-41a7592a5f93-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-08-09 9:21 ` Biju Das
2017-08-09 9:21 ` Biju Das
2017-08-09 9:21 ` Biju Das
2017-08-10 8:01 ` Simon Horman [this message]
2017-08-10 8:01 ` Simon Horman
2017-08-10 8:01 ` Simon Horman
[not found] ` <20170810080121.GE16647-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-08-10 11:24 ` Wolfram Sang
2017-08-10 11:24 ` Wolfram Sang
2017-08-10 11:24 ` Wolfram Sang
2017-08-10 13:49 ` Chris Paterson
2017-08-10 13:49 ` Chris Paterson
2017-08-10 13:49 ` Chris Paterson
2017-08-11 8:48 ` Simon Horman
2017-08-11 8:48 ` Simon Horman
2017-08-14 14:15 ` Geert Uytterhoeven
2017-08-14 14:15 ` Geert Uytterhoeven
2017-08-22 12:20 ` Sergei Shtylyov
2017-08-22 12:20 ` Sergei Shtylyov
2017-08-14 9:53 ` [PATCH v2] ARM: dts: r8a7743: add " Biju Das
2017-08-14 9:53 ` Biju Das
2017-08-14 9:53 ` Biju Das
2017-08-22 9:10 ` Chris Paterson
2017-08-22 9:10 ` Chris Paterson
2017-08-22 9:10 ` Chris Paterson
[not found] ` <TY1PR06MB07027D9A55FBFE2D591CEDCFB7840-/PRLmSCtZ14u2TXDOttQZW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-08-22 12:23 ` Sergei Shtylyov
2017-08-22 12:23 ` Sergei Shtylyov
2017-08-22 12:23 ` Sergei Shtylyov
[not found] ` <b7434757-b151-5971-2b5f-525eeaf11467-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-08-30 7:32 ` Simon Horman
2017-08-30 7:32 ` Simon Horman
2017-08-30 7:32 ` Simon Horman
[not found] ` <20170830073214.GL10398-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-08-30 7:46 ` Chris Paterson
2017-08-30 7:46 ` Chris Paterson
2017-08-30 7:46 ` Chris Paterson
[not found] ` <1502704398-28378-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-09-06 13:52 ` [PATCH v3] ARM: dts: r8a7743: Add " Chris Paterson
2017-09-06 13:52 ` Chris Paterson
2017-09-06 13:52 ` Chris Paterson
[not found] ` <1504705926-31625-1-git-send-email-chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-09-11 7:25 ` Simon Horman
2017-09-11 7:25 ` Simon Horman
2017-09-11 7:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810080121.GE16647@verge.net.au \
--to=horms-/r6kz+ddxgppr4jqbcensq@public.gmane.org \
--cc=biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org \
--cc=chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.