All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/gma500: fix potential NULL pointer dereference dereference
Date: Mon, 14 Aug 2017 16:12:14 +0200	[thread overview]
Message-ID: <20170814141213.gebdusrrzfbkzl2c@phenom.ffwll.local> (raw)
In-Reply-To: <20170812015515.GA8360@embeddedgus>

On Fri, Aug 11, 2017 at 08:55:15PM -0500, Gustavo A. R. Silva wrote:
> NULL check at line 528: if (!sender || !data_out || !len_out) {, implies
> that pointer _sender_ might be NULL.
> 
> Move pointer _sender_ dereference after NULL check in order to avoid a
> potential NULL pointer dereference.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied to drm-misc-next, thanks.
-Daniel

> ---
>  drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> index 1616af2..c50534c 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> @@ -520,7 +520,7 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
>  			u8 *data, u16 len, u32 *data_out, u16 len_out, bool hs)
>  {
>  	unsigned long flags;
> -	struct drm_device *dev = sender->dev;
> +	struct drm_device *dev;
>  	int i;
>  	u32 gen_data_reg;
>  	int retry = MDFLD_DSI_READ_MAX_COUNT;
> @@ -530,6 +530,8 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
>  		return -EINVAL;
>  	}
>  
> +	dev = sender->dev;
> +
>  	/**
>  	 * do reading.
>  	 * 0) send out generic read request
> -- 
> 2.5.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/gma500: fix potential NULL pointer dereference dereference
Date: Mon, 14 Aug 2017 16:12:14 +0200	[thread overview]
Message-ID: <20170814141213.gebdusrrzfbkzl2c@phenom.ffwll.local> (raw)
In-Reply-To: <20170812015515.GA8360@embeddedgus>

On Fri, Aug 11, 2017 at 08:55:15PM -0500, Gustavo A. R. Silva wrote:
> NULL check at line 528: if (!sender || !data_out || !len_out) {, implies
> that pointer _sender_ might be NULL.
> 
> Move pointer _sender_ dereference after NULL check in order to avoid a
> potential NULL pointer dereference.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied to drm-misc-next, thanks.
-Daniel

> ---
>  drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> index 1616af2..c50534c 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> @@ -520,7 +520,7 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
>  			u8 *data, u16 len, u32 *data_out, u16 len_out, bool hs)
>  {
>  	unsigned long flags;
> -	struct drm_device *dev = sender->dev;
> +	struct drm_device *dev;
>  	int i;
>  	u32 gen_data_reg;
>  	int retry = MDFLD_DSI_READ_MAX_COUNT;
> @@ -530,6 +530,8 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
>  		return -EINVAL;
>  	}
>  
> +	dev = sender->dev;
> +
>  	/**
>  	 * do reading.
>  	 * 0) send out generic read request
> -- 
> 2.5.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-08-14 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-12  1:55 [PATCH] drm/gma500: fix potential NULL pointer dereference dereference Gustavo A. R. Silva
2017-08-14 14:12 ` Daniel Vetter [this message]
2017-08-14 14:12   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814141213.gebdusrrzfbkzl2c@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.