* [PATCH] drm/gma500: fix potential NULL pointer dereference dereference
@ 2017-08-12 1:55 Gustavo A. R. Silva
2017-08-14 14:12 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-08-12 1:55 UTC (permalink / raw)
To: Patrik Jakobsson, David Airlie
Cc: dri-devel, linux-kernel, Gustavo A. R. Silva
NULL check at line 528: if (!sender || !data_out || !len_out) {, implies
that pointer _sender_ might be NULL.
Move pointer _sender_ dereference after NULL check in order to avoid a
potential NULL pointer dereference.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
index 1616af2..c50534c 100644
--- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
+++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
@@ -520,7 +520,7 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
u8 *data, u16 len, u32 *data_out, u16 len_out, bool hs)
{
unsigned long flags;
- struct drm_device *dev = sender->dev;
+ struct drm_device *dev;
int i;
u32 gen_data_reg;
int retry = MDFLD_DSI_READ_MAX_COUNT;
@@ -530,6 +530,8 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
return -EINVAL;
}
+ dev = sender->dev;
+
/**
* do reading.
* 0) send out generic read request
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/gma500: fix potential NULL pointer dereference dereference
2017-08-12 1:55 [PATCH] drm/gma500: fix potential NULL pointer dereference dereference Gustavo A. R. Silva
@ 2017-08-14 14:12 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2017-08-14 14:12 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Patrik Jakobsson, David Airlie, linux-kernel, dri-devel
On Fri, Aug 11, 2017 at 08:55:15PM -0500, Gustavo A. R. Silva wrote:
> NULL check at line 528: if (!sender || !data_out || !len_out) {, implies
> that pointer _sender_ might be NULL.
>
> Move pointer _sender_ dereference after NULL check in order to avoid a
> potential NULL pointer dereference.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> index 1616af2..c50534c 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> @@ -520,7 +520,7 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
> u8 *data, u16 len, u32 *data_out, u16 len_out, bool hs)
> {
> unsigned long flags;
> - struct drm_device *dev = sender->dev;
> + struct drm_device *dev;
> int i;
> u32 gen_data_reg;
> int retry = MDFLD_DSI_READ_MAX_COUNT;
> @@ -530,6 +530,8 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
> return -EINVAL;
> }
>
> + dev = sender->dev;
> +
> /**
> * do reading.
> * 0) send out generic read request
> --
> 2.5.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/gma500: fix potential NULL pointer dereference dereference
@ 2017-08-14 14:12 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2017-08-14 14:12 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: dri-devel, linux-kernel
On Fri, Aug 11, 2017 at 08:55:15PM -0500, Gustavo A. R. Silva wrote:
> NULL check at line 528: if (!sender || !data_out || !len_out) {, implies
> that pointer _sender_ might be NULL.
>
> Move pointer _sender_ dereference after NULL check in order to avoid a
> potential NULL pointer dereference.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> index 1616af2..c50534c 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c
> @@ -520,7 +520,7 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
> u8 *data, u16 len, u32 *data_out, u16 len_out, bool hs)
> {
> unsigned long flags;
> - struct drm_device *dev = sender->dev;
> + struct drm_device *dev;
> int i;
> u32 gen_data_reg;
> int retry = MDFLD_DSI_READ_MAX_COUNT;
> @@ -530,6 +530,8 @@ static int __read_panel_data(struct mdfld_dsi_pkg_sender *sender, u8 data_type,
> return -EINVAL;
> }
>
> + dev = sender->dev;
> +
> /**
> * do reading.
> * 0) send out generic read request
> --
> 2.5.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-14 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-12 1:55 [PATCH] drm/gma500: fix potential NULL pointer dereference dereference Gustavo A. R. Silva
2017-08-14 14:12 ` Daniel Vetter
2017-08-14 14:12 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.