All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Tom Rini <trini@konsulko.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
Date: Thu, 24 Aug 2017 16:52:35 +0100	[thread overview]
Message-ID: <20170824155235.2nrqjiwlo3afk4ei@sirena.org.uk> (raw)
In-Reply-To: <s5h60ddj7l8.wl-tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:

> OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> fix (and remove again in 4.14).

> The former is cleaner, but it's bigger, while the latter is a safer
> oneliner at the late RC stage.

> I leave the decision to Mark.

I'm happier with the oneline change TBH, like you say it's pretty late
in the release cycle.  Can you just apply the patch directly and send it
to Linus with my ack or should I put together a pull request?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Oder Chiou <oder_chiou@realtek.com>,
	Tom Rini <trini@konsulko.com>,
	alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Bard Liao <bardliao@realtek.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
Date: Thu, 24 Aug 2017 16:52:35 +0100	[thread overview]
Message-ID: <20170824155235.2nrqjiwlo3afk4ei@sirena.org.uk> (raw)
In-Reply-To: <s5h60ddj7l8.wl-tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 587 bytes --]

On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:

> OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> fix (and remove again in 4.14).

> The former is cleaner, but it's bigger, while the latter is a safer
> oneliner at the late RC stage.

> I leave the decision to Mark.

I'm happier with the oneline change TBH, like you say it's pretty late
in the release cycle.  Can you just apply the patch directly and send it
to Linus with my ack or should I put together a pull request?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2017-08-24 15:52 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  1:51 [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini
2017-08-23  1:51 ` Tom Rini
2017-08-23  9:28 ` Mark Brown
2017-08-23 22:35   ` Tom Rini
2017-08-23 22:47     ` Mark Brown
2017-08-23 22:54       ` Tom Rini
2017-08-23 22:54         ` Tom Rini
2017-08-23 23:15         ` Mark Brown
2017-08-23 23:02       ` Mark Brown
2017-08-23 14:29 ` Andy Shevchenko
2017-08-23 17:39   ` Tom Rini
2017-08-24  0:05     ` Tom Rini
2017-08-24  7:39       ` Andy Shevchenko
2017-08-24  7:39         ` Andy Shevchenko
2017-08-24 11:15         ` Tom Rini
2017-08-24 11:15           ` Tom Rini
2017-08-24 12:26           ` Andy Shevchenko
2017-08-24 13:41             ` Mark Brown
2017-08-24 13:47             ` Tom Rini
2017-08-24 14:28       ` [alsa-devel] " Takashi Iwai
2017-08-24 14:31         ` Takashi Iwai
2017-08-24 14:31           ` Takashi Iwai
2017-08-24 14:41           ` Tom Rini
2017-08-24 14:41             ` Tom Rini
2017-08-24 15:42             ` [alsa-devel] " Takashi Iwai
2017-08-24 15:52               ` Mark Brown [this message]
2017-08-24 15:52                 ` Mark Brown
2017-08-24 15:54                 ` [alsa-devel] " Takashi Iwai
2017-08-24 15:54                 ` Tom Rini
2017-08-24 16:06                   ` Takashi Iwai
2017-08-24 16:06                     ` Takashi Iwai
2017-08-24 16:08                     ` [alsa-devel] " Tom Rini
2017-08-24 17:16                     ` Andy Shevchenko
2017-08-24 17:44                       ` Takashi Iwai
2017-08-24 17:44                         ` Takashi Iwai
2017-08-25 13:48                         ` [alsa-devel] " Mark Brown
2017-08-25 13:48                           ` Mark Brown
2017-08-25 13:09                     ` [alsa-devel] " Mark Brown
2017-08-25 13:09                       ` Mark Brown
2017-08-25 13:17                       ` [alsa-devel] " Takashi Iwai
2017-08-25 13:17                         ` Takashi Iwai
2017-08-25 13:56 ` Andy Shevchenko
2017-08-25 14:24   ` Tom Rini
2017-08-25 14:24     ` Tom Rini
2017-08-25 14:49     ` Andy Shevchenko
2017-08-25 16:05     ` John Keeping
2017-08-25 16:05       ` John Keeping
2017-08-25 16:42       ` Andy Shevchenko
2017-08-25 16:42         ` Andy Shevchenko
2017-08-25 17:09         ` John Keeping
2017-08-25 19:33         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824155235.2nrqjiwlo3afk4ei@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bardliao@realtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    --cc=trini@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.