From: Takashi Iwai <tiwai@suse.de> To: Tom Rini <trini@konsulko.com> Cc: Mark Brown <broonie@kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Bard Liao <bardliao@realtek.com>, Oder Chiou <oder_chiou@realtek.com>, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Date: Thu, 24 Aug 2017 18:06:20 +0200 [thread overview] Message-ID: <s5h1so1j6gz.wl-tiwai@suse.de> (raw) In-Reply-To: <20170824155437.GF17193@bill-the-cat> On Thu, 24 Aug 2017 17:54:37 +0200, Tom Rini wrote: > > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote: > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote: > > > > > OK, so the fix for 4.13 would be either to cherry-pick this commit, or > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid > > > fix (and remove again in 4.14). > > > > > The former is cleaner, but it's bigger, while the latter is a safer > > > oneliner at the late RC stage. > > > > > I leave the decision to Mark. > > > > I'm happier with the oneline change TBH, like you say it's pretty late > > in the release cycle. Can you just apply the patch directly and send it > > to Linus with my ack or should I put together a pull request? > > FWIW, I'd be happy to give the change a quick spin and Tested-by it. Well, it's your patch, after all :) Below is the patch I'm going to queue. Takashi -- 8< -- From: Tom Rini <trini@konsulko.com> Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model. [ More background note: the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...") moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper acpi_device_id table. Although the action itself is correct per se, the overseen issue is the reference id->driver_data at rt5677_i2c_probe() for retrieving the corresponding chip model for the given id. Since id=NULL is passed for ACPI matching case, we get an Oops now. We already have queued more fixes for 4.14 and they already address the issue, but they are bigger changes that aren't preferable for the late 4.13-rc stage. So, this patch just papers over the bug as a once-off quick fix for a particular ACPI matching. -- tiwai ] Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI enumeration") Signed-off-by: Tom Rini <trini@konsulko.com> Acked-by: Mark Brown <broonie@kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/soc/codecs/rt5677.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 36e530a36c82..6f629278d982 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap = { static const struct i2c_device_id rt5677_i2c_id[] = { { "rt5677", RT5677 }, { "rt5676", RT5676 }, + { "RT5677CE:00", RT5677 }, { } }; MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id); -- 2.14.0
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de> To: Tom Rini <trini@konsulko.com> Cc: Oder Chiou <oder_chiou@realtek.com>, alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>, Bard Liao <bardliao@realtek.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Linus Torvalds <torvalds@linux-foundation.org> Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Date: Thu, 24 Aug 2017 18:06:20 +0200 [thread overview] Message-ID: <s5h1so1j6gz.wl-tiwai@suse.de> (raw) In-Reply-To: <20170824155437.GF17193@bill-the-cat> On Thu, 24 Aug 2017 17:54:37 +0200, Tom Rini wrote: > > On Thu, Aug 24, 2017 at 04:52:35PM +0100, Mark Brown wrote: > > On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote: > > > > > OK, so the fix for 4.13 would be either to cherry-pick this commit, or > > > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid > > > fix (and remove again in 4.14). > > > > > The former is cleaner, but it's bigger, while the latter is a safer > > > oneliner at the late RC stage. > > > > > I leave the decision to Mark. > > > > I'm happier with the oneline change TBH, like you say it's pretty late > > in the release cycle. Can you just apply the patch directly and send it > > to Linus with my ack or should I put together a pull request? > > FWIW, I'd be happy to give the change a quick spin and Tested-by it. Well, it's your patch, after all :) Below is the patch I'm going to queue. Takashi -- 8< -- From: Tom Rini <trini@konsulko.com> Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model. [ More background note: the commit a36afb0ab648 ("ASoC: rt5677: Introduce proper table...") moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper acpi_device_id table. Although the action itself is correct per se, the overseen issue is the reference id->driver_data at rt5677_i2c_probe() for retrieving the corresponding chip model for the given id. Since id=NULL is passed for ACPI matching case, we get an Oops now. We already have queued more fixes for 4.14 and they already address the issue, but they are bigger changes that aren't preferable for the late 4.13-rc stage. So, this patch just papers over the bug as a once-off quick fix for a particular ACPI matching. -- tiwai ] Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI enumeration") Signed-off-by: Tom Rini <trini@konsulko.com> Acked-by: Mark Brown <broonie@kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/soc/codecs/rt5677.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 36e530a36c82..6f629278d982 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5021,6 +5021,7 @@ static const struct regmap_config rt5677_regmap = { static const struct i2c_device_id rt5677_i2c_id[] = { { "rt5677", RT5677 }, { "rt5676", RT5676 }, + { "RT5677CE:00", RT5677 }, { } }; MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id); -- 2.14.0
next prev parent reply other threads:[~2017-08-24 16:06 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-23 1:51 [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini 2017-08-23 1:51 ` Tom Rini 2017-08-23 9:28 ` Mark Brown 2017-08-23 22:35 ` Tom Rini 2017-08-23 22:47 ` Mark Brown 2017-08-23 22:54 ` Tom Rini 2017-08-23 22:54 ` Tom Rini 2017-08-23 23:15 ` Mark Brown 2017-08-23 23:02 ` Mark Brown 2017-08-23 14:29 ` Andy Shevchenko 2017-08-23 17:39 ` Tom Rini 2017-08-24 0:05 ` Tom Rini 2017-08-24 7:39 ` Andy Shevchenko 2017-08-24 7:39 ` Andy Shevchenko 2017-08-24 11:15 ` Tom Rini 2017-08-24 11:15 ` Tom Rini 2017-08-24 12:26 ` Andy Shevchenko 2017-08-24 13:41 ` Mark Brown 2017-08-24 13:47 ` Tom Rini 2017-08-24 14:28 ` [alsa-devel] " Takashi Iwai 2017-08-24 14:31 ` Takashi Iwai 2017-08-24 14:31 ` Takashi Iwai 2017-08-24 14:41 ` Tom Rini 2017-08-24 14:41 ` Tom Rini 2017-08-24 15:42 ` [alsa-devel] " Takashi Iwai 2017-08-24 15:52 ` Mark Brown 2017-08-24 15:52 ` Mark Brown 2017-08-24 15:54 ` [alsa-devel] " Takashi Iwai 2017-08-24 15:54 ` Tom Rini 2017-08-24 16:06 ` Takashi Iwai [this message] 2017-08-24 16:06 ` Takashi Iwai 2017-08-24 16:08 ` [alsa-devel] " Tom Rini 2017-08-24 17:16 ` Andy Shevchenko 2017-08-24 17:44 ` Takashi Iwai 2017-08-24 17:44 ` Takashi Iwai 2017-08-25 13:48 ` [alsa-devel] " Mark Brown 2017-08-25 13:48 ` Mark Brown 2017-08-25 13:09 ` [alsa-devel] " Mark Brown 2017-08-25 13:09 ` Mark Brown 2017-08-25 13:17 ` [alsa-devel] " Takashi Iwai 2017-08-25 13:17 ` Takashi Iwai 2017-08-25 13:56 ` Andy Shevchenko 2017-08-25 14:24 ` Tom Rini 2017-08-25 14:24 ` Tom Rini 2017-08-25 14:49 ` Andy Shevchenko 2017-08-25 16:05 ` John Keeping 2017-08-25 16:05 ` John Keeping 2017-08-25 16:42 ` Andy Shevchenko 2017-08-25 16:42 ` Andy Shevchenko 2017-08-25 17:09 ` John Keeping 2017-08-25 19:33 ` Tom Rini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=s5h1so1j6gz.wl-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bardliao@realtek.com \ --cc=broonie@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=oder_chiou@realtek.com \ --cc=torvalds@linux-foundation.org \ --cc=trini@konsulko.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.