* [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support
2017-08-31 7:55 [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support Changpeng Liu
@ 2017-08-30 7:41 ` Johannes Thumshirn
2017-08-30 7:55 ` Max Gurtovoy
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2017-08-30 7:41 UTC (permalink / raw)
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support
2017-08-31 7:55 [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support Changpeng Liu
2017-08-30 7:41 ` Johannes Thumshirn
@ 2017-08-30 7:55 ` Max Gurtovoy
2017-08-30 9:54 ` Sagi Grimberg
2017-08-30 14:27 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Max Gurtovoy @ 2017-08-30 7:55 UTC (permalink / raw)
On 8/31/2017 10:55 AM, Changpeng Liu wrote:
> NVMe 1.3 specification defines the Optional Admin Command Support
> feature flags, bit 8 set to '1' then the controller supports the
> Doorbell Buffer Config command. Bit 7 is used for Virtualization
> Mangement command.
>
> Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
> ---
> include/linux/nvme.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
thanks,
Reviewed-by: Max Gurtovoy <maxg at mellanox.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support
2017-08-31 7:55 [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support Changpeng Liu
2017-08-30 7:41 ` Johannes Thumshirn
2017-08-30 7:55 ` Max Gurtovoy
@ 2017-08-30 9:54 ` Sagi Grimberg
2017-08-30 14:27 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2017-08-30 9:54 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support
2017-08-31 7:55 [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support Changpeng Liu
` (2 preceding siblings ...)
2017-08-30 9:54 ` Sagi Grimberg
@ 2017-08-30 14:27 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2017-08-30 14:27 UTC (permalink / raw)
On Thu, Aug 31, 2017@03:55:49PM +0800, Changpeng Liu wrote:
> NVMe 1.3 specification defines the Optional Admin Command Support
> feature flags, bit 8 set to '1' then the controller supports the
> Doorbell Buffer Config command. Bit 7 is used for Virtualization
> Mangement command.
>
> Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
Thanks for the fix. We also need this for 4.12+ stable.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support
@ 2017-08-31 7:55 Changpeng Liu
2017-08-30 7:41 ` Johannes Thumshirn
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Changpeng Liu @ 2017-08-31 7:55 UTC (permalink / raw)
NVMe 1.3 specification defines the Optional Admin Command Support
feature flags, bit 8 set to '1' then the controller supports the
Doorbell Buffer Config command. Bit 7 is used for Virtualization
Mangement command.
Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
---
include/linux/nvme.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 25d8225..8efff88 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -254,7 +254,7 @@ enum {
NVME_CTRL_VWC_PRESENT = 1 << 0,
NVME_CTRL_OACS_SEC_SUPP = 1 << 0,
NVME_CTRL_OACS_DIRECTIVES = 1 << 5,
- NVME_CTRL_OACS_DBBUF_SUPP = 1 << 7,
+ NVME_CTRL_OACS_DBBUF_SUPP = 1 << 8,
};
struct nvme_lbaf {
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-31 7:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 7:55 [PATCH v2] nvme: fix the definition of Admin doorbell buffer config support Changpeng Liu
2017-08-30 7:41 ` Johannes Thumshirn
2017-08-30 7:55 ` Max Gurtovoy
2017-08-30 9:54 ` Sagi Grimberg
2017-08-30 14:27 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.