[PATCH v2] nvme: fix the definition of Admin doorbell buffer config support

[PATCH v2] nvme: fix the definition of Admin doorbell buffer config support

[Changpeng Liu]

NVMe 1.3 specification defines the Optional Admin Command Support
feature flags, bit 8 set to '1' then the controller supports the
Doorbell Buffer Config command. Bit 7 is used for Virtualization
Mangement command.

Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
---
 include/linux/nvme.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 25d8225..8efff88 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -254,7 +254,7 @@ enum {
 	NVME_CTRL_VWC_PRESENT			= 1 << 0,
 	NVME_CTRL_OACS_SEC_SUPP                 = 1 << 0,
 	NVME_CTRL_OACS_DIRECTIVES		= 1 << 5,
-	NVME_CTRL_OACS_DBBUF_SUPP		= 1 << 7,
+	NVME_CTRL_OACS_DBBUF_SUPP		= 1 << 8,
 };
 
 struct nvme_lbaf {
-- 
1.9.3

[PATCH v2] nvme: fix the definition of Admin doorbell buffer config support

[Johannes Thumshirn]

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH v2] nvme: fix the definition of Admin doorbell buffer config support

[Max Gurtovoy]

On 8/31/2017 10:55 AM, Changpeng Liu wrote:
> NVMe 1.3 specification defines the Optional Admin Command Support
> feature flags, bit 8 set to '1' then the controller supports the
> Doorbell Buffer Config command. Bit 7 is used for Virtualization
> Mangement command.
> 
> Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>
> ---
>   include/linux/nvme.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

thanks,

Reviewed-by: Max Gurtovoy <maxg at mellanox.com>

[PATCH v2] nvme: fix the definition of Admin doorbell buffer config support

[Sagi Grimberg]

Reviewed-by: Sagi Grimberg <sagi at grimberg.me>

[PATCH v2] nvme: fix the definition of Admin doorbell buffer config support

[Keith Busch]

On Thu, Aug 31, 2017@03:55:49PM +0800, Changpeng Liu wrote:
> NVMe 1.3 specification defines the Optional Admin Command Support
> feature flags, bit 8 set to '1' then the controller supports the
> Doorbell Buffer Config command. Bit 7 is used for Virtualization
> Mangement command.
> 
> Signed-off-by: Changpeng Liu <changpeng.liu at intel.com>

Thanks for the fix. We also need this for 4.12+ stable.